@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix "reply" to left-side inline appearing on right side

Summary: Fixes T8098. This parameter was being misinterpreted over the wire.

Test Plan: Replied to left-side inline, got left-side reply.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8098

Differential Revision: https://secure.phabricator.com/D12747

+12 -12
+11 -11
resources/celerity/map.php
··· 11 11 'core.pkg.js' => 'ff529dc7', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => 'bb338e4b', 14 - 'differential.pkg.js' => '3cfa26f9', 14 + 'differential.pkg.js' => '895b8d62', 15 15 'diffusion.pkg.css' => '591664fa', 16 16 'diffusion.pkg.js' => '0115b37c', 17 17 'maniphest.pkg.css' => '68d4dd3d', ··· 359 359 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 360 360 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 361 361 'rsrc/js/application/differential/ChangesetViewManager.js' => '58562350', 362 - 'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '2529c82d', 362 + 'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => 'd4c87bf4', 363 363 'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18', 364 364 'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d', 365 365 'rsrc/js/application/differential/behavior-comment-preview.js' => '8e1389b5', ··· 519 519 'conpherence-widget-pane-css' => '2af42ebe', 520 520 'differential-changeset-view-css' => 'e19cfd6e', 521 521 'differential-core-view-css' => '7ac3cabc', 522 - 'differential-inline-comment-editor' => '2529c82d', 522 + 'differential-inline-comment-editor' => 'd4c87bf4', 523 523 'differential-results-table-css' => '181aa9d9', 524 524 'differential-revision-add-comment-css' => 'c47f8c40', 525 525 'differential-revision-comment-css' => '14b8565a', ··· 982 982 'phabricator-drag-and-drop-file-upload', 983 983 'phabricator-draggable-list', 984 984 ), 985 - '2529c82d' => array( 986 - 'javelin-dom', 987 - 'javelin-util', 988 - 'javelin-stratcom', 989 - 'javelin-install', 990 - 'javelin-request', 991 - 'javelin-workflow', 992 - ), 993 985 '2818f5ce' => array( 994 986 'javelin-install', 995 987 'javelin-util', ··· 1814 1806 'javelin-install', 1815 1807 'javelin-dom', 1816 1808 'javelin-view', 1809 + ), 1810 + 'd4c87bf4' => array( 1811 + 'javelin-dom', 1812 + 'javelin-util', 1813 + 'javelin-stratcom', 1814 + 'javelin-install', 1815 + 'javelin-request', 1816 + 'javelin-workflow', 1817 1817 ), 1818 1818 'd4eecc63' => array( 1819 1819 'javelin-behavior',
+1 -1
webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
··· 33 33 on_right : this.getOnRight(), 34 34 id : this.getID(), 35 35 number : this.getLineNumber(), 36 - is_new : this.getIsNew(), 36 + is_new : (this.getIsNew() ? 1 : 0), 37 37 length : this.getLength(), 38 38 changesetID : this.getChangesetID(), 39 39 text : this.getText() || '',