@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
More resilient timeline icon layout
Summary: center aligns the icons in the fill area, removes some of the positioning jank. Also set new icons for maniphest custom.
Test Plan: test desktop and mobile layouts, tested thin pins for proper centering.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T4866
Differential Revision: https://secure.phabricator.com/D8839
+14
-19
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
144
144
'rsrc/css/phui/phui-status.css' => '2f562399',
145
145
'rsrc/css/phui/phui-tag-view.css' => '295d81c4',
146
146
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
147
-
'rsrc/css/phui/phui-timeline-view.css' => '66803fc3',
147
+
'rsrc/css/phui/phui-timeline-view.css' => '7a502670',
148
148
'rsrc/css/phui/phui-workboard-view.css' => '84f2c272',
149
149
'rsrc/css/phui/phui-workpanel-view.css' => '97b69459',
150
150
'rsrc/css/sprite-actions.css' => '969ad0e5',
···
764
764
'phui-status-list-view-css' => '2f562399',
765
765
'phui-tag-view-css' => '295d81c4',
766
766
'phui-text-css' => '23e9b4b7',
767
-
'phui-timeline-view-css' => '66803fc3',
767
+
'phui-timeline-view-css' => '7a502670',
768
768
'phui-workboard-view-css' => '84f2c272',
769
769
'phui-workpanel-view-css' => '97b69459',
770
770
'policy-css' => '957ea14c',
+3
-3
src/applications/differential/storage/DifferentialTransaction.php
+3
-3
src/applications/differential/storage/DifferentialTransaction.php
···
351
351
case self::TYPE_ACTION:
352
352
switch ($this->getNewValue()) {
353
353
case DifferentialAction::ACTION_CLOSE:
354
-
return 'fa-check-square-o';
354
+
return 'fa-check';
355
355
case DifferentialAction::ACTION_ACCEPT:
356
-
return 'fa-check';
356
+
return 'fa-check-circle';
357
357
case DifferentialAction::ACTION_REJECT:
358
-
return 'fa-times';
358
+
return 'fa-times-circle';
359
359
case DifferentialAction::ACTION_ABANDON:
360
360
return 'fa-plane';
361
361
case DifferentialAction::ACTION_RETHINK:
+3
-3
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
+3
-3
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
···
102
102
'duplicate' => array(
103
103
'name' => pht('Duplicate'),
104
104
'name.full' => pht('Closed, Duplicate'),
105
-
'transaction.icon' => 'delete',
105
+
'transaction.icon' => 'fa-times',
106
106
'special' => ManiphestTaskStatus::SPECIAL_DUPLICATE,
107
107
'closed' => true,
108
108
),
···
110
110
'name' => pht('Spite'),
111
111
'name.full' => pht('Closed, Spite'),
112
112
'name.action' => pht('Spited'),
113
-
'transaction.icon' => 'dislike',
113
+
'transaction.icon' => 'fa-thumbs-o-down',
114
114
'silly' => true,
115
115
'closed' => true,
116
116
'prefixes' => array(
···
157
157
and it must be a closed status.
158
158
- `transaction.icon` //Optional string.// Allows you to choose a different
159
159
icon to use for this status when showing status changes in the transaction
160
-
log.
160
+
log. Please see UIExamples, Icons and Images for a list.
161
161
- `transaction.color` //Optional string.// Allows you to choose a different
162
162
color to use for this status when showing status changes in the transaction
163
163
log.
+1
-2
src/applications/maniphest/storage/ManiphestTransaction.php
+1
-2
src/applications/maniphest/storage/ManiphestTransaction.php
···
263
263
}
264
264
265
265
if (ManiphestTaskStatus::isClosedStatus($new)) {
266
-
return 'fa-check-square-o';
266
+
return 'fa-check';
267
267
} else {
268
268
return 'fa-pencil';
269
269
}
···
280
280
case self::TYPE_PRIORITY:
281
281
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
282
282
return 'fa-arrow-right';
283
-
return pht('Triaged');
284
283
} else if ($old > $new) {
285
284
return 'fa-arrow-down';
286
285
} else {
+5
-9
webroot/rsrc/css/phui/phui-timeline-view.css
+5
-9
webroot/rsrc/css/phui/phui-timeline-view.css
···
190
190
background-color: {$lightblueborder};
191
191
top: 0;
192
192
left: 0;
193
+
text-align: center;
193
194
}
194
195
195
-
.phui-timeline-icon {
196
-
position: absolute;
197
-
left: 9px;
198
-
top: -5px;
196
+
.phui-icon-view.phui-timeline-icon:before {
197
+
position: relative;
198
+
top: 4px;
199
+
margin: 0;
199
200
}
200
201
201
202
.phui-timeline-minor-event .phui-timeline-icon-fill {
202
203
height: 26px;
203
204
width: 26px;
204
205
border-radius: 3px;
205
-
}
206
-
207
-
.phui-timeline-minor-event .phui-timeline-icon {
208
-
top: -5px;
209
-
left: 7px;
210
206
}
211
207
212
208
.phui-timeline-extra,