@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add a discovery format hint for date fields in SearchEngine UIs
Summary:
See PHI316. Maniphest and other applications currently have controls like `Created After: [_____]` where you just get an empty text field.
Although most formats work -- including relative formats like "3 days ago" -- and we validate inputs so you get an error if you enter something nonsensical, this still isn't very user friendly.
T8060 or some other approach is likely the long term of this control.
In the meantime, add placeholder text to suggest that `YYYY-MM-DD` or `X days ago` will work.
Test Plan: Viewed date inputs, saw placeholder text.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18942
+2
-1
+2
-1
src/applications/search/field/PhabricatorSearchDateField.php
+2
-1
src/applications/search/field/PhabricatorSearchDateField.php
···
4
4
extends PhabricatorSearchField {
5
5
6
6
protected function newControl() {
7
-
return new AphrontFormTextControl();
7
+
return id(new AphrontFormTextControl())
8
+
->setPlaceholder(pht('"2022-12-25" or "7 days ago"...'));
8
9
}
9
10
10
11
protected function getValueFromRequest(AphrontRequest $request, $key) {