@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add setup checks for unused homepage options
Summary: Ref T11533, Fixes T5315. Remove and add extra setup checks for removed homepage options.
Test Plan: Review text.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T5315, T11533
Differential Revision: https://secure.phabricator.com/D16453
+16
-26
+16
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+16
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
···
143
143
'phabricator.auth-permanent',
144
144
'phabricator.application-id',
145
145
'phabricator.application-secret',
146
+
'maniphest.priorities.unbreak-now',
147
+
'maniphest.priorities.needs-triage',
148
+
'welcome.html',
146
149
);
147
150
148
151
$ancient_config = array_fill_keys($auth_config, $reason_auth);
···
332
335
'ui.custom-header' => pht(
333
336
'This option has been replaced with `ui.logo`, which provides more '.
334
337
'flexible configuration options.'),
338
+
339
+
'welcome.html' => pht(
340
+
'This option has been removed, you can use Dashboards to provide '.
341
+
'homepage customization. See T11533 for more details.'),
342
+
343
+
'maniphest.priorities.unbreak-now' => pht(
344
+
'This option has been removed, you can use Dashboards to provide '.
345
+
'homepage customization. See T11533 for more details.'),
346
+
347
+
'maniphest.priorities.needs-triage' => pht(
348
+
'This option has been removed, you can use Dashboards to provide '.
349
+
'homepage customization. See T11533 for more details.'),
350
+
335
351
);
336
352
337
353
return $ancient_config;
-4
src/applications/config/option/PhabricatorCoreConfigOptions.php
-4
src/applications/config/option/PhabricatorCoreConfigOptions.php
···
213
213
->setLocked(true)
214
214
->setDescription(
215
215
pht('Customized settings for Phabricator applications.')),
216
-
$this->newOption('welcome.html', 'string', null)
217
-
->setLocked(true)
218
-
->setDescription(
219
-
pht('Custom HTML to show on the main Phabricator dashboard.')),
220
216
$this->newOption('phabricator.cache-namespace', 'string', 'phabricator')
221
217
->setLocked(true)
222
218
->setDescription(pht('Cache namespace.')),
-22
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
-22
src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php
···
356
356
'string',
357
357
'[Maniphest]')
358
358
->setDescription(pht('Subject prefix for Maniphest mail.')),
359
-
$this->newOption(
360
-
'maniphest.priorities.unbreak-now',
361
-
'int',
362
-
100)
363
-
->setSummary(pht('Priority used to populate "Unbreak Now" on home.'))
364
-
->setDescription(
365
-
pht(
366
-
'Temporary setting. If set, this priority is used to populate the '.
367
-
'"Unbreak Now" panel on the home page. You should adjust this if '.
368
-
'you adjust priorities using `%s`.',
369
-
'maniphest.priorities')),
370
-
$this->newOption(
371
-
'maniphest.priorities.needs-triage',
372
-
'int',
373
-
90)
374
-
->setSummary(pht('Priority used to populate "Needs Triage" on home.'))
375
-
->setDescription(
376
-
pht(
377
-
'Temporary setting. If set, this priority is used to populate the '.
378
-
'"Needs Triage" panel on the home page. You should adjust this if '.
379
-
'you adjust priorities using `%s`.',
380
-
'maniphest.priorities')),
381
359
$this->newOption('maniphest.points', $points_type, array())
382
360
->setSummary(pht('Configure point values for tasks.'))
383
361
->setDescription($points_description)