recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make the meme cache case-sensitive

Summary:
Fixes T13172. At one point we always capitalized all the text, and the cache uses capitalized text.

However, we stopped capitalizing the text at some point. Modern memes are more more subtle than old memes, and when we eventualy add support for things like "explodey brain" we'll certainly want to support mixed case.

Practically, this stops you from changing the capitalization of a cached meme. Get rid of the cache transform.

Test Plan:
none lul

(I don't have `gd` installed locally and buiding it requires building libjpeg and libpng or giving up and using `brew`. I'l vet this in production.)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13172

Differential Revision: https://secure.phabricator.com/D19537

epriestley 9e1a1577 682c3bc9

+2 -2
+2 -2
src/applications/macro/engine/PhabricatorMemeEngine.php
··· 104 104 private function newTransformHash() { 105 105 $properties = array( 106 106 'kind' => 'meme', 107 - 'above' => phutil_utf8_strtoupper($this->getAboveText()), 108 - 'below' => phutil_utf8_strtoupper($this->getBelowText()), 107 + 'above' => $this->getAboveText(), 108 + 'below' => $this->getBelowText(), 109 109 ); 110 110 111 111 $properties = phutil_json_encode($properties);