@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up misc Ponder details
Summary: Ref T3578, Changes "Ask Away" to just "Submit", Changes Description to Details, check for is_new when offering closed state on question edit.
Test Plan: New Question, Edit Question
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T3578
Differential Revision: https://secure.phabricator.com/D13891
+18
-9
+14
-8
src/applications/ponder/controller/PonderQuestionEditController.php
+14
-8
src/applications/ponder/controller/PonderQuestionEditController.php
···
23
23
$question->getPHID(),
24
24
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
25
25
$v_projects = array_reverse($v_projects);
26
+
$is_new = false;
26
27
} else {
28
+
$is_new = true;
27
29
$question = PonderQuestion::initializeNewQuestion($viewer);
28
30
$v_projects = array();
29
31
}
···
124
126
->setSpacePHID($v_space)
125
127
->setPolicies($policies)
126
128
->setValue($v_view)
127
-
->setCapability(PhabricatorPolicyCapability::CAN_VIEW))
128
-
->appendChild(
129
-
id(new AphrontFormSelectControl())
130
-
->setLabel(pht('Status'))
131
-
->setName('status')
132
-
->setValue($v_status)
133
-
->setOptions(PonderQuestionStatus::getQuestionStatusMap()));
129
+
->setCapability(PhabricatorPolicyCapability::CAN_VIEW));
130
+
131
+
132
+
if (!$is_new) {
133
+
$form->appendChild(
134
+
id(new AphrontFormSelectControl())
135
+
->setLabel(pht('Status'))
136
+
->setName('status')
137
+
->setValue($v_status)
138
+
->setOptions(PonderQuestionStatus::getQuestionStatusMap()));
139
+
}
134
140
135
141
$form->appendControl(
136
142
id(new AphrontFormTokenizerControl())
···
142
148
$form->appendChild(
143
149
id(new AphrontFormSubmitControl())
144
150
->addCancelButton($this->getApplicationURI())
145
-
->setValue(pht('Ask Away!')));
151
+
->setValue(pht('Submit')));
146
152
147
153
$preview = id(new PHUIRemarkupPreviewPanel())
148
154
->setHeader(pht('Question Preview'))
+4
-1
src/applications/ponder/controller/PonderQuestionViewController.php
+4
-1
src/applications/ponder/controller/PonderQuestionViewController.php