@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hack-patch for missing highlights in Audit
Summary: When I swapped the views, I accidentally removed some controller -> view -> controller logic which is used to figure out which packages are highlighted. This code is a mess, but fix the feature for now and we can clean it up later.
Test Plan: {F56335}
Reviewers: wez, btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D6835
+12
-2
+12
-2
src/applications/diffusion/controller/DiffusionCommitController.php
+12
-2
src/applications/diffusion/controller/DiffusionCommitController.php
···
140
140
141
141
$content[] = $this->buildMergesTable($commit);
142
142
143
+
// TODO: This is silly, but the logic to figure out which audits are
144
+
// highlighted currently lives in PhabricatorAuditListView. Refactor this
145
+
// to be less goofy.
146
+
$highlighted_audits = id(new PhabricatorAuditListView())
147
+
->setAudits($audit_requests)
148
+
->setAuthorityPHIDs($this->auditAuthorityPHIDs)
149
+
->setUser($user)
150
+
->setCommits(array($commit->getPHID() => $commit))
151
+
->getHighlightedAudits();
152
+
143
153
$owners_paths = array();
144
-
if ($this->highlightedAudits) {
154
+
if ($highlighted_audits) {
145
155
$packages = id(new PhabricatorOwnersPackage())->loadAllWhere(
146
156
'phid IN (%Ls)',
147
-
mpull($this->highlightedAudits, 'getAuditorPHID'));
157
+
mpull($highlighted_audits, 'getAuditorPHID'));
148
158
if ($packages) {
149
159
$owners_paths = id(new PhabricatorOwnersPath())->loadAllWhere(
150
160
'repositoryPHID = %s AND packageID IN (%Ld)',