recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a fatal in Calendar widget in Conpherence

Summary:
Fixes T8548. This needs to be cleaned up more generally at some point, but stop the bleeding for now.

If a thread member is invited to an event with a non-thread-member host, we try to render the host but don't have their handle (this is a holdover from the bygone days of events as statuses).

For now, just don't render anything. In the future, it might be nice to render (some of?) the attendees who are thread members, but I suspect we may revisit this widget more generally.

Test Plan:
- As a non thread-member, created an event and invited a thread member.
- Viewed thread as thread-member.
- Saw widget fatal.
- Applied patch.
- As thread-member, saw widget render with just "9AM-10AM", instead of "host, 9AM-10AM".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8548

Differential Revision: https://secure.phabricator.com/D13299

epriestley 9f1235d8 6aa494bd

+8 -2
+8 -2
src/applications/conpherence/controller/ConpherenceWidgetController.php
··· 310 310 $user, 311 311 $time_str); 312 312 313 - $secondary_info = pht('%s, %s', 314 - $handles[$status->getUserPHID()]->getName(), $epoch_range); 313 + if (isset($handles[$status->getUserPHID()])) { 314 + $secondary_info = pht( 315 + '%s, %s', 316 + $handles[$status->getUserPHID()]->getName(), 317 + $epoch_range); 318 + } else { 319 + $secondary_info = $epoch_range; 320 + } 315 321 316 322 $content[] = phutil_tag( 317 323 'div',