@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix visibility of some `LiskDAO` methods
Summary: Ref T6822.
Test Plan: Ran unit tests.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Maniphest Tasks: T6822
Differential Revision: https://secure.phabricator.com/D11410
+5
-3
+3
-1
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
+3
-1
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
···
45
45
$dao = new LiskIsolationTestDAO();
46
46
47
47
try {
48
-
$dao->establishLiveConnection('r');
48
+
$method = new ReflectionMethod($dao, 'establishLiveConnection');
49
+
$method->setAccessible(true);
50
+
$method->invoke($dao, 'r');
49
51
50
52
$this->assertFailure(
51
53
'LiskIsolationTestDAO did not throw an exception when instructed to '.
+2
-2
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
+2
-2
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php
···
15
15
return PhabricatorPHID::generateNewPHID('TISO');
16
16
}
17
17
18
-
public function establishLiveConnection($mode) {
18
+
protected function establishLiveConnection($mode) {
19
19
throw new LiskIsolationTestDAOException(
20
20
'Isolation failure! DAO is attempting to connect to an external '.
21
21
'resource!');
22
22
}
23
23
24
-
public function getConnectionNamespace() {
24
+
protected function getConnectionNamespace() {
25
25
return 'test';
26
26
}
27
27