@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up feedback from D11340
Summary: Ref D11340, I missed the comments being to excited to land.
Test Plan: Shrink window to mobile view, click on action menu.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11347
+6
-31
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '2b129813',
10
+
'core.pkg.css' => 'b99369cc',
11
11
'core.pkg.js' => '61af8961',
12
12
'darkconsole.pkg.js' => '8ab24e01',
13
13
'differential.pkg.css' => '8af45893',
···
130
130
'rsrc/css/phui/phui-fontkit.css' => '9c3d2dce',
131
131
'rsrc/css/phui/phui-form-view.css' => 'aad06f2a',
132
132
'rsrc/css/phui/phui-form.css' => '9aecbda1',
133
-
'rsrc/css/phui/phui-header-view.css' => '0873d56f',
133
+
'rsrc/css/phui/phui-header-view.css' => 'c936b5b9',
134
134
'rsrc/css/phui/phui-icon.css' => 'a013a63d',
135
135
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
136
136
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
···
774
774
'phui-fontkit-css' => '9c3d2dce',
775
775
'phui-form-css' => '9aecbda1',
776
776
'phui-form-view-css' => 'aad06f2a',
777
-
'phui-header-view-css' => '0873d56f',
777
+
'phui-header-view-css' => 'c936b5b9',
778
778
'phui-icon-view-css' => 'a013a63d',
779
779
'phui-image-mask-css' => '5a8b09c8',
780
780
'phui-info-panel-css' => '27ea50a1',
-21
src/view/phui/PHUIButtonView.php
-21
src/view/phui/PHUIButtonView.php
···
22
22
private $title = null;
23
23
private $disabled;
24
24
private $name;
25
-
private $id;
26
-
private $sigil;
27
-
private $meta;
28
25
29
26
public function setName($name) {
30
27
$this->name = $name;
···
85
82
return $this;
86
83
}
87
84
88
-
public function setID($id) {
89
-
$this->id = $id;
90
-
return $this;
91
-
}
92
-
93
-
public function setSigil($sigil) {
94
-
$this->sigil = $sigil;
95
-
return $this;
96
-
}
97
-
98
-
public function setMeta($meta) {
99
-
$this->meta = $meta;
100
-
return $this;
101
-
}
102
-
103
85
public function getTagName() {
104
86
return $this->tag;
105
87
}
···
136
118
'href' => $this->href,
137
119
'name' => $this->name,
138
120
'title' => $this->title,
139
-
'id' => $this->id,
140
-
'sigil' => $this->sigil,
141
-
'meta' => $this->meta,
142
121
);
143
122
}
144
123
+3
-3
src/view/phui/PHUIObjectBoxView.php
+3
-3
src/view/phui/PHUIObjectBoxView.php
···
170
170
$meta = array(
171
171
'map' => array(
172
172
$this->actionListID => 'phabricator-action-list-toggle',
173
-
$icon_id => 'phui-mobile-action-menu-open',
173
+
$icon_id => 'phuix-dropdown-open',
174
174
),);
175
175
$mobile_menu = id(new PHUIButtonView())
176
176
->setTag('a')
···
179
179
->setIcon($icon)
180
180
->addClass('phui-mobile-menu')
181
181
->setID($icon_id)
182
-
->setSigil('jx-toggle-class')
183
-
->setMeta($meta);
182
+
->addSigil('jx-toggle-class')
183
+
->setMetadata($meta);
184
184
$header->addActionLink($mobile_menu);
185
185
}
186
186