recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove unusual unicode marks in Differential action dropdown

Summary:
See <https://twitter.com/HayleyCAnderson/status/988873585363009536>.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan:
- Viewed these actions in the dropdown, no longer saw the mark icons.
- Grepped for these unicode sequences without getting any other hits.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19405

epriestley 9f8e0ad4 b4796d28

+2 -2
+1 -1
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
··· 7 7 const ACTIONKEY = 'accept'; 8 8 9 9 protected function getRevisionActionLabel() { 10 - return pht("Accept Revision \xE2\x9C\x94"); 10 + return pht('Accept Revision'); 11 11 } 12 12 13 13 protected function getRevisionActionDescription(
+1 -1
src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
··· 7 7 const ACTIONKEY = 'reject'; 8 8 9 9 protected function getRevisionActionLabel() { 10 - return pht("Request Changes \xE2\x9C\x98"); 10 + return pht('Request Changes'); 11 11 } 12 12 13 13 protected function getRevisionActionDescription(