recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove call to undefined method DoorkeeperDAO::getObjectKey()

Summary: Remove call to undefined static method `DoorKeeperDAO::getObjectKey()` in the `DoorkeeperExternalObject` class. `getObjectKey()` does not exist (and never existed) in any of its parent classes (`DoorkeeperDAO`, `PhabricatorLiskDAO`, `LiskDAO`).

Test Plan: Run static code analysis. Grep the source code and check the git history of parent classes.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25734

Andre Klapper a039c495 0873b365

+1 -5
+1 -5
src/applications/doorkeeper/storage/DoorkeeperExternalObject.php
··· 60 60 } 61 61 62 62 public function getObjectKey() { 63 - $key = parent::getObjectKey(); 64 - if ($key === null) { 65 - $key = $this->getRef()->getObjectKey(); 66 - } 67 - return $key; 63 + return $this->getRef()->getObjectKey(); 68 64 } 69 65 70 66 public function getRef() {