@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where "Send an email to..." rules might be discarded
Summary: Fixes T8464. We could lose the additional users from "Send an email..." rules //if// Herald did not apply any other transactions to the task.
Test Plan:
- Destroyed all Herald rules.
- Created a single "Send an email to..." rule.
- Created a task.
- Saw target get an email.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T8464
Differential Revision: https://secure.phabricator.com/D13245
+6
-4
+6
-4
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+6
-4
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
936
936
$object,
937
937
$herald_xactions);
938
938
939
-
$adapter = $this->getHeraldAdapter();
940
-
$this->heraldEmailPHIDs = $adapter->getEmailPHIDs();
941
-
$this->heraldForcedEmailPHIDs = $adapter->getForcedEmailPHIDs();
942
-
943
939
// Merge the new transactions into the transaction list: we want to
944
940
// send email and publish feed stories about them, too.
945
941
$xactions = array_merge($xactions, $herald_xactions);
946
942
}
943
+
944
+
// If Herald did not generate transactions, we may still need to handle
945
+
// "Send an Email" rules.
946
+
$adapter = $this->getHeraldAdapter();
947
+
$this->heraldEmailPHIDs = $adapter->getEmailPHIDs();
948
+
$this->heraldForcedEmailPHIDs = $adapter->getForcedEmailPHIDs();
947
949
}
948
950
949
951
$this->didApplyTransactions($xactions);