@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct DOM node metadata to let inline comments work against block-based diffs
Summary: Depends on D20833. Ref T13425. This look like it "just works"?
Test Plan: Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.
Maniphest Tasks: T13425
Differential Revision: https://secure.phabricator.com/D20834
+4
-8
+4
-8
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+4
-8
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
···
420
420
421
421
if ($old_content === null) {
422
422
$old_id = null;
423
-
$old_label = null;
424
423
} else {
425
424
$old_id = "C{$old_changeset_key}OL{$old_key}";
426
-
$old_label = $old_key;
427
425
}
428
426
429
427
$old_line_cell = phutil_tag(
430
428
'td',
431
429
array(
432
430
'id' => $old_id,
431
+
'data-n' => $old_key,
433
432
'class' => 'n',
434
-
),
435
-
$old_label);
433
+
));
436
434
437
435
$old_content_cell = phutil_tag(
438
436
'td',
···
443
441
444
442
if ($new_content === null) {
445
443
$new_id = null;
446
-
$new_label = null;
447
444
} else {
448
445
$new_id = "C{$new_changeset_key}NL{$new_key}";
449
-
$new_label = $new_key;
450
446
}
451
447
452
448
$new_line_cell = phutil_tag(
453
449
'td',
454
450
array(
455
451
'id' => $new_id,
452
+
'data-n' => $new_key,
456
453
'class' => 'n',
457
-
),
458
-
$new_label);
454
+
));
459
455
460
456
$new_content_cell = phutil_tag(
461
457
'td',