@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Declare that revision was closed by committer, not author
Summary: D2703#13 is confusing - it looks like that @allenjohnashton took the action but it was @epriestley.
Test Plan: I don't have a repro so I tested this block standalone.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2707
+8
-2
+8
-2
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
+8
-2
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
···
98
98
$commit_is_new = $conn_w->getAffectedRows();
99
99
100
100
$message = null;
101
-
$committer = $data->getCommitDetail('authorPHID');
101
+
$name = $data->getCommitDetail('committer');
102
+
if ($name !== null) {
103
+
$committer = $data->getCommitDetail('committerPHID');
104
+
} else {
105
+
$committer = $data->getCommitDetail('authorPHID');
106
+
$name = $data->getAuthorName();
107
+
}
102
108
if (!$committer) {
103
109
$committer = $revision->getAuthorPHID();
104
-
$message = 'Closed by '.$data->getAuthorName().'.';
110
+
$message = 'Closed by '.$name.'.';
105
111
}
106
112
107
113
if ($commit_is_new) {