@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide a separate error code for invalid Conduit calls
Summary: I plan to use this in Arcanist.
Test Plan:
$ echo '{}' | arc call-conduit x
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4192
+5
-3
+2
-2
src/applications/conduit/call/ConduitCall.php
+2
-2
src/applications/conduit/call/ConduitCall.php
···
70
70
// Discard, we provide a more specific exception below.
71
71
}
72
72
if (!$ok) {
73
-
throw new Exception(
73
+
throw new ConduitException(
74
74
"Conduit method '{$method}' does not exist.");
75
75
}
76
76
77
77
$class_info = new ReflectionClass($method_class);
78
78
if ($class_info->isAbstract()) {
79
-
throw new Exception(
79
+
throw new ConduitException(
80
80
"Method '{$method}' is not valid; the implementation is an abstract ".
81
81
"base class.");
82
82
}
+3
-1
src/applications/conduit/controller/PhabricatorConduitAPIController.php
+3
-1
src/applications/conduit/controller/PhabricatorConduitAPIController.php