recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 auth view strlen(null) error

Summary:
Trying to view a Jira auth provider from https://my.phorge.site/auth/ results in strlen(): Passing null to parameter #1 ($string) of type string is deprecated

This change fixes it

Fixes T15634

Test Plan:
Go to https://my.phorge.site/auth/ and have a Jira already setup.
Click on Jira auth provider
Confirm the page is displayed and no error is generated.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15634

Differential Revision: https://we.phorge.it/D25432

sten a0fb344b a65061dd

+1 -1
+1 -1
src/applications/auth/storage/PhabricatorAuthProviderConfigTransaction.php
··· 150 150 $provider = $this->getProvider(); 151 151 if ($provider) { 152 152 $title = $provider->renderConfigPropertyTransactionTitle($this); 153 - if (strlen($title)) { 153 + if (phutil_nonempty_string($title)) { 154 154 return $title; 155 155 } 156 156 }