@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Sort Spaces dropdown by name, not "alphabetical ID"
Summary:
Fixes T10414. I think this sorted by name at one time (the `asort()`) but then I probably added "Space SX" in front of it. Or I just got this wrong from the beginning.
Instead, sort by space name.
Test Plan: {F1126034}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10414
Differential Revision: https://secure.phabricator.com/D15334
+1
-1
+1
-1
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
+1
-1
src/applications/spaces/query/PhabricatorSpacesNamespaceQuery.php
···
184
184
$space_phid) {
185
185
186
186
$viewer_spaces = self::getViewerSpaces($viewer);
187
+
$viewer_spaces = msort($viewer_spaces, 'getNamespaceName');
187
188
188
189
$map = array();
189
190
foreach ($viewer_spaces as $space) {
···
200
201
$space->getMonogram(),
201
202
$space->getNamespaceName());
202
203
}
203
-
asort($map);
204
204
205
205
return $map;
206
206
}