@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Autocomplete: minor refactor
Summary:
Do the same in less code.
Implement this small tip:
https://we.phorge.it/D26681#43044
Ref T16334
Test Plan:
Same test plan as D26681.
Share a comment in Maniphest Task pinging somebody. Still works.
Do the same with somebody subscribed. Still works and the subscribed has priority.
Share a comment in Differential Diff (which does not support this feature) pinging somebody.
Still works.
Reviewers: O1 Blessed Committers, aklapper
Reviewed By: O1 Blessed Committers, aklapper
Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T16334
Differential Revision: https://we.phorge.it/D26705
+12
-12
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => 'b2d6f4b8',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => '8755ddc1',
13
-
'core.pkg.js' => '3b8563ac',
13
+
'core.pkg.js' => '83c66b30',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => 'abdb4fe9',
16
16
'differential.pkg.js' => '46fcb3af',
···
456
456
'rsrc/js/phui/behavior-phui-timer-control.js' => 'f84bcbf4',
457
457
'rsrc/js/phuix/PHUIXActionListView.js' => 'c68f183f',
458
458
'rsrc/js/phuix/PHUIXActionView.js' => 'a8f573a9',
459
-
'rsrc/js/phuix/PHUIXAutocomplete.js' => '7477f763',
459
+
'rsrc/js/phuix/PHUIXAutocomplete.js' => 'cf26eaab',
460
460
'rsrc/js/phuix/PHUIXButtonView.js' => '55a24e84',
461
461
'rsrc/js/phuix/PHUIXDropdownMenu.js' => 'b557770a',
462
462
'rsrc/js/phuix/PHUIXExample.js' => 'c2c500a7',
···
816
816
'phui-workpanel-view-css' => 'c44f95c7',
817
817
'phuix-action-list-view' => 'c68f183f',
818
818
'phuix-action-view' => 'a8f573a9',
819
-
'phuix-autocomplete' => '7477f763',
819
+
'phuix-autocomplete' => 'cf26eaab',
820
820
'phuix-button-view' => '55a24e84',
821
821
'phuix-dropdown-menu' => 'b557770a',
822
822
'phuix-form-control-view' => '38c1f3fb',
···
1507
1507
'phabricator-drag-and-drop-file-upload',
1508
1508
'javelin-workboard-board',
1509
1509
),
1510
-
'7477f763' => array(
1511
-
'javelin-install',
1512
-
'javelin-dom',
1513
-
'phuix-icon-view',
1514
-
'phabricator-prefab',
1515
-
),
1516
1510
'78bc5d94' => array(
1517
1511
'javelin-behavior',
1518
1512
'javelin-uri',
···
1985
1979
'javelin-dom',
1986
1980
'phuix-formation-column-view',
1987
1981
'phuix-formation-flank-view',
1982
+
),
1983
+
'cf26eaab' => array(
1984
+
'javelin-install',
1985
+
'javelin-dom',
1986
+
'phuix-icon-view',
1987
+
'phabricator-prefab',
1988
1988
),
1989
1989
'd12d214f' => array(
1990
1990
'javelin-install',
+3
-3
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
+3
-3
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
···
157
157
JX.bind(this, this._onresults, code));
158
158
159
159
datasource.setTransformer(JX.bind(this, this._transformresult));
160
-
// List users first who are involved in the object
161
-
var involvedUsers = 'involvedUsers' in spec ? spec.involvedUsers : null;
162
-
if (involvedUsers !== null && involvedUsers.length !== 0) {
160
+
// List users first who are involved in the object.
161
+
var involvedUsers = spec.involvedUsers;
162
+
if (involvedUsers && involvedUsers.length !== 0) {
163
163
datasource.setSortHandler(function(value, list) {
164
164
list.sort(function(u,v){
165
165
var usort = involvedUsers.includes(u.id) ? 0 : 1;