@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't link files with no rendering changeset in DiffusionCommitChangeTableView
Summary:
When directories are added (e.g., on the `hg` initial commit, "/" is added) we don't render any diff for them but try to link to it in the table of contents.
Possibly we should render a diff saying "this directory was added", but stop it from complaining for now.
Test Plan: Looked at several hg and git commits which add directories to verify this gives us generally sensible behvior.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D3663
+14
-10
+14
-10
src/applications/diffusion/view/DiffusionCommitChangeTableView.php
+14
-10
src/applications/diffusion/view/DiffusionCommitChangeTableView.php
···
54
54
$path .= '/';
55
55
}
56
56
57
-
$path_column = javelin_render_tag(
58
-
'a',
59
-
array(
60
-
'href' => '#'.$hash,
61
-
'meta' => array(
62
-
'id' => 'diff-'.$hash,
63
-
'ref' => $this->renderingReferences[$id],
57
+
if (isset($this->renderingReferences[$id])) {
58
+
$path_column = javelin_render_tag(
59
+
'a',
60
+
array(
61
+
'href' => '#'.$hash,
62
+
'meta' => array(
63
+
'id' => 'diff-'.$hash,
64
+
'ref' => $this->renderingReferences[$id],
65
+
),
66
+
'sigil' => 'differential-load',
64
67
),
65
-
'sigil' => 'differential-load',
66
-
),
67
-
phutil_escape_html($path));
68
+
phutil_escape_html($path));
69
+
} else {
70
+
$path_column = phutil_escape_html($path);
71
+
}
68
72
69
73
$rows[] = array(
70
74
$this->linkHistory($change->getPath()),