+2 -1

src/aphront/AphrontRequest.php

reviewed

··· 846 846 * This is not a general-purpose proxying method; it is a specialized 847 847 * method with niche applications and severe security implications. 848 848 * 849 849 - * @param string URI $uri identifying the host we are proxying the request to. 849 849 + * @param string $uri URI identifying the host we are proxying the request 850 850 + * to. 850 851 * @return HTTPSFuture New proxy future. 851 852 * 852 853 * @phutil-external-symbol class PhabricatorStartup

+1 -1

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

reviewed

··· 920 920 * which users have been locked out of. 921 921 * 922 922 * @param PhabricatorUser $user User to generate a URI for. 923 923 - * @param PhabricatorUserEmail? $email Optionally, email to verify when 923 923 + * @param PhabricatorUserEmail|null $email Optionally, email to verify when 924 924 * link is used. 925 925 * @param string $type (optional) Context string for the URI. This is purely 926 926 * cosmetic and used only to customize workflow and error messages.

+1 -1

src/applications/differential/parser/DifferentialChangesetParser.php

reviewed

··· 1193 1193 * "show more"). The $mask returned is a sparsely populated dictionary 1194 1194 * of $visible_line_number => true. 1195 1195 * 1196 1196 - * @return array($gaps, $mask) 1196 1196 + * @return array Array of <$gaps, $mask> 1197 1197 */ 1198 1198 private function calculateGapsAndMask( 1199 1199 $mask_force,

+4 -3

src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php

reviewed

··· 247 247 248 248 /** 249 249 * @param PhabricatorChartDataQuery $data_query 250 250 - * @param array<string<epoch<string:int,string:int>>> $point_lists The key is 251 251 - * the stack (the PhabricatorChartFunctionLabel name of the 250 250 + * @param array<string<int<array<string,int>,array<string,int>>>> $point_lists 251 251 + * The key is the stack (the PhabricatorChartFunctionLabel name of the 252 252 * PhabricatorChartFunction (e.g. "created" or "moved-in")) and its value 253 253 * is an array of keys which are date epochs and their values are another 254 254 - * array of x:date epoch and y:incremental integer pairs. 254 254 + * array of x:date epoch and y:incremental integer pairs: 255 255 + * array <string<epoch<string:int,string:int>>> 255 256 */ 256 257 private function getGeometry( 257 258 PhabricatorChartDataQuery $data_query,

+2 -1

src/applications/maniphest/controller/ManiphestReportController.php

reviewed

··· 528 528 * - a possible error. 529 529 * This is used for the "Recently Closed" column on /maniphest/report/*. 530 530 * 531 531 - * @return array<string,integer,string|null> "Recently Means" user input; 531 531 + * @return array Array with three items: "Recently Means" user input; 532 532 * Resulting epoch timeframe used to get "Recently Closed" numbers 533 533 * (when user input is invalid, it defaults to a week ago); "Invalid" 534 534 * if first parameter could not be parsed as an epoch, else null. 535 535 + * array<string,integer,string|null> 535 536 */ 536 537 private function getWindow() { 537 538 $request = $this->getRequest();

+1 -1

src/applications/maniphest/controller/ManiphestTaskDetailController.php

reviewed

··· 268 268 * Add Open Graph Protocol metadata tags to Maniphest task page 269 269 * @param PhabricatorStandardPageView $page 270 270 * @param ManiphestTask $task 271 271 - * @return $page with additional OGP <meta> tags 271 271 + * @return PhabricatorStandardPageView with additional OGP <meta> tags 272 272 */ 273 273 private function addOpenGraphProtocolMetadataTags($page, $task) { 274 274 foreach ($this->getOpenGraphProtocolMetadataValues($task) as $k => $v) {

+2 -1

src/applications/oauthserver/PhabricatorOAuthServer.php

reviewed

··· 59 59 60 60 /** 61 61 * @task auth 62 62 - * @return tuple <bool hasAuthorized, ClientAuthorization or null> 62 62 + * @return array<bool,PhabricatorOAuthClientAuthorization|null> Tuple of 63 63 + * <bool hasAuthorized, ClientAuthorization or null> 63 64 */ 64 65 public function userHasAuthorizedClient(array $scope) { 65 66

+1 -1

src/applications/people/query/PhabricatorPeopleUserEmailQuery.php

reviewed

··· 20 20 21 21 /** 22 22 * With the specified User PHIDs. 23 23 - * @param null|array $phids User PHIDs 23 23 + * @param array<string|null> $phids User PHIDs 24 24 */ 25 25 public function withUserPHIDs(array $phids) { 26 26 $this->userPhids = $phids;

+2 -1

src/applications/project/chart/PhabricatorProjectBurndownChartEngine.php

reviewed

··· 103 103 /** 104 104 * @param string $fact_key The key of the new fact sum 105 105 * (e.g. "tasks.open-count.assign.project") 106 106 - * @param array<string> Project PHIDs 106 106 + * @param array<string> $phids Project PHIDs 107 107 + * @return array 107 108 */ 108 109 private function newFactSum($fact_key, array $phids) { 109 110 $result = array();

+1 -1

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

reviewed

··· 1645 1645 * Load from object and from storage, and updates Custom Fields instances 1646 1646 * that are attached to each object. 1647 1647 * 1648 1648 - * @return map<phid->PhabricatorCustomFieldList> of loaded fields. 1648 1648 + * @return map Map of of loaded fields (PHID to PhabricatorCustomFieldList). 1649 1649 * @task custom 1650 1650 */ 1651 1651 protected function loadCustomFields(array $objects, $role) {

+1 -1

src/infrastructure/diff/PhabricatorDifferenceEngine.php

reviewed

··· 134 134 * 135 135 * @param string $old Entire previous file content. 136 136 * @param string $new Entire current file content. 137 137 - * @return @{class:DifferentialChangeset} Synthetic changeset. 137 137 + * @return DifferentialChangeset Synthetic changeset. 138 138 * @task diff 139 139 */ 140 140 public function generateChangesetFromFileContent($old, $new) {