@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix bad aspect ratio on some file previews
Summary: Ref T7707. Fixes T4724. I misread the report on T4724; this is trivial. We're just reading the wrong properties in setting "width" and "height" attributes, the actual thumbnailing logic is fine.
Test Plan: Uploaded image from T4724, saw it have a proper aspect ratio.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: spicyj, epriestley
Maniphest Tasks: T4724, T7707
Differential Revision: https://secure.phabricator.com/D12810
+2
-2
+2
-2
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
+2
-2
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
···
110
110
$attrs['src'] = $file->getPreview220URI();
111
111
$dimensions =
112
112
PhabricatorImageTransformer::getPreviewDimensions($file, 220);
113
-
$attrs['width'] = $dimensions['sdx'];
114
-
$attrs['height'] = $dimensions['sdy'];
113
+
$attrs['width'] = $dimensions['dx'];
114
+
$attrs['height'] = $dimensions['dy'];
115
115
$image_class = 'phabricator-remarkup-embed-image';
116
116
break;
117
117
}