@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When viewing a workboard, only link to parent workboards in crumbs if parents have workboards
Summary:
Depends on D20516. See PHI1247. In D20331, I made the crumbs on workboards point at ancestor workboards.
However, this isn't a great destination if an ancestor doesn't actually have a workboard. In this case, point at the normal profile URI instead.
Test Plan:
- Viewed a milestone workboard with a parent that had no workboard. Saw a profile link instead of a workboard link (new behavior).
- Viewed a milestone workboard with a parent that also had a workboard. Saw a workboard link (existing old behavior still works).
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20517
+5
-1
+5
-1
src/applications/project/controller/PhabricatorProjectController.php
+5
-1
src/applications/project/controller/PhabricatorProjectController.php
···
109
109
} else {
110
110
switch ($mode) {
111
111
case 'workboard':
112
-
$crumb_uri = $ancestor->getWorkboardURI();
112
+
if ($ancestor->getHasWorkboard()) {
113
+
$crumb_uri = $ancestor->getWorkboardURI();
114
+
} else {
115
+
$crumb_uri = $ancestor->getProfileURI();
116
+
}
113
117
break;
114
118
case 'profile':
115
119
default: