recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a missing viewer after D5152

I think this one got mucked up in a merge or I didn't grep properly.

Auditors: vrana

epriestley a20ba85b 8ae718c2

+4 -3
+2 -1
src/applications/config/storage/PhabricatorConfigTransaction.php
··· 78 78 return parent::hasChangeDetails(); 79 79 } 80 80 81 - public function renderChangeDetails() { 81 + public function renderChangeDetails(PhabricatorUser $viewer) { 82 82 $old = $this->getOldValue(); 83 83 $new = $this->getNewValue(); 84 84 ··· 97 97 } 98 98 99 99 $view = id(new PhabricatorApplicationTransactionTextDiffDetailView()) 100 + ->setUser($viewer) 100 101 ->setOldText($old_text) 101 102 ->setNewText($new_text); 102 103
+1 -1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
··· 325 325 return false; 326 326 } 327 327 328 - public function renderChangeDetails() { 328 + public function renderChangeDetails(PhabricatorUser $viewer) { 329 329 return null; 330 330 } 331 331
+1 -1
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
··· 206 206 'style' => 'display: none', 207 207 'class' => 'phabricator-timeline-change-details', 208 208 ), 209 - $xaction->renderChangeDetails()); 209 + $xaction->renderChangeDetails($this->getUser())); 210 210 211 211 return array( 212 212 $show_more,