@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix off by one bug in calendar data fetching
Summary: Ref T3155. "last sunday" is "last sunday at 00:00" so you have to include a day for Sunday itself.
Test Plan: calendar renders correctly today - saturday - which is the edge case of this
Reviewers: epriestley, chad
Reviewed By: chad
CC: aran, Korvin
Maniphest Tasks: T3155
Differential Revision: https://secure.phabricator.com/D6108
+2
-2
+1
-1
src/applications/conpherence/controller/ConpherenceWidgetController.php
+1
-1
src/applications/conpherence/controller/ConpherenceWidgetController.php
···
385
385
386
386
$first_day = new DateTime('last sunday', $timezone);
387
387
$timestamps = array();
388
-
for ($day = 0; $day < 8; $day++) {
388
+
for ($day = 0; $day < 9; $day++) {
389
389
$timestamp = clone $first_day;
390
390
$timestamps[] = $timestamp->modify(sprintf('+%d days', $day));
391
391
}
+1
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
+1
-1
src/applications/conpherence/query/ConpherenceThreadQuery.php
···
225
225
$this->getViewer(),
226
226
'U');
227
227
$end_epoch = phabricator_format_local_time(
228
-
strtotime('last sunday +8 days', strtotime('tomorrow')),
228
+
strtotime('last sunday +9 days', strtotime('tomorrow')),
229
229
$this->getViewer(),
230
230
'U');
231
231
$statuses = id(new PhabricatorUserStatus())