recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove obsolete/deprecated withTaskIDs() / withTaskPHIDs()

Summary: Ref T603. These were deprecated some time ago in favor of the more standard withIDs() / withPHIDs().

Test Plan: `grep`, loaded some interfaces.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D6929

epriestley a2571de5 e625c918

+6 -18
+1 -1
src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php
··· 228 228 229 229 $tasks = id(new ManiphestTaskQuery()) 230 230 ->setViewer($user) 231 - ->withTaskIDs(array_keys($tasks_statuses)) 231 + ->withIDs(array_keys($tasks_statuses)) 232 232 ->execute(); 233 233 234 234 foreach ($tasks as $task_id => $task) {
-12
src/applications/maniphest/ManiphestTaskQuery.php
··· 85 85 return $this; 86 86 } 87 87 88 - // TODO: Deprecated in favor of `withIDs()`. 89 - public function withTaskIDs(array $ids) { 90 - $this->taskIDs = $ids; 91 - return $this; 92 - } 93 - 94 - // TODO: Deprecated in favor of `withPHIDs()`. 95 - public function withTaskPHIDs(array $phids) { 96 - $this->taskPHIDs = $phids; 97 - return $this; 98 - } 99 - 100 88 public function withOwners(array $owners) { 101 89 $this->includeUnowned = false; 102 90 foreach ($owners as $k => $phid) {
+2 -2
src/applications/maniphest/conduit/ConduitAPI_maniphest_query_Method.php
··· 69 69 70 70 $task_ids = $request->getValue('ids'); 71 71 if ($task_ids) { 72 - $query->withTaskIDs($task_ids); 72 + $query->withIDs($task_ids); 73 73 } 74 74 75 75 $task_phids = $request->getValue('phids'); 76 76 if ($task_phids) { 77 - $query->withTaskPHIDs($task_phids); 77 + $query->withPHIDs($task_phids); 78 78 } 79 79 80 80 $owners = $request->getValue('ownerPHIDs');
+1 -1
src/applications/maniphest/controller/ManiphestTaskListController.php
··· 460 460 461 461 $query = new ManiphestTaskQuery(); 462 462 $query->setViewer($viewer); 463 - $query->withTaskIDs($task_ids); 463 + $query->withIDs($task_ids); 464 464 465 465 if ($project_phids) { 466 466 $query->withAllProjects($project_phids);
+1 -1
src/applications/maniphest/mail/ManiphestTaskMailReceiver.php
··· 16 16 17 17 $results = id(new ManiphestTaskQuery()) 18 18 ->setViewer($viewer) 19 - ->withTaskIDs(array($id)) 19 + ->withIDs(array($id)) 20 20 ->execute(); 21 21 22 22 return head($results);
+1 -1
src/applications/maniphest/remarkup/ManiphestRemarkupRule.php
··· 15 15 16 16 return id(new ManiphestTaskQuery()) 17 17 ->setViewer($viewer) 18 - ->withTaskIDs($ids) 18 + ->withIDs($ids) 19 19 ->execute(); 20 20 } 21 21