@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When pagers aren't connected to an ObjectItemListView, put them in a little box
Summary: Pagers in Maniphest (and, to some degree, apps like Pholio) get lost a bit. Put them in a little box.
Test Plan: Looked at Maniphest and Pholio, pager was more obvious and less un-designed-looking.
Reviewers: chad, btrahan
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6987
+63
-45
+44
-44
src/__celerity_resource_map__.php
+44
-44
src/__celerity_resource_map__.php
···
881
881
),
882
882
'aphront-pager-view-css' =>
883
883
array(
884
-
'uri' => '/res/43fb79f0/rsrc/css/aphront/pager-view.css',
884
+
'uri' => '/res/ea81aec0/rsrc/css/aphront/pager-view.css',
885
885
'type' => 'css',
886
886
'requires' =>
887
887
array(
···
4171
4171
), array(
4172
4172
'packages' =>
4173
4173
array(
4174
-
'1200d176' =>
4174
+
'606d1ed1' =>
4175
4175
array(
4176
4176
'name' => 'core.pkg.css',
4177
4177
'symbols' =>
···
4218
4218
39 => 'phabricator-property-list-view-css',
4219
4219
40 => 'phabricator-tag-view-css',
4220
4220
),
4221
-
'uri' => '/res/pkg/1200d176/core.pkg.css',
4221
+
'uri' => '/res/pkg/606d1ed1/core.pkg.css',
4222
4222
'type' => 'css',
4223
4223
),
4224
4224
'8977e356' =>
···
4409
4409
),
4410
4410
'reverse' =>
4411
4411
array(
4412
-
'aphront-dialog-view-css' => '1200d176',
4413
-
'aphront-error-view-css' => '1200d176',
4414
-
'aphront-list-filter-view-css' => '1200d176',
4415
-
'aphront-pager-view-css' => '1200d176',
4416
-
'aphront-panel-view-css' => '1200d176',
4417
-
'aphront-table-view-css' => '1200d176',
4418
-
'aphront-tokenizer-control-css' => '1200d176',
4419
-
'aphront-tooltip-css' => '1200d176',
4420
-
'aphront-typeahead-control-css' => '1200d176',
4412
+
'aphront-dialog-view-css' => '606d1ed1',
4413
+
'aphront-error-view-css' => '606d1ed1',
4414
+
'aphront-list-filter-view-css' => '606d1ed1',
4415
+
'aphront-pager-view-css' => '606d1ed1',
4416
+
'aphront-panel-view-css' => '606d1ed1',
4417
+
'aphront-table-view-css' => '606d1ed1',
4418
+
'aphront-tokenizer-control-css' => '606d1ed1',
4419
+
'aphront-tooltip-css' => '606d1ed1',
4420
+
'aphront-typeahead-control-css' => '606d1ed1',
4421
4421
'differential-changeset-view-css' => '44bfe40c',
4422
4422
'differential-core-view-css' => '44bfe40c',
4423
4423
'differential-inline-comment-editor' => '5e9e5c4e',
···
4431
4431
'differential-table-of-contents-css' => '44bfe40c',
4432
4432
'diffusion-commit-view-css' => 'c8ce2d88',
4433
4433
'diffusion-icons-css' => 'c8ce2d88',
4434
-
'global-drag-and-drop-css' => '1200d176',
4434
+
'global-drag-and-drop-css' => '606d1ed1',
4435
4435
'inline-comment-summary-css' => '44bfe40c',
4436
4436
'javelin-aphlict' => '8977e356',
4437
4437
'javelin-behavior' => 'f32597c9',
···
4504
4504
'javelin-util' => 'f32597c9',
4505
4505
'javelin-vector' => 'f32597c9',
4506
4506
'javelin-workflow' => 'f32597c9',
4507
-
'lightbox-attachment-css' => '1200d176',
4507
+
'lightbox-attachment-css' => '606d1ed1',
4508
4508
'maniphest-task-summary-css' => 'ad2ed1da',
4509
4509
'maniphest-transaction-detail-css' => 'ad2ed1da',
4510
-
'phabricator-action-list-view-css' => '1200d176',
4511
-
'phabricator-application-launch-view-css' => '1200d176',
4510
+
'phabricator-action-list-view-css' => '606d1ed1',
4511
+
'phabricator-application-launch-view-css' => '606d1ed1',
4512
4512
'phabricator-busy' => '8977e356',
4513
4513
'phabricator-content-source-view-css' => '44bfe40c',
4514
-
'phabricator-core-css' => '1200d176',
4515
-
'phabricator-crumbs-view-css' => '1200d176',
4514
+
'phabricator-core-css' => '606d1ed1',
4515
+
'phabricator-crumbs-view-css' => '606d1ed1',
4516
4516
'phabricator-drag-and-drop-file-upload' => '5e9e5c4e',
4517
4517
'phabricator-dropdown-menu' => '8977e356',
4518
4518
'phabricator-file-upload' => '8977e356',
4519
-
'phabricator-filetree-view-css' => '1200d176',
4520
-
'phabricator-flag-css' => '1200d176',
4521
-
'phabricator-header-view-css' => '1200d176',
4519
+
'phabricator-filetree-view-css' => '606d1ed1',
4520
+
'phabricator-flag-css' => '606d1ed1',
4521
+
'phabricator-header-view-css' => '606d1ed1',
4522
4522
'phabricator-hovercard' => '8977e356',
4523
-
'phabricator-jump-nav' => '1200d176',
4523
+
'phabricator-jump-nav' => '606d1ed1',
4524
4524
'phabricator-keyboard-shortcut' => '8977e356',
4525
4525
'phabricator-keyboard-shortcut-manager' => '8977e356',
4526
-
'phabricator-main-menu-view' => '1200d176',
4526
+
'phabricator-main-menu-view' => '606d1ed1',
4527
4527
'phabricator-menu-item' => '8977e356',
4528
-
'phabricator-nav-view-css' => '1200d176',
4528
+
'phabricator-nav-view-css' => '606d1ed1',
4529
4529
'phabricator-notification' => '8977e356',
4530
-
'phabricator-notification-css' => '1200d176',
4531
-
'phabricator-notification-menu-css' => '1200d176',
4530
+
'phabricator-notification-css' => '606d1ed1',
4531
+
'phabricator-notification-menu-css' => '606d1ed1',
4532
4532
'phabricator-object-selector-css' => '44bfe40c',
4533
4533
'phabricator-phtize' => '8977e356',
4534
4534
'phabricator-prefab' => '8977e356',
4535
4535
'phabricator-project-tag-css' => 'ad2ed1da',
4536
-
'phabricator-property-list-view-css' => '1200d176',
4537
-
'phabricator-remarkup-css' => '1200d176',
4536
+
'phabricator-property-list-view-css' => '606d1ed1',
4537
+
'phabricator-remarkup-css' => '606d1ed1',
4538
4538
'phabricator-shaped-request' => '5e9e5c4e',
4539
-
'phabricator-side-menu-view-css' => '1200d176',
4540
-
'phabricator-standard-page-view' => '1200d176',
4541
-
'phabricator-tag-view-css' => '1200d176',
4539
+
'phabricator-side-menu-view-css' => '606d1ed1',
4540
+
'phabricator-standard-page-view' => '606d1ed1',
4541
+
'phabricator-tag-view-css' => '606d1ed1',
4542
4542
'phabricator-textareautils' => '8977e356',
4543
4543
'phabricator-tooltip' => '8977e356',
4544
-
'phabricator-transaction-view-css' => '1200d176',
4545
-
'phabricator-zindex-css' => '1200d176',
4546
-
'phui-button-css' => '1200d176',
4547
-
'phui-form-css' => '1200d176',
4548
-
'phui-form-view-css' => '1200d176',
4549
-
'phui-icon-view-css' => '1200d176',
4550
-
'phui-object-item-list-view-css' => '1200d176',
4551
-
'phui-spacing-css' => '1200d176',
4552
-
'sprite-apps-large-css' => '1200d176',
4553
-
'sprite-gradient-css' => '1200d176',
4554
-
'sprite-icons-css' => '1200d176',
4555
-
'sprite-menu-css' => '1200d176',
4556
-
'syntax-highlighting-css' => '1200d176',
4544
+
'phabricator-transaction-view-css' => '606d1ed1',
4545
+
'phabricator-zindex-css' => '606d1ed1',
4546
+
'phui-button-css' => '606d1ed1',
4547
+
'phui-form-css' => '606d1ed1',
4548
+
'phui-form-view-css' => '606d1ed1',
4549
+
'phui-icon-view-css' => '606d1ed1',
4550
+
'phui-object-item-list-view-css' => '606d1ed1',
4551
+
'phui-spacing-css' => '606d1ed1',
4552
+
'sprite-apps-large-css' => '606d1ed1',
4553
+
'sprite-gradient-css' => '606d1ed1',
4554
+
'sprite-icons-css' => '606d1ed1',
4555
+
'sprite-menu-css' => '606d1ed1',
4556
+
'syntax-highlighting-css' => '606d1ed1',
4557
4557
),
4558
4558
));
+8
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
+8
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
207
207
$list->setNoDataString(pht("No results found for this query."));
208
208
$list->setPager($pager);
209
209
} else {
210
-
$nav->appendChild($pager);
210
+
if ($pager->willShowPagingControls()) {
211
+
$pager_box = id(new PHUIBoxView())
212
+
->addPadding(PHUI::PADDING_MEDIUM)
213
+
->addMargin(PHUI::MARGIN_LARGE)
214
+
->setShadow(true)
215
+
->appendChild($pager);
216
+
$nav->appendChild($pager_box);
217
+
}
211
218
}
212
219
}
213
220
+7
src/view/control/AphrontCursorPagerView.php
+7
src/view/control/AphrontCursorPagerView.php
···
79
79
return $results;
80
80
}
81
81
82
+
public function willShowPagingControls() {
83
+
return $this->prevPageID ||
84
+
$this->nextPageID ||
85
+
$this->afterID ||
86
+
($this->beforeID && $this->moreResults);
87
+
}
88
+
82
89
public function render() {
83
90
if (!$this->uri) {
84
91
throw new Exception(