recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Mail: Do not add a null value to mail actor array

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php:132]
```

Closes T16367

Test Plan: Go to a user profile page, select "Send Welcome Email", click "Send Email".

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16367

Differential Revision: https://we.phorge.it/D26538

Andre Klapper a2b0045d 5f0b92ac

+4 -1
+4 -1
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
··· 847 847 return $this->expandRecipients($actor_phids); 848 848 } 849 849 850 + /** 851 + * @return array<string> PHIDs and/or empty strings 852 + */ 850 853 private function getAllActorPHIDs() { 851 854 return array_merge( 852 - array($this->getParam('from')), 855 + array($this->getParam('from', '')), 853 856 $this->getToPHIDs(), 854 857 $this->getCcPHIDs()); 855 858 }