@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Change PHP 7 setup warning to complain about 7.0 only, not 7.1+
Summary: Ref T9640. On 7.0 we had signal handling issues so we can never support it, but async signals should resolve them on 7.1 or newer.
Test Plan: On PHP 7.1, got through the setup warning.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9640
Differential Revision: https://secure.phabricator.com/D17197
+5
-4
+5
-4
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
+5
-4
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
···
11
11
}
12
12
13
13
protected function executeChecks() {
14
-
if (version_compare(phpversion(), 7, '>=')) {
14
+
if (version_compare(phpversion(), 7, '>=') &&
15
+
version_compare(phpversion(), 7.1, '<')) {
15
16
$message = pht(
16
-
'This version of Phabricator does not support PHP 7. You '.
17
-
'are running PHP %s.',
17
+
'This version of Phabricator does not support PHP 7.0. You '.
18
+
'are running PHP %s. Upgrade to PHP 7.1 or newer.',
18
19
phpversion());
19
20
20
21
$this->newIssue('php.version7')
21
22
->setIsFatal(true)
22
-
->setName(pht('PHP 7 Not Supported'))
23
+
->setName(pht('PHP 7.0 Not Supported'))
23
24
->setMessage($message)
24
25
->addLink(
25
26
'https://phurl.io/u/php7',