@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Owners lookups for the repository root
Summary:
Ref T9201. At the root of a repository the current path is `null`, but the OwnersQuery wants strings.
This could be resolved a couple different ways, but just cast the arguments to strings since that seems reasonable enough.
Test Plan: Browsed root of a repository.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9201
Differential Revision: https://secure.phabricator.com/D13919
+3
-2
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
+3
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
+3
src/applications/owners/query/PhabricatorOwnersPackageQuery.php
···
42
42
}
43
43
44
44
foreach ($paths as $path) {
45
+
$path = (string)$path;
45
46
$this->controlMap[$repository_phid][$path] = $path;
46
47
}
47
48
···
277
278
* @return list<PhabricatorOwnersPackage> List of controlling packages.
278
279
*/
279
280
public function getControllingPackagesForPath($repository_phid, $path) {
281
+
$path = (string)$path;
282
+
280
283
if (!isset($this->controlMap[$repository_phid][$path])) {
281
284
throw new PhutilInvalidStateException('withControl');
282
285
}