@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove pointless requireCapabilities() method from PhabricatorProjectColumnTransactionEditor
Summary:
Depends on D19581. Ref T13164. This method has no effect:
- You must always have CAN_EDIT to reach an Editor in the first place.
- Per previous change, I'm going to restructure this so transactions explicitly check CAN_EDIT by default anyway.
Test Plan: Tried to edit and hide a project column as a user without permission, hit global permission checks long before reaching this method.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13164
Differential Revision: https://secure.phabricator.com/D19582
-18
-18
src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php
-18
src/applications/project/editor/PhabricatorProjectColumnTransactionEditor.php
···
137
137
return $errors;
138
138
}
139
139
140
-
141
-
protected function requireCapabilities(
142
-
PhabricatorLiskDAO $object,
143
-
PhabricatorApplicationTransaction $xaction) {
144
-
145
-
switch ($xaction->getTransactionType()) {
146
-
case PhabricatorProjectColumnTransaction::TYPE_NAME:
147
-
case PhabricatorProjectColumnTransaction::TYPE_STATUS:
148
-
PhabricatorPolicyFilter::requireCapability(
149
-
$this->requireActor(),
150
-
$object,
151
-
PhabricatorPolicyCapability::CAN_EDIT);
152
-
return;
153
-
}
154
-
155
-
return parent::requireCapabilities($object, $xaction);
156
-
}
157
-
158
140
}