@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Indent multiple items from the same application in Quick Create menu
Summary: Ref T10004. Happy to take another approach here or just not bother, this just struck me as a little ambiguous/confusing.
Test Plan:
Before, not necessarily clear that the "Create Task" header only applies to the first few items.
{F1029126}
After, more clear:
{F1029127}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10004
Differential Revision: https://secure.phabricator.com/D14815
+27
-2
+2
-1
src/applications/transactions/editengine/PhabricatorEditEngine.php
+2
-1
src/applications/transactions/editengine/PhabricatorEditEngine.php
+20
-1
src/view/phui/PHUIListItemView.php
+20
-1
src/view/phui/PHUIListItemView.php
···
28
28
private $order;
29
29
private $aural;
30
30
private $profileImage;
31
+
private $indented;
31
32
32
33
public function setDropdownMenu(PhabricatorActionListView $actions) {
33
34
Javelin::initBehavior('phui-dropdown-menu');
···
89
90
90
91
public function getIcon() {
91
92
return $this->icon;
93
+
}
94
+
95
+
public function setIndented($indented) {
96
+
$this->indented = $indented;
97
+
return $this;
98
+
}
99
+
100
+
public function getIndented() {
101
+
return $this->indented;
92
102
}
93
103
94
104
public function setKey($key) {
···
256
266
->setIconFont($this->appIcon);
257
267
}
258
268
269
+
$classes = array();
270
+
if ($this->href) {
271
+
$classes[] = 'phui-list-item-href';
272
+
}
273
+
274
+
if ($this->indented) {
275
+
$classes[] = 'phui-list-item-indented';
276
+
}
277
+
259
278
return javelin_tag(
260
279
$this->href ? 'a' : 'div',
261
280
array(
262
281
'href' => $this->href,
263
-
'class' => $this->href ? 'phui-list-item-href' : null,
282
+
'class' => implode(' ', $classes),
264
283
'meta' => $meta,
265
284
'sigil' => $sigil,
266
285
),
+5
webroot/rsrc/css/phui/phui-list.css
+5
webroot/rsrc/css/phui/phui-list.css