@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make setup check groups more robust against fataling existing subclasses
Auditors: chad
+8
-1
+8
-1
src/applications/config/check/PhabricatorSetupCheck.php
+8
-1
src/applications/config/check/PhabricatorSetupCheck.php
···
19
19
$issue = id(new PhabricatorSetupIssue())
20
20
->setIssueKey($key);
21
21
$this->issues[$key] = $issue;
22
-
$issue->setGroup($this->getDefaultGroup());
22
+
23
+
if ($this->getDefaultGroup()) {
24
+
$issue->setGroup($this->getDefaultGroup());
25
+
}
23
26
24
27
return $issue;
25
28
}
26
29
27
30
final public function getIssues() {
28
31
return $this->issues;
32
+
}
33
+
34
+
public function getDefaultGroup() {
35
+
return null;
29
36
}
30
37
31
38
final public function runSetupChecks() {