@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When a ChangesetList sleeps after a Quicksand navigation, also hide any visible banner
Summary: Fixes T13080. The banner wasn't properly included in the sleep/wake logic.
Test Plan:
Mentioned `Dxxx` on a task. Enabled persistent chat to activate Quicksand. Reloaded page. Clicked `Dxxx`. Scrolled down until a changeset header appeared. Pressed back button.
- Before patch: ended up on task, with header still around.
- After patch: ended up on task, with header properly vanquished.
Pressed "forward", ended up back on the revision with the header again.
Maniphest Tasks: T13080
Differential Revision: https://secure.phabricator.com/D19086
+18
-12
+7
-7
resources/celerity/map.php
+7
-7
resources/celerity/map.php
···
13
13
'core.pkg.js' => '3ac6e174',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '113e692c',
16
-
'differential.pkg.js' => '5d53d5ce',
16
+
'differential.pkg.js' => 'f6d809c0',
17
17
'diffusion.pkg.css' => 'a2d17c7d',
18
18
'diffusion.pkg.js' => '6134c5a1',
19
19
'favicon.ico' => '30672e08',
···
396
396
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
397
397
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
398
398
'rsrc/js/application/diff/DiffChangeset.js' => 'b49b59d6',
399
-
'rsrc/js/application/diff/DiffChangesetList.js' => '1f2e5265',
399
+
'rsrc/js/application/diff/DiffChangesetList.js' => 'e74b7517',
400
400
'rsrc/js/application/diff/DiffInline.js' => 'e83d28f3',
401
401
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
402
402
'rsrc/js/application/differential/behavior-comment-preview.js' => '51c5ad07',
···
776
776
'phabricator-darkmessage' => 'c48cccdd',
777
777
'phabricator-dashboard-css' => 'fe5b1869',
778
778
'phabricator-diff-changeset' => 'b49b59d6',
779
-
'phabricator-diff-changeset-list' => '1f2e5265',
779
+
'phabricator-diff-changeset-list' => 'e74b7517',
780
780
'phabricator-diff-inline' => 'e83d28f3',
781
781
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
782
782
'phabricator-draggable-list' => 'bea6e7f4',
···
1043
1043
'javelin-mask',
1044
1044
'javelin-uri',
1045
1045
'javelin-routable',
1046
-
),
1047
-
'1f2e5265' => array(
1048
-
'javelin-install',
1049
-
'phuix-button-view',
1050
1046
),
1051
1047
'1f6794f6' => array(
1052
1048
'javelin-behavior',
···
2092
2088
'javelin-json',
2093
2089
'javelin-workflow',
2094
2090
'javelin-magical-init',
2091
+
),
2092
+
'e74b7517' => array(
2093
+
'javelin-install',
2094
+
'phuix-button-view',
2095
2095
),
2096
2096
'e83d28f3' => array(
2097
2097
'javelin-dom',
+11
-5
webroot/rsrc/js/application/diff/DiffChangesetList.js
+11
-5
webroot/rsrc/js/application/diff/DiffChangesetList.js
···
128
128
this._redrawFocus();
129
129
this._redrawSelection();
130
130
this.resetHover();
131
+
132
+
this._bannerChangeset = null;
133
+
this._redrawBanner();
131
134
},
132
135
133
136
wake: function() {
···
135
138
136
139
this._redrawFocus();
137
140
this._redrawSelection();
141
+
142
+
this._bannerChangeset = null;
143
+
this._redrawBanner();
138
144
139
145
if (this._initialized) {
140
146
return;
···
1374
1380
var node = this._getBannerNode();
1375
1381
var changeset = this._getVisibleChangeset();
1376
1382
1383
+
if (!changeset) {
1384
+
JX.DOM.remove(node);
1385
+
return;
1386
+
}
1387
+
1377
1388
// Don't do anything if nothing has changed. This seems to avoid some
1378
1389
// flickering issues in Safari, at least.
1379
1390
if (this._bannerChangeset === changeset) {
1380
1391
return;
1381
1392
}
1382
1393
this._bannerChangeset = changeset;
1383
-
1384
-
if (!changeset) {
1385
-
JX.DOM.remove(node);
1386
-
return;
1387
-
}
1388
1394
1389
1395
var inlines = this._getInlinesByType();
1390
1396