@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix the Javelin Celerity map building

Summary: Each test case `@provides` the same resource. This caused every test to overwrite the others, picking one hash at random based on the order of the files, which depends on implementation.

Test Plan: * Run ./bin/celerity map

Reviewers: aklapper, O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16533

Differential Revision: https://we.phorge.it/D26810

+27 -22
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/missing-dependency.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 - * @provides javelin-test 3 + * @provides javelin-test-missing-dependency 4 4 * 5 5 * @javelin-installs JX.Test 6 6 *
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/private-access.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 3 * javelin-history 4 - * @provides javelin-test 4 + * @provides javelin-test-private-access 5 5 * 6 6 * @javelin-installs JX.Test 7 7 *
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/undocumented-install.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 - * @provides javelin-test 3 + * @provides javelin-test-undocumented-install 4 4 * 5 5 * @javelin-installs JX.Test 6 6 *
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/uninstalled-documentation.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 - * @provides javelin-test 3 + * @provides javelin-test-uninstalled-documentation 4 4 * 5 5 * @javelin-installs JX.Test 6 6 * @javelin-installs JX.Test2
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/unknown-dependency.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 3 * javelin-does-not-exist 4 - * @provides javelin-test 4 + * @provides javelin-test-unknown-dependency 5 5 * 6 6 * @javelin-installs JX.Test 7 7 *
+1 -1
src/infrastructure/lint/linter/__tests__/javelin/unnecessary-dependency.lint-test
··· 1 1 /** 2 2 * @requires javelin-install 3 3 * javelin-workflow 4 - * @provides javelin-test 4 + * @provides javelin-test-unnecessary-dependency 5 5 * 6 6 * @javelin-installs JX.Test 7 7 *
+21 -16
src/infrastructure/lint/linter/__tests__/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'missing-dependency.lint-test' => '3f966f42', 11 - 'private-access.lint-test' => 'fa831308', 12 - 'undocumented-install.lint-test' => 'e575f333', 13 - 'uninstalled-documentation.lint-test' => '9b61fd26', 14 - 'unknown-dependency.lint-test' => 'abc533df', 15 - 'unnecessary-dependency.lint-test' => '1608e0c1', 10 + 'missing-dependency.lint-test' => 'd9d7accf', 11 + 'private-access.lint-test' => 'c5a55aba', 12 + 'undocumented-install.lint-test' => 'b40b9df9', 13 + 'uninstalled-documentation.lint-test' => 'a7b7fab0', 14 + 'unknown-dependency.lint-test' => '70c6209f', 15 + 'unnecessary-dependency.lint-test' => 'f7db3a25', 16 16 ), 17 17 'symbols' => array( 18 - 'javelin-test' => '3f966f42', 18 + 'javelin-test-missing-dependency' => 'd9d7accf', 19 + 'javelin-test-private-access' => 'c5a55aba', 20 + 'javelin-test-undocumented-install' => 'b40b9df9', 21 + 'javelin-test-uninstalled-documentation' => 'a7b7fab0', 22 + 'javelin-test-unknown-dependency' => '70c6209f', 23 + 'javelin-test-unnecessary-dependency' => 'f7db3a25', 19 24 ), 20 25 'requires' => array( 21 - '1608e0c1' => array( 26 + '70c6209f' => array( 22 27 'javelin-install', 23 - 'javelin-workflow', 28 + 'javelin-does-not-exist', 24 29 ), 25 - '3f966f42' => array( 30 + 'a7b7fab0' => array( 26 31 'javelin-install', 27 32 ), 28 - '9b61fd26' => array( 33 + 'b40b9df9' => array( 29 34 'javelin-install', 30 35 ), 31 - 'abc533df' => array( 36 + 'c5a55aba' => array( 32 37 'javelin-install', 33 - 'javelin-does-not-exist', 38 + 'javelin-history', 34 39 ), 35 - 'e575f333' => array( 40 + 'd9d7accf' => array( 36 41 'javelin-install', 37 42 ), 38 - 'fa831308' => array( 43 + 'f7db3a25' => array( 39 44 'javelin-install', 40 - 'javelin-history', 45 + 'javelin-workflow', 41 46 ), 42 47 ), 43 48 'packages' => array(),