@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bad parameter read in hovercard
Summary: I broke this at the last second in D17374. `getStrList()` doesn't read arrays. It probably should (more modern analogs do) but don't rock the boat in the leadup to the release cut.
Test Plan: Hovered over a thing, saw a hovercard and no `getStrList()` error in my logs.
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17383
+1
-1
+1
-1
src/applications/search/controller/PhabricatorSearchHovercardController.php
+1
-1
src/applications/search/controller/PhabricatorSearchHovercardController.php
···
9
9
10
10
public function handleRequest(AphrontRequest $request) {
11
11
$viewer = $this->getViewer();
12
-
$phids = $request->getStrList('phids');
12
+
$phids = $request->getArr('phids');
13
13
14
14
// If object names are provided, look them up and pretend they were
15
15
// passed as additional PHIDs. This is primarily useful for debugging,