@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update inline-comment styles in Differential
Summary:
Moderize Inline Comment Display
- Use standard colors
- Better display with/without comment
- OMG Icons
Test Plan:
{F148256}
Test with and without main comment, test with many for few comments on 1-3 files.
Reviewers: epriestley, btrahan
Reviewed By: btrahan
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8885
+40
-11
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
10
10
'core.pkg.css' => '9e7cce62',
11
11
'core.pkg.js' => '417722ff',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
-
'differential.pkg.css' => '12c11318',
13
+
'differential.pkg.css' => '8a064eb7',
14
14
'differential.pkg.js' => '11a5b750',
15
15
'diffusion.pkg.css' => '3783278d',
16
16
'diffusion.pkg.js' => '5b4010f4',
···
52
52
'rsrc/css/application/conpherence/widget-pane.css' => '87b12e0c',
53
53
'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
54
54
'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
55
-
'rsrc/css/application/diff/inline-comment-summary.css' => '14a91639',
55
+
'rsrc/css/application/diff/inline-comment-summary.css' => '3b2d1492',
56
56
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
57
57
'rsrc/css/application/differential/changeset-view.css' => '1570a1ff',
58
58
'rsrc/css/application/differential/core.css' => '7ac3cabc',
···
526
526
'herald-css' => 'c544dd1c',
527
527
'herald-rule-editor' => '22d2966a',
528
528
'herald-test-css' => '778b008e',
529
-
'inline-comment-summary-css' => '14a91639',
529
+
'inline-comment-summary-css' => '3b2d1492',
530
530
'javelin-aphlict' => '493665ee',
531
531
'javelin-behavior' => '8a3ed18b',
532
532
'javelin-behavior-aphlict-dropdown' => '2a2dba85',
+13
-1
src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
+13
-1
src/infrastructure/diff/view/PhabricatorInlineSummaryView.php
···
19
19
}
20
20
21
21
private function renderHeader() {
22
-
return phutil_tag_div('phabricator-inline-summary', pht('Inline Comments'));
22
+
$icon = id(new PHUIIconView())
23
+
->setIconFont('fa-comment bluegrey msr');
24
+
25
+
$header = phutil_tag_div(
26
+
'phabricator-inline-summary',
27
+
array(
28
+
$icon,
29
+
pht('Inline Comments')));
30
+
return $header;
23
31
}
24
32
25
33
private function renderTable() {
···
59
67
}
60
68
61
69
if ($href) {
70
+
$icon = id(new PHUIIconView())
71
+
->setIconFont('fa-share white msr');
72
+
62
73
$lines = phutil_tag(
63
74
'a',
64
75
array(
···
67
78
'class' => 'num',
68
79
),
69
80
array(
81
+
$icon,
70
82
$lines,
71
83
$tail,
72
84
));
+24
-7
webroot/rsrc/css/application/diff/inline-comment-summary.css
+24
-7
webroot/rsrc/css/application/diff/inline-comment-summary.css
···
3
3
*/
4
4
5
5
.phabricator-inline-summary {
6
-
margin: .75em 0 .5em;
7
-
font-size: 11px;
8
-
border-bottom: 1px solid #dddddd;
9
-
color: {$greytext};
6
+
font-size: 12px;
7
+
text-transform: uppercase;
8
+
font-weight: bold;
9
+
color: {$bluetext};
10
+
padding-top: 12px;
11
+
margin-top: 12px;
12
+
border-top: 1px solid {$thinblueborder};
13
+
}
14
+
15
+
.phabricator-remarkup + .phabricator-inline-summary {
16
+
padding-top: 16px;
10
17
}
11
18
12
19
.phabricator-inline-summary-table {
···
15
22
16
23
.phabricator-inline-summary-table th {
17
24
padding: 6px 0px;
18
-
color: {$darkgreytext};
25
+
color: {$lightgreytext};
19
26
}
20
27
21
28
.phabricator-inline-summary-table td {
22
29
padding: 0px 4px 6px;
23
30
white-space: nowrap;
31
+
color: {$darkbluetext};
24
32
}
25
33
26
34
.phabricator-inline-summary-table td.inline-line-number {
27
35
padding-left: 0px;
28
36
width: 100px;
37
+
white-space: nowrap;
29
38
}
30
39
31
40
.phabricator-inline-summary-table td.inline-which-diff {
···
43
52
target (by highlighting the entire cell). */
44
53
45
54
.phabricator-inline-summary-table td.inline-line-number a.num {
46
-
padding-left: 16px;
55
+
padding-left: 4px;
47
56
display: block;
48
57
font-weight: bold;
58
+
color: {$blue};
49
59
}
50
60
51
61
.phabricator-inline-summary-table td.inline-line-number a.num:hover {
52
-
background: #3b5998;
62
+
background: {$blue};
63
+
border-radius: 3px;
53
64
color: white;
54
65
text-decoration: none;
55
66
}
67
+
68
+
.phui-timeline-core-content .phabricator-inline-summary:first-child {
69
+
border: none;
70
+
margin-top: 0;
71
+
padding-top: 0;
72
+
}