recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[Redesign] Add Table, Collapse support to ObjectBox

Summary: Converts most all tables to be directly set via `setTable` to an ObjectBox. I think this path is more flexible design wise, as we can change the box based on children, and not just CSS. We also already do this with PropertyList, Forms, ObjectList, and Header. `setCollapsed` is added to ObjectBox to all children objects to bleed to the edges (like diffs).

Test Plan: I did a grep of `appendChild($table)` as well as searches for `PHUIObjectBoxView`, also with manual opening of hundreds of files. I'm sure I missed 5-8 places. If you just appendChild($table) nothing breaks, it just looks a little funny.

Reviewers: epriestley, btrahan

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D12955

Chad Little a4784e03 667159eb

+126 -100
+1 -1
src/applications/almanac/controller/AlmanacController.php
··· 176 176 177 177 return id(new PHUIObjectBoxView()) 178 178 ->setHeader($header) 179 - ->appendChild($table); 179 + ->setTable($table); 180 180 } 181 181 182 182 protected function addLockMessage(PHUIObjectBoxView $box, $message) {
+1 -1
src/applications/almanac/controller/AlmanacDeviceEditController.php
··· 141 141 $box = id(new PHUIObjectBoxView()) 142 142 ->setValidationException($validation_exception) 143 143 ->setHeaderText($title) 144 - ->appendChild($form); 144 + ->setForm($form); 145 145 146 146 $crumbs = $this->buildApplicationCrumbs(); 147 147 if ($is_new) {
+3 -3
src/applications/almanac/controller/AlmanacDeviceViewController.php
··· 139 139 140 140 return id(new PHUIObjectBoxView()) 141 141 ->setHeader($header) 142 - ->appendChild($table); 142 + ->setTable($table); 143 143 } 144 144 145 145 private function buildSSHKeysTable(AlmanacDevice $device) { ··· 200 200 201 201 return id(new PHUIObjectBoxView()) 202 202 ->setHeader($header) 203 - ->appendChild($table); 203 + ->setTable($table); 204 204 205 205 206 206 } ··· 249 249 250 250 return id(new PHUIObjectBoxView()) 251 251 ->setHeaderText(pht('Bound Services')) 252 - ->appendChild($table); 252 + ->setTable($table); 253 253 } 254 254 255 255
+1 -1
src/applications/almanac/controller/AlmanacInterfaceEditController.php
··· 132 132 $box = id(new PHUIObjectBoxView()) 133 133 ->setValidationException($validation_exception) 134 134 ->setHeaderText($title) 135 - ->appendChild($form); 135 + ->setForm($form); 136 136 137 137 $crumbs = $this->buildApplicationCrumbs(); 138 138 $crumbs->addTextCrumb($device->getName(), $device_uri);
+1 -1
src/applications/almanac/controller/AlmanacNetworkEditController.php
··· 120 120 $box = id(new PHUIObjectBoxView()) 121 121 ->setValidationException($validation_exception) 122 122 ->setHeaderText($title) 123 - ->appendChild($form); 123 + ->setForm($form); 124 124 125 125 $crumbs = $this->buildApplicationCrumbs(); 126 126 if ($is_new) {
+1 -1
src/applications/almanac/controller/AlmanacServiceEditController.php
··· 238 238 $box = id(new PHUIObjectBoxView()) 239 239 ->setFormErrors($errors) 240 240 ->setHeaderText($title) 241 - ->appendChild($form); 241 + ->setForm($form); 242 242 243 243 return $this->buildApplicationPage( 244 244 array(
+1 -1
src/applications/almanac/controller/AlmanacServiceViewController.php
··· 141 141 142 142 return id(new PHUIObjectBoxView()) 143 143 ->setHeader($header) 144 - ->appendChild($table); 144 + ->setTable($table); 145 145 } 146 146 147 147 }
+1 -1
src/applications/auth/provider/PhabricatorPasswordAuthProvider.php
··· 94 94 95 95 return id(new PHUIObjectBoxView()) 96 96 ->setHeader($header) 97 - ->appendChild($table); 97 + ->setTable($table); 98 98 } 99 99 100 100 public function getDescriptionForCreate() {
+1 -1
src/applications/auth/query/PhabricatorAuthInviteSearchEngine.php
··· 104 104 105 105 return id(new PHUIObjectBoxView()) 106 106 ->setHeaderText(pht('Email Invitations')) 107 - ->appendChild($table); 107 + ->setTable($table); 108 108 } 109 109 }
+5 -1
src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
··· 29 29 ->buildApplicationCrumbs() 30 30 ->addTextCrumb(pht('Channel List'), $this->getApplicationURI()); 31 31 32 + $box = id(new PHUIObjectBoxView()) 33 + ->setHeaderText('Channel List') 34 + ->setObjectList($list); 35 + 32 36 return $this->buildApplicationPage( 33 37 array( 34 38 $crumbs, 35 - $list, 39 + $box, 36 40 ), 37 41 array( 38 42 'title' => pht('Channel List'),
+2 -2
src/applications/conduit/controller/PhabricatorConduitAPIController.php
··· 566 566 567 567 $param_panel = new PHUIObjectBoxView(); 568 568 $param_panel->setHeaderText(pht('Method Parameters')); 569 - $param_panel->appendChild($param_table); 569 + $param_panel->setTable($param_table); 570 570 571 571 $result_panel = new PHUIObjectBoxView(); 572 572 $result_panel->setHeaderText(pht('Method Result')); 573 - $result_panel->appendChild($result_table); 573 + $result_panel->setTable($result_table); 574 574 575 575 $method_uri = $this->getApplicationURI('method/'.$method.'/'); 576 576
+3 -3
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
··· 86 86 87 87 $form_box = id(new PHUIObjectBoxView()) 88 88 ->setHeaderText(pht('Call Method')) 89 - ->appendChild($form); 89 + ->setForm($form); 90 90 91 91 $content = array(); 92 92 ··· 129 129 )); 130 130 $content[] = id(new PHUIObjectBoxView()) 131 131 ->setHeaderText(pht('Builtin Orders')) 132 - ->appendChild($table); 132 + ->setTable($table); 133 133 134 134 $columns = $query->getOrderableColumns(); 135 135 ··· 154 154 )); 155 155 $content[] = id(new PHUIObjectBoxView()) 156 156 ->setHeaderText(pht('Column Orders')) 157 - ->appendChild($table); 157 + ->setTable($table); 158 158 } 159 159 160 160 $crumbs = $this->buildApplicationCrumbs();
+1 -1
src/applications/conduit/controller/PhabricatorConduitLogController.php
··· 37 37 $table = $this->renderCallTable($calls, $conns); 38 38 $box = id(new PHUIObjectBoxView()) 39 39 ->setHeaderText(pht('Call Logs')) 40 - ->appendChild($table); 40 + ->setTable($table); 41 41 42 42 $crumbs = $this->buildApplicationCrumbs(); 43 43 $crumbs->addTextCrumb(pht('Call Logs'));
+1 -1
src/applications/conduit/settings/PhabricatorConduitTokensSettingsPanel.php
··· 108 108 109 109 $panel = id(new PHUIObjectBoxView()) 110 110 ->setHeader($header) 111 - ->appendChild($table); 111 + ->setTable($table); 112 112 113 113 return $panel; 114 114 }
+1 -1
src/applications/config/controller/PhabricatorConfigAllController.php
··· 57 57 58 58 $panel = new PHUIObjectBoxView(); 59 59 $panel->setHeaderText(pht('Current Settings')); 60 - $panel->appendChild($table); 60 + $panel->setTable($table); 61 61 62 62 $versions = $this->loadVersions(); 63 63
+1 -1
src/applications/config/controller/PhabricatorConfigCacheController.php
··· 92 92 return id(new PHUIObjectBoxView()) 93 93 ->setHeaderText(pht('Data Cache')) 94 94 ->addPropertyList($properties) 95 - ->appendChild($table); 95 + ->setTable($table); 96 96 } 97 97 98 98 private function renderCommonProperties(
+1 -1
src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
··· 150 150 $table_box = id(new PHUIObjectBoxView()) 151 151 ->setHeader($this->buildHeaderWithDocumentationLink($title)) 152 152 ->setFormErrors($errors) 153 - ->appendChild($table); 153 + ->setTable($table); 154 154 155 155 $nav = $this->buildSideNavView(); 156 156 $nav->selectFilter('dbissue/');
+27 -15
src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
··· 165 165 ), 166 166 $comp->getIssues()); 167 167 168 - $box = id(new PHUIObjectBoxView()) 168 + $prop_box = id(new PHUIObjectBoxView()) 169 169 ->setHeader($this->buildHeaderWithDocumentationLink($title)) 170 - ->addPropertyList($properties) 171 - ->appendChild($table); 170 + ->addPropertyList($properties); 171 + 172 + $table_box = id(new PHUIObjectBoxView()) 173 + ->setHeaderText(pht('Databases')) 174 + ->setTable($table); 172 175 173 - return $this->buildResponse($title, $box); 176 + return $this->buildResponse($title, array($prop_box, $table_box)); 174 177 } 175 178 176 179 private function renderDatabase( ··· 219 222 null, 220 223 )); 221 224 222 - $title = pht('Database Status: %s', $database_name); 225 + $title = pht('Database: %s', $database_name); 223 226 224 227 $actual_database = $actual->getDatabase($database_name); 225 228 if ($actual_database) { ··· 260 263 ), 261 264 $database->getIssues()); 262 265 263 - $box = id(new PHUIObjectBoxView()) 266 + $prop_box = id(new PHUIObjectBoxView()) 264 267 ->setHeader($this->buildHeaderWithDocumentationLink($title)) 265 - ->addPropertyList($properties) 266 - ->appendChild($table); 268 + ->addPropertyList($properties); 269 + 270 + $table_box = id(new PHUIObjectBoxView()) 271 + ->setHeaderText(pht('Database Status')) 272 + ->setTable($table); 267 273 268 - return $this->buildResponse($title, $box); 274 + return $this->buildResponse($title, array($prop_box, $table_box)); 269 275 } 270 276 271 277 private function renderTable( ··· 443 449 null, 444 450 )); 445 451 446 - $title = pht('Database Status: %s.%s', $database_name, $table_name); 452 + $title = pht('Database: %s.%s', $database_name, $table_name); 447 453 448 454 if ($actual_table) { 449 455 $actual_collation = $actual_table->getCollation(); ··· 470 476 ), 471 477 $table->getIssues()); 472 478 473 - $box = id(new PHUIObjectBoxView()) 479 + $prop_box = id(new PHUIObjectBoxView()) 474 480 ->setHeader($this->buildHeaderWithDocumentationLink($title)) 475 - ->addPropertyList($properties) 476 - ->appendChild($table_view) 477 - ->appendChild($keys_view); 481 + ->addPropertyList($properties); 478 482 479 - return $this->buildResponse($title, $box); 483 + $table_box = id(new PHUIObjectBoxView()) 484 + ->setHeaderText(pht('Database')) 485 + ->setTable($table_view); 486 + 487 + $key_box = id(new PHUIObjectBoxView()) 488 + ->setHeaderText(pht('Keys')) 489 + ->setTable($keys_view); 490 + 491 + return $this->buildResponse($title, array($prop_box, $table_box, $key_box)); 480 492 } 481 493 482 494 private function renderColumn(
+4 -4
src/applications/config/controller/PhabricatorConfigIssueListController.php
··· 28 28 $setup_issues[] = id(new PHUIObjectBoxView()) 29 29 ->setHeaderText(pht('Important Setup Issues')) 30 30 ->setColor(PHUIObjectBoxView::COLOR_RED) 31 - ->appendChild($important); 31 + ->setObjectList($important); 32 32 } 33 33 34 34 if ($php) { 35 35 $setup_issues[] = id(new PHUIObjectBoxView()) 36 36 ->setHeaderText(pht('PHP Setup Issues')) 37 - ->appendChild($php); 37 + ->setObjectList($php); 38 38 } 39 39 40 40 if ($mysql) { 41 41 $setup_issues[] = id(new PHUIObjectBoxView()) 42 42 ->setHeaderText(pht('MySQL Setup Issues')) 43 - ->appendChild($mysql); 43 + ->setObjectList($mysql); 44 44 } 45 45 46 46 if ($other) { 47 47 $setup_issues[] = id(new PHUIObjectBoxView()) 48 48 ->setHeaderText(pht('Other Setup Issues')) 49 - ->appendChild($other); 49 + ->setObjectList($other); 50 50 } 51 51 52 52 if (empty($setup_issues)) {
+1 -1
src/applications/config/controller/PhabricatorConfigListController.php
··· 18 18 19 19 $core = id(new PHUIObjectBoxView()) 20 20 ->setHeaderText($title) 21 - ->appendChild($core_list); 21 + ->setObjectList($core_list); 22 22 23 23 $apps = id(new PHUIObjectBoxView()) 24 24 ->setHeaderText(pht('Applications Configuration'))
+1 -1
src/applications/differential/controller/DifferentialDiffViewController.php
··· 130 130 $prop_box = id(new PHUIObjectBoxView()) 131 131 ->setHeader($property_head) 132 132 ->addPropertyList($property_view) 133 - ->appendChild($form); 133 + ->setForm($form); 134 134 135 135 return $this->buildApplicationPage( 136 136 array(
+1
src/applications/differential/view/DifferentialChangesetListView.php
··· 250 250 251 251 $object_box = id(new PHUIObjectBoxView()) 252 252 ->setHeader($header) 253 + ->setCollapsed(true) 253 254 ->appendChild($content); 254 255 255 256 return $object_box;
+1 -1
src/applications/differential/view/DifferentialRevisionListView.php
··· 195 195 if ($this->header && !$this->noBox) { 196 196 $list->setFlush(true); 197 197 $list = id(new PHUIObjectBoxView()) 198 - ->appendChild($list); 198 + ->setObjectList($list); 199 199 200 200 if ($this->header instanceof PHUIHeaderView) { 201 201 $list->setHeader($this->header);
+1 -1
src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
··· 307 307 return id(new PHUIObjectBoxView()) 308 308 ->setHeaderText(pht('Revision Update History')) 309 309 ->setFlush(true) 310 - ->appendChild($content); 310 + ->setTable($content); 311 311 } 312 312 313 313 const STAR_NONE = 'none';
+1 -1
src/applications/fact/controller/PhabricatorFactHomeController.php
··· 53 53 54 54 $panel = new PHUIObjectBoxView(); 55 55 $panel->setHeaderText(pht('Facts')); 56 - $panel->appendChild($table); 56 + $panel->setTable($table); 57 57 58 58 $chart_form = $this->buildChartForm(); 59 59
+1 -1
src/applications/files/applicationpanel/PhabricatorFilesApplicationStorageEnginePanel.php
··· 87 87 88 88 $box = id(new PHUIObjectBoxView()) 89 89 ->setHeaderText(pht('Storage Engines')) 90 - ->appendChild($table); 90 + ->setTable($table); 91 91 92 92 return $box; 93 93 }
+1 -1
src/applications/fund/controller/FundInitiativeViewController.php
··· 57 57 58 58 $box = id(new PHUIObjectBoxView()) 59 59 ->setHeader($header) 60 - ->appendChild($properties); 60 + ->addPropertyList($properties); 61 61 62 62 63 63 $timeline = $this->buildTransactionTimeline(
+1 -1
src/applications/fund/query/FundBackerSearchEngine.php
··· 143 143 144 144 return id(new PHUIObjectBoxView()) 145 145 ->setHeaderText(pht('Backers')) 146 - ->appendChild($table); 146 + ->setTable($table); 147 147 } 148 148 149 149 }
+1 -1
src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php
··· 284 284 285 285 $box = id(new PHUIObjectBoxView()) 286 286 ->setHeader($header) 287 - ->appendChild($table); 287 + ->setTable($table); 288 288 289 289 if (!$this->document) { 290 290 $policy_notice = id(new PHUIInfoView())
+1 -1
src/applications/maniphest/controller/ManiphestBatchEditController.php
··· 173 173 174 174 $task_box = id(new PHUIObjectBoxView()) 175 175 ->setHeaderText(pht('Selected Tasks')) 176 - ->appendChild($list); 176 + ->setObjectList($list); 177 177 178 178 $form_box = id(new PHUIObjectBoxView()) 179 179 ->setHeaderText(pht('Batch Editor'))
+2 -2
src/applications/maniphest/controller/ManiphestReportController.php
··· 272 272 if ($caption) { 273 273 $panel->setInfoView($caption); 274 274 } 275 - $panel->appendChild($table); 275 + $panel->setTable($table); 276 276 277 277 $tokens = array(); 278 278 if ($handle) { ··· 653 653 654 654 $panel = new PHUIObjectBoxView(); 655 655 $panel->setHeaderText($header); 656 - $panel->appendChild($table); 656 + $panel->setTable($table); 657 657 658 658 $tokens = array(); 659 659 if ($project_handle) {
+1 -1
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 341 341 $comment_box = id(new PHUIObjectBoxView()) 342 342 ->setFlush(true) 343 343 ->setHeaderText($comment_header) 344 - ->appendChild($comment_form); 344 + ->setForm($comment_form); 345 345 $timeline->setQuoteTargetID('transaction-comments'); 346 346 $timeline->setQuoteRef($object_name); 347 347 }
+2 -2
src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
··· 56 56 57 57 $box = id(new PHUIObjectBoxView()) 58 58 ->setHeader($header) 59 - ->appendChild($table); 59 + ->setTable($table); 60 60 61 61 return $box; 62 62 } ··· 175 175 176 176 $object_box = id(new PHUIObjectBoxView()) 177 177 ->setHeader($header) 178 - ->appendChild($table); 178 + ->setTable($table); 179 179 180 180 $title = $application->getName(); 181 181
+1 -1
src/applications/multimeter/controller/MultimeterSampleController.php
··· 235 235 'Samples (%s - %s)', 236 236 phabricator_datetime($ago, $viewer), 237 237 phabricator_datetime($now, $viewer))) 238 - ->appendChild($table); 238 + ->setTable($table); 239 239 240 240 $crumbs = $this->buildApplicationCrumbs(); 241 241 $crumbs->addTextCrumb(
+1 -1
src/applications/oauthserver/panel/PhabricatorOAuthServerAuthorizationsSettingsPanel.php
··· 135 135 136 136 $panel = id(new PHUIObjectBoxView()) 137 137 ->setHeader($header) 138 - ->appendChild($table); 138 + ->setTable($table); 139 139 140 140 return $panel; 141 141 }
+1 -1
src/applications/owners/controller/PhabricatorOwnersDetailController.php
··· 129 129 ->setText(pht('Edit Package'))); 130 130 131 131 $panel->setHeader($header); 132 - $panel->appendChild($table); 132 + $panel->setTable($table); 133 133 134 134 $key = 'package/'.$package->getID(); 135 135 $this->setSideNavFilter($key);
+1 -1
src/applications/owners/controller/PhabricatorOwnersListController.php
··· 330 330 331 331 $panel = new PHUIObjectBoxView(); 332 332 $panel->setHeaderText($header); 333 - $panel->appendChild($table); 333 + $panel->setTable($table); 334 334 335 335 return $panel; 336 336 }
+1 -1
src/applications/people/controller/PhabricatorPeopleCreateController.php
··· 72 72 73 73 $box = id(new PHUIObjectBoxView()) 74 74 ->setHeaderText($title) 75 - ->appendChild($form); 75 + ->setForm($form); 76 76 77 77 return $this->buildApplicationPage( 78 78 array(
+2 -2
src/applications/people/controller/PhabricatorPeopleInviteSendController.php
··· 163 163 ->setErrors($confirm_errors) 164 164 ->setSeverity($severity)) 165 165 ->setHeaderText(pht('Confirm Invites')) 166 - ->appendChild($invite_table) 166 + ->setTable($invite_table) 167 167 ->appendChild($confirm_form); 168 168 } 169 169 ··· 203 203 ? pht('Revise Invites') 204 204 : pht('Invite Users')) 205 205 ->setFormErrors($errors) 206 - ->appendChild($form); 206 + ->setForm($form); 207 207 208 208 return $this->buildApplicationPage( 209 209 array(
+1 -1
src/applications/people/query/PhabricatorPeopleLogSearchEngine.php
··· 188 188 189 189 return id(new PHUIObjectBoxView()) 190 190 ->setHeaderText(pht('User Activity Logs')) 191 - ->appendChild($table); 191 + ->setTable($table); 192 192 } 193 193 }
+1 -1
src/applications/phortune/controller/PhortuneAccountEditController.php
··· 120 120 $box = id(new PHUIObjectBoxView()) 121 121 ->setHeaderText($title) 122 122 ->setValidationException($validation_exception) 123 - ->appendChild($form); 123 + ->setForm($form); 124 124 125 125 return $this->buildApplicationPage( 126 126 array(
+5 -5
src/applications/phortune/controller/PhortuneAccountViewController.php
··· 175 175 176 176 return id(new PHUIObjectBoxView()) 177 177 ->setHeader($header) 178 - ->appendChild($list); 178 + ->setObjectList($list); 179 179 } 180 180 181 181 private function buildInvoicesSection( ··· 207 207 208 208 return id(new PHUIObjectBoxView()) 209 209 ->setHeader($header) 210 - ->appendChild($table); 210 + ->setTable($table); 211 211 } 212 212 213 213 private function buildPurchaseHistorySection(PhortuneAccount $account) { ··· 258 258 259 259 return id(new PHUIObjectBoxView()) 260 260 ->setHeader($header) 261 - ->appendChild($table); 261 + ->setTable($table); 262 262 } 263 263 264 264 private function buildChargeHistorySection(PhortuneAccount $account) { ··· 302 302 303 303 return id(new PHUIObjectBoxView()) 304 304 ->setHeader($header) 305 - ->appendChild($table); 305 + ->setTable($table); 306 306 } 307 307 308 308 private function buildSubscriptionsSection(PhortuneAccount $account) { ··· 338 338 339 339 return id(new PHUIObjectBoxView()) 340 340 ->setHeader($header) 341 - ->appendChild($table); 341 + ->setTable($table); 342 342 } 343 343 344 344 protected function buildApplicationCrumbs() {
+1 -1
src/applications/phortune/controller/PhortuneCartCheckoutController.php
··· 113 113 $cart_box = id(new PHUIObjectBoxView()) 114 114 ->setFormErrors($errors) 115 115 ->setHeaderText(pht('Cart Contents')) 116 - ->appendChild($cart_table); 116 + ->setTable($cart_table); 117 117 118 118 $title = $cart->getName(); 119 119
+3 -3
src/applications/phortune/controller/PhortuneCartViewController.php
··· 146 146 147 147 $cart_box = id(new PHUIObjectBoxView()) 148 148 ->setHeader($header) 149 - ->appendChild($properties) 150 - ->appendChild($cart_table); 149 + ->addPropertyList($properties) 150 + ->setTable($cart_table); 151 151 152 152 if ($errors) { 153 153 $cart_box->setFormErrors($errors); ··· 180 180 181 181 $charges = id(new PHUIObjectBoxView()) 182 182 ->setHeaderText(pht('Charges')) 183 - ->appendChild($charges_table); 183 + ->setTable($charges_table); 184 184 185 185 $account = $cart->getAccount(); 186 186
+1 -1
src/applications/phortune/controller/PhortuneMerchantEditController.php
··· 164 164 $box = id(new PHUIObjectBoxView()) 165 165 ->setValidationException($validation_exception) 166 166 ->setHeaderText($title) 167 - ->appendChild($form); 167 + ->setForm($form); 168 168 169 169 return $this->buildApplicationPage( 170 170 array(
+1 -1
src/applications/phortune/controller/PhortuneMerchantInvoiceCreateController.php
··· 231 231 $box = id(new PHUIObjectBoxView()) 232 232 ->setHeaderText(pht('New Invoice')) 233 233 ->setFormErrors($errors) 234 - ->appendChild($form); 234 + ->setForm($form); 235 235 236 236 return $this->buildApplicationPage( 237 237 array(
+2 -2
src/applications/phortune/controller/PhortuneMerchantViewController.php
··· 50 50 51 51 $box = id(new PHUIObjectBoxView()) 52 52 ->setHeader($header) 53 - ->appendChild($properties); 53 + ->addPropertyList($properties); 54 54 55 55 $timeline = $this->buildTransactionTimeline( 56 56 $merchant, ··· 293 293 294 294 return id(new PHUIObjectBoxView()) 295 295 ->setHeader($header) 296 - ->appendChild($provider_list); 296 + ->setObjectList($provider_list); 297 297 } 298 298 299 299
+1 -1
src/applications/phortune/controller/PhortunePaymentMethodEditController.php
··· 65 65 66 66 $box = id(new PHUIObjectBoxView()) 67 67 ->setHeaderText(pht('Edit Payment Method')) 68 - ->appendChild($form); 68 + ->setForm($form); 69 69 70 70 $crumbs = $this->buildApplicationCrumbs(); 71 71 $crumbs->addTextCrumb($account->getName(), $account_uri);
+1 -1
src/applications/phortune/query/PhortuneCartSearchEngine.php
··· 229 229 230 230 return id(new PHUIObjectBoxView()) 231 231 ->setHeaderText($header) 232 - ->appendChild($table); 232 + ->setTable($table); 233 233 } 234 234 }
+1 -1
src/applications/phortune/query/PhortuneChargeSearchEngine.php
··· 129 129 130 130 return id(new PHUIObjectBoxView()) 131 131 ->setHeaderText(pht('Charges')) 132 - ->appendChild($table); 132 + ->setTable($table); 133 133 } 134 134 }
+1 -1
src/applications/phortune/query/PhortuneSubscriptionSearchEngine.php
··· 160 160 161 161 return id(new PHUIObjectBoxView()) 162 162 ->setHeaderText($header) 163 - ->appendChild($table); 163 + ->setTable($table); 164 164 } 165 165 }
+3 -2
src/applications/phriction/controller/PhrictionDiffController.php
··· 149 149 'a', 150 150 array( 151 151 'href' => $uri->alter('l', $l - 1)->alter('r', $r - 1), 152 - 'class' => 'button', 152 + 'class' => 'button simple', 153 153 ), 154 154 pht("\xC2\xAB Previous Change")); 155 155 } else { ··· 168 168 'a', 169 169 array( 170 170 'href' => $uri->alter('l', $l + 1)->alter('r', $r + 1), 171 - 'class' => 'button', 171 + 'class' => 'button simple', 172 172 ), 173 173 pht("Next Change \xC2\xBB")); 174 174 } else { ··· 206 206 207 207 $object_box = id(new PHUIObjectBoxView()) 208 208 ->setHeader($header) 209 + ->setCollapsed(true) 209 210 ->appendChild($output); 210 211 211 212 return $this->buildApplicationPage(
+2 -2
src/applications/repository/controller/PhabricatorRepositoryListController.php
··· 83 83 $header->addActionLink($button); 84 84 } 85 85 $panel->setHeader($header); 86 - $panel->appendChild($table); 86 + $panel->setTable($table); 87 87 88 88 $projects = id(new PhabricatorRepositoryArcanistProject())->loadAll(); 89 89 ··· 145 145 146 146 $project_panel = new PHUIObjectBoxView(); 147 147 $project_panel->setHeaderText(pht('Arcanist Projects')); 148 - $project_panel->appendChild($project_table); 148 + $project_panel->setTable($project_table); 149 149 150 150 $crumbs = $this->buildApplicationCrumbs(); 151 151 $crumbs->addTextCrumb(pht('Repository List'));
+1 -1
src/applications/settings/panel/PhabricatorActivitySettingsPanel.php
··· 56 56 57 57 $panel = id(new PHUIObjectBoxView()) 58 58 ->setHeaderText(pht('Account Activity Logs')) 59 - ->appendChild($table); 59 + ->setTable($table); 60 60 61 61 $pager_box = id(new PHUIBoxView()) 62 62 ->addMargin(PHUI::MARGIN_LARGE)
+1 -1
src/applications/settings/panel/PhabricatorEmailAddressesSettingsPanel.php
··· 147 147 $header->addActionLink($button); 148 148 } 149 149 $view->setHeader($header); 150 - $view->appendChild($table); 150 + $view->setTable($table); 151 151 152 152 return $view; 153 153 }
+2 -2
src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
··· 135 135 136 136 $linked_box = id(new PHUIObjectBoxView()) 137 137 ->setHeader($linked_head) 138 - ->appendChild($linked); 138 + ->setObjectList($linked); 139 139 140 140 $linkable_box = id(new PHUIObjectBoxView()) 141 141 ->setHeader($linkable_head) 142 - ->appendChild($linkable); 142 + ->setObjectList($linkable); 143 143 144 144 return array( 145 145 $linked_box,
+1 -1
src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php
··· 188 188 189 189 $box = id(new PHUIObjectBoxView()) 190 190 ->setHeader($header) 191 - ->appendChild($list); 191 + ->setObjectList($list); 192 192 193 193 return $box; 194 194 }
+1 -1
src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
··· 129 129 $header->addActionLink($create_button); 130 130 131 131 $panel->setHeader($header); 132 - $panel->appendChild($table); 132 + $panel->setTable($table); 133 133 134 134 return $panel; 135 135 }
+1 -1
src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php
··· 71 71 $header->addActionLink($upload_button); 72 72 73 73 $panel->setHeader($header); 74 - $panel->appendChild($table); 74 + $panel->setTable($table); 75 75 76 76 return $panel; 77 77 }
+1 -1
src/applications/settings/panel/PhabricatorSessionsSettingsPanel.php
··· 138 138 139 139 $panel = id(new PHUIObjectBoxView()) 140 140 ->setHeader($header) 141 - ->appendChild($table); 141 + ->setTable($table); 142 142 143 143 return $panel; 144 144 }
+1 -1
src/applications/settings/panel/PhabricatorTokensSettingsPanel.php
··· 91 91 92 92 $panel = id(new PHUIObjectBoxView()) 93 93 ->setHeader($header) 94 - ->appendChild($table); 94 + ->setTable($table); 95 95 96 96 return $panel; 97 97 }
+1 -1
src/applications/xhprof/view/PhabricatorXHProfProfileSymbolView.php
··· 117 117 118 118 $panel = new PHUIObjectBoxView(); 119 119 $panel->setHeaderText(pht('XHProf Profile')); 120 - $panel->appendChild($table); 120 + $panel->setTable($table); 121 121 122 122 return $panel->render(); 123 123 }
+1 -1
src/applications/xhprof/view/PhabricatorXHProfProfileTopLevelView.php
··· 134 134 } 135 135 136 136 $panel->setHeader($header); 137 - $panel->appendChild($table); 137 + $panel->setTable($table); 138 138 139 139 return $panel->render(); 140 140 }
+2 -2
src/view/phui/PHUIObjectBoxView.php
··· 150 150 $this->objectList = $list; 151 151 return $this; 152 152 } 153 - 153 + 154 154 public function setTable($table) { 155 155 $this->collapsed = true; 156 156 $this->table = $table; ··· 306 306 if ($this->color) { 307 307 $content->addClass('phui-object-box-'.$this->color); 308 308 } 309 - 309 + 310 310 if ($this->collapsed) { 311 311 $content->addClass('phui-object-box-collapsed'); 312 312 }
+1 -1
webroot/rsrc/css/aphront/table-view.css
··· 204 204 } 205 205 206 206 .aphront-table-view tr.highlighted { 207 - background: #fcf8e2; 207 + background: #fdf9e4; 208 208 } 209 209 210 210 .aphront-table-view tr.alt-highlighted {
+8
webroot/rsrc/css/phui/phui-object-box.css
··· 37 37 margin: 12px 0 0 0; 38 38 } 39 39 40 + .phui-object-box.phui-object-box-collapsed 41 + .phui-header-shell + .phui-info-view { 42 + margin: 0; 43 + border-radius: 0; 44 + border: 0; 45 + border-bottom: 1px solid {$thinblueborder}; 46 + } 47 + 40 48 .device-phone .phui-object-box { 41 49 margin: 8px 8px 0 8px; 42 50 }