@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add ObjectBox around Diffusion Binary Files
Summary: Add in more ObjectBoxes
Test Plan: Test aphlict.swf, see new menu and button to download.
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8305
+15
-7
+15
-7
src/applications/diffusion/controller/DiffusionBrowseFileController.php
+15
-7
src/applications/diffusion/controller/DiffusionBrowseFileController.php
···
871
871
}
872
872
873
873
private function buildBinaryCorpus($file_uri, $data) {
874
-
$properties = new PHUIPropertyListView();
875
874
876
-
$size = strlen($data);
877
-
$properties->addTextContent(
878
-
pht(
879
-
'This is a binary file. It is %s byte(s) in length.',
880
-
new PhutilNumber($size)));
875
+
$size = new PhutilNumber(strlen($data));
876
+
$text = pht('This is a binary file. It is %s byte(s) in length.', $size);
877
+
$text = id(new PHUIBoxView())
878
+
->addPadding(PHUI::PADDING_LARGE)
879
+
->appendChild($text);
881
880
882
-
return $properties;
881
+
$file = $this->renderFileButton($file_uri);
882
+
$header = id(new PHUIHeaderView())
883
+
->setHeader(pht('Details'))
884
+
->addActionLink($file);
885
+
886
+
$box = id(new PHUIObjectBoxView())
887
+
->setHeader($header)
888
+
->appendChild($text);
889
+
890
+
return $box;
883
891
}
884
892
885
893
private function buildBeforeResponse($before) {