@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert audit queries back to original behavior
Test Plan:
/ - didn't see all my commits
/owners/package/1/ - didn't see all package commits in Needs Attention
Reviewers: AnhNhan, epriestley
Reviewed By: epriestley
CC: aran, epriestley
Maniphest Tasks: T2582
Differential Revision: https://secure.phabricator.com/D5186
+4
-4
+2
-2
src/applications/audit/query/PhabricatorAuditCommitQuery.php
+2
-2
src/applications/audit/query/PhabricatorAuditCommitQuery.php
···
181
181
case self::STATUS_CONCERN:
182
182
$where[] = qsprintf(
183
183
$conn_r,
184
-
'c.auditStatus = %s',
184
+
'c.auditStatus = %d',
185
185
PhabricatorAuditCommitStatusConstants::CONCERN_RAISED);
186
186
break;
187
187
case self::STATUS_OPEN:
188
188
$where[] = qsprintf(
189
189
$conn_r,
190
-
'c.auditStatus IN (%Ls)',
190
+
'c.auditStatus IN (%Ld)',
191
191
PhabricatorAuditCommitStatusConstants::getOpenStatusConstants());
192
192
break;
193
193
case self::STATUS_ANY:
+1
-1
src/applications/directory/controller/PhabricatorDirectoryMainController.php
+1
-1
src/applications/directory/controller/PhabricatorDirectoryMainController.php
···
409
409
410
410
$query = new PhabricatorAuditCommitQuery();
411
411
$query->withAuthorPHIDs($phids);
412
-
$query->withStatus(PhabricatorAuditQuery::STATUS_OPEN);
412
+
$query->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN);
413
413
$query->needCommitData(true);
414
414
$query->setLimit(10);
415
415
+1
-1
src/applications/owners/controller/PhabricatorOwnersDetailController.php
+1
-1
src/applications/owners/controller/PhabricatorOwnersDetailController.php
···
142
142
143
143
$attention_query = id(new PhabricatorAuditCommitQuery())
144
144
->withPackagePHIDs(array($package->getPHID()))
145
-
->withStatus(PhabricatorAuditCommitQuery::STATUS_OPEN)
145
+
->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN)
146
146
->needCommitData(true)
147
147
->needAudits(true)
148
148
->setLimit(10);