@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove loadPhabricatorRepository from ReleephProject
Summary: Ref T3551. Repository is guaranteed if a product is loaded with modern mechanisms.
Test Plan:
- Edited a request.
- Called `releephwork.getbranchcommitmessage`.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T3551
Differential Revision: https://secure.phabricator.com/D8821
+3
-10
+2
-1
src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
+2
-1
src/applications/releeph/conduit/work/ConduitAPI_releephwork_getbranchcommitmessage_Method.php
···
55
55
56
56
// Not as customizable as a ReleephRequest's commit message. It doesn't
57
57
// really need to be.
58
+
// TODO: Yes it does, see FB-specific stuff below.
58
59
$commit_message = array();
59
60
$commit_message[] = $h_branch->getFullName();
60
61
$commit_message[] = $h_branch->getURI();
···
84
85
* @new-branch: <branch-name>
85
86
*
86
87
*/
87
-
$repo = $project->loadPhabricatorRepository();
88
+
$repo = $project->getRepository();
88
89
switch ($repo->getVersionControlSystem()) {
89
90
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
90
91
$commit_message[] = sprintf(
+1
-1
src/applications/releeph/controller/request/ReleephRequestEditController.php
+1
-1
src/applications/releeph/controller/request/ReleephRequestEditController.php
-8
src/applications/releeph/storage/ReleephProject.php
-8
src/applications/releeph/storage/ReleephProject.php
···
95
95
return $this->assertAttached($this->repository);
96
96
}
97
97
98
-
// TODO: Remove once everything uses ProjectQuery. Also, T603.
99
-
public function loadPhabricatorRepository() {
100
-
return $this->loadOneRelative(
101
-
new PhabricatorRepository(),
102
-
'phid',
103
-
'getRepositoryPHID');
104
-
}
105
-
106
98
public function getReleephFieldSelector() {
107
99
return new ReleephDefaultFieldSelector();
108
100
}