recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue with BuildLogs and web UI during builds

Summary:
Ref T9123. After recent changes, viewing a live build log from the web UI throws a CSRF exception.

Check `start` ("this object is an active log"), not `live` ("this log is open somewhere").

Test Plan: Will push / etc.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9123

Differential Revision: https://secure.phabricator.com/D14185

epriestley a5c41771 efaa8170

+1 -1
+1 -1
src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
··· 20 20 const ENCODING_TEXT = 'text'; 21 21 22 22 public function __destruct() { 23 - if ($this->live) { 23 + if ($this->start) { 24 24 $this->finalize($this->start); 25 25 } 26 26 }