@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide convenience method addTextCrumb() to PhabricatorCrumbsView
Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.
Test Plan:
- This was mostly automated, then I cleaned up a few unusual sites manually.
- Bunch of grep / randomly clicking around.
Reviewers: btrahan, chad
Reviewed By: btrahan
CC: hach-que, aran
Differential Revision: https://secure.phabricator.com/D7787
+304
-770
+2
-7
src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php
+2
-7
src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php
···
70
70
$dialog->appendChild($form);
71
71
72
72
$crumbs = $this->buildApplicationCrumbs();
73
-
$crumbs->addCrumb(
74
-
id(new PhabricatorCrumbView())
75
-
->setName(pht('Confirm Link'))
76
-
->setHref($panel_uri));
77
-
$crumbs->addCrumb(
78
-
id(new PhabricatorCrumbView())
79
-
->setName($provider->getProviderName()));
73
+
$crumbs->addTextCrumb(pht('Confirm Link'), $panel_uri);
74
+
$crumbs->addTextCrumb($provider->getProviderName());
80
75
81
76
return $this->buildApplicationPage(
82
77
array(
+2
-7
src/applications/auth/controller/PhabricatorAuthLinkController.php
+2
-7
src/applications/auth/controller/PhabricatorAuthLinkController.php
···
115
115
}
116
116
117
117
$crumbs = $this->buildApplicationCrumbs();
118
-
$crumbs->addCrumb(
119
-
id(new PhabricatorCrumbView())
120
-
->setName(pht('Link Account'))
121
-
->setHref($panel_uri));
122
-
$crumbs->addCrumb(
123
-
id(new PhabricatorCrumbView())
124
-
->setName($provider->getProviderName($name)));
118
+
$crumbs->addTextCrumb(pht('Link Account'), $panel_uri);
119
+
$crumbs->addTextCrumb($provider->getProviderName($name));
125
120
126
121
return $this->buildApplicationPage(
127
122
array(
+3
-11
src/applications/auth/controller/PhabricatorAuthLoginController.php
+3
-11
src/applications/auth/controller/PhabricatorAuthLoginController.php
···
202
202
$crumbs = $this->buildApplicationCrumbs();
203
203
204
204
if ($this->getRequest()->getUser()->isLoggedIn()) {
205
-
$crumbs->addCrumb(
206
-
id(new PhabricatorCrumbView())
207
-
->setName(pht('Link Account'))
208
-
->setHref($provider->getSettingsURI()));
205
+
$crumbs->addTextCrumb(pht('Link Account'), $provider->getSettingsURI());
209
206
} else {
210
-
$crumbs->addCrumb(
211
-
id(new PhabricatorCrumbView())
212
-
->setName(pht('Login'))
213
-
->setHref($this->getApplicationURI('start/')));
207
+
$crumbs->addTextCrumb(pht('Login'), $this->getApplicationURI('start/'));
214
208
}
215
209
216
-
$crumbs->addCrumb(
217
-
id(new PhabricatorCrumbView())
218
-
->setName($provider->getProviderName()));
210
+
$crumbs->addTextCrumb($provider->getProviderName());
219
211
220
212
return $this->buildApplicationPage(
221
213
array(
+3
-9
src/applications/auth/controller/PhabricatorAuthRegisterController.php
+3
-9
src/applications/auth/controller/PhabricatorAuthRegisterController.php
···
401
401
$crumbs = $this->buildApplicationCrumbs();
402
402
403
403
if ($is_setup) {
404
-
$crumbs->addCrumb(
405
-
id(new PhabricatorCrumbView())
406
-
->setName(pht('Setup Admin Account')));
404
+
$crumbs->addTextCrumb(pht('Setup Admin Account'));
407
405
$title = pht('Welcome to Phabricator');
408
406
} else {
409
-
$crumbs->addCrumb(
410
-
id(new PhabricatorCrumbView())
411
-
->setName(pht('Register')));
412
-
$crumbs->addCrumb(
413
-
id(new PhabricatorCrumbView())
414
-
->setName($provider->getProviderName()));
407
+
$crumbs->addTextCrumb(pht('Register'));
408
+
$crumbs->addTextCrumb($provider->getProviderName());
415
409
$title = pht('Phabricator Registration');
416
410
}
417
411
+1
-3
src/applications/auth/controller/PhabricatorAuthStartController.php
+1
-3
src/applications/auth/controller/PhabricatorAuthStartController.php
···
126
126
$login_message = phutil_safe_html($login_message);
127
127
128
128
$crumbs = $this->buildApplicationCrumbs();
129
-
$crumbs->addCrumb(
130
-
id(new PhabricatorCrumbView())
131
-
->setName(pht('Login')));
129
+
$crumbs->addTextCrumb(pht('Login'));
132
130
133
131
return $this->buildApplicationPage(
134
132
array(
+1
-3
src/applications/auth/controller/PhabricatorEmailLoginController.php
+1
-3
src/applications/auth/controller/PhabricatorEmailLoginController.php
···
133
133
->setError($e_captcha));
134
134
135
135
$crumbs = $this->buildApplicationCrumbs();
136
-
$crumbs->addCrumb(
137
-
id(new PhabricatorCrumbView())
138
-
->setName(pht('Reset Password')));
136
+
$crumbs->addTextCrumb(pht('Reset Password'));
139
137
140
138
$dialog = new AphrontDialogView();
141
139
$dialog->setUser($request->getUser());
+1
-3
src/applications/auth/controller/PhabricatorEmailVerificationController.php
+1
-3
src/applications/auth/controller/PhabricatorEmailVerificationController.php
+1
-3
src/applications/auth/controller/config/PhabricatorAuthEditController.php
+1
-3
src/applications/auth/controller/config/PhabricatorAuthEditController.php
+1
-3
src/applications/auth/controller/config/PhabricatorAuthListController.php
+1
-3
src/applications/auth/controller/config/PhabricatorAuthListController.php
···
86
86
pht('Add Authentication Provider'))));
87
87
88
88
$crumbs = $this->buildApplicationCrumbs();
89
-
$crumbs->addCrumb(
90
-
id(new PhabricatorCrumbView())
91
-
->setName(pht('Auth Providers')));
89
+
$crumbs->addTextCrumb(pht('Auth Providers'));
92
90
93
91
$config_name = 'auth.email-domains';
94
92
$config_href = '/config/edit/'.$config_name.'/';
+1
-3
src/applications/auth/controller/config/PhabricatorAuthNewController.php
+1
-3
src/applications/auth/controller/config/PhabricatorAuthNewController.php
+1
-4
src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
+1
-4
src/applications/chatlog/controller/PhabricatorChatLogChannelListController.php
···
23
23
24
24
$crumbs = $this
25
25
->buildApplicationCrumbs()
26
-
->addCrumb(
27
-
id(new PhabricatorCrumbView())
28
-
->setName(pht('Channel List'))
29
-
->setHref($this->getApplicationURI()));
26
+
->addTextCrumb(pht('Channel List'), $this->getApplicationURI());
30
27
31
28
return $this->buildApplicationPage(
32
29
array(
+1
-4
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
+1
-4
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
···
183
183
184
184
$crumbs = $this
185
185
->buildApplicationCrumbs()
186
-
->addCrumb(
187
-
id(new PhabricatorCrumbView())
188
-
->setName($channel->getChannelName())
189
-
->setHref($uri));
186
+
->addTextCrumb($channel->getChannelName(), $uri);
190
187
191
188
$form = id(new AphrontFormView())
192
189
->setUser($user)
+3
-9
src/applications/conduit/controller/PhabricatorConduitAPIController.php
+3
-9
src/applications/conduit/controller/PhabricatorConduitAPIController.php
···
380
380
381
381
$method_uri = $this->getApplicationURI('method/'.$method.'/');
382
382
383
-
$crumbs = $this->buildApplicationCrumbs();
384
-
$crumbs
385
-
->addCrumb(
386
-
id(new PhabricatorCrumbView())
387
-
->setName($method)
388
-
->setHref($method_uri))
389
-
->addCrumb(
390
-
id(new PhabricatorCrumbView())
391
-
->setName(pht('Call')));
383
+
$crumbs = $this->buildApplicationCrumbs()
384
+
->addTextCrumb($method, $method_uri)
385
+
->addTextCrumb(pht('Call'));
392
386
393
387
return $this->buildApplicationPage(
394
388
array(
+1
-3
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+1
-3
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
···
116
116
->setForm($form);
117
117
118
118
$crumbs = $this->buildApplicationCrumbs();
119
-
$crumbs->addCrumb(
120
-
id(new PhabricatorCrumbView())
121
-
->setName($method->getAPIMethodName()));
119
+
$crumbs->addTextCrumb($method->getAPIMethodName());
122
120
123
121
return $this->buildApplicationPage(
124
122
array(
+1
-3
src/applications/conduit/controller/PhabricatorConduitLogController.php
+1
-3
src/applications/conduit/controller/PhabricatorConduitLogController.php
···
40
40
$table = $this->renderCallTable($calls, $conns);
41
41
42
42
$crumbs = $this->buildApplicationCrumbs();
43
-
$crumbs->addCrumb(
44
-
id(new PhabricatorCrumbView())
45
-
->setName(pht('Call Logs')));
43
+
$crumbs->addTextCrumb(pht('Call Logs'));
46
44
47
45
return $this->buildApplicationPage(
48
46
array(
+1
-3
src/applications/conduit/controller/PhabricatorConduitTokenController.php
+1
-3
src/applications/conduit/controller/PhabricatorConduitTokenController.php
···
49
49
->appendRemarkupInstructions($post_instructions);
50
50
51
51
$crumbs = $this->buildApplicationCrumbs();
52
-
$crumbs->addCrumb(
53
-
id(new PhabricatorCrumbView())
54
-
->setName(pht('Install Certificate')));
52
+
$crumbs->addTextCrumb(pht('Install Certificate'));
55
53
56
54
$object_box = id(new PHUIObjectBoxView())
57
55
->setHeaderText(pht('Certificate Token'))
+1
-3
src/applications/config/controller/PhabricatorConfigAllController.php
+1
-3
src/applications/config/controller/PhabricatorConfigAllController.php
+3
-12
src/applications/config/controller/PhabricatorConfigEditController.php
+3
-12
src/applications/config/controller/PhabricatorConfigEditController.php
···
199
199
->setForm($form);
200
200
201
201
$crumbs = $this->buildApplicationCrumbs();
202
-
$crumbs->addCrumb(
203
-
id(new PhabricatorCrumbView())
204
-
->setName(pht('Config'))
205
-
->setHref($this->getApplicationURI()));
202
+
$crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
206
203
207
204
if ($group) {
208
-
$crumbs->addCrumb(
209
-
id(new PhabricatorCrumbView())
210
-
->setName($group->getName())
211
-
->setHref($group_uri));
205
+
$crumbs->addTextCrumb($group->getName(), $group_uri);
212
206
}
213
207
214
-
$crumbs->addCrumb(
215
-
id(new PhabricatorCrumbView())
216
-
->setName($this->key)
217
-
->setHref('/config/edit/'.$this->key));
208
+
$crumbs->addTextCrumb($this->key, '/config/edit/'.$this->key);
218
209
219
210
$xactions = id(new PhabricatorConfigTransactionQuery())
220
211
->withObjectPHIDs(array($config_entry->getPHID()))
+2
-8
src/applications/config/controller/PhabricatorConfigGroupController.php
+2
-8
src/applications/config/controller/PhabricatorConfigGroupController.php
···
28
28
29
29
$crumbs = $this
30
30
->buildApplicationCrumbs()
31
-
->addCrumb(
32
-
id(new PhabricatorCrumbView())
33
-
->setName(pht('Config'))
34
-
->setHref($this->getApplicationURI()))
35
-
->addCrumb(
36
-
id(new PhabricatorCrumbView())
37
-
->setName($options->getName())
38
-
->setHref($this->getApplicationURI()));
31
+
->addTextCrumb(pht('Config'), $this->getApplicationURI())
32
+
->addTextCrumb($options->getName(), $this->getApplicationURI());
39
33
40
34
return $this->buildApplicationPage(
41
35
array(
+1
-4
src/applications/config/controller/PhabricatorConfigIssueListController.php
+1
-4
src/applications/config/controller/PhabricatorConfigIssueListController.php
···
30
30
31
31
$crumbs = $this
32
32
->buildApplicationCrumbs($nav)
33
-
->addCrumb(
34
-
id(new PhabricatorCrumbView())
35
-
->setName(pht('Setup'))
36
-
->setHref($this->getApplicationURI('issue/')));
33
+
->addTextCrumb(pht('Setup'), $this->getApplicationURI('issue/'));
37
34
38
35
$nav->setCrumbs($crumbs);
39
36
+2
-8
src/applications/config/controller/PhabricatorConfigIssueViewController.php
+2
-8
src/applications/config/controller/PhabricatorConfigIssueViewController.php
···
38
38
39
39
$crumbs = $this
40
40
->buildApplicationCrumbs()
41
-
->addCrumb(
42
-
id(new PhabricatorCrumbView())
43
-
->setName(pht('Setup Issues'))
44
-
->setHref($this->getApplicationURI('issue/')))
45
-
->addCrumb(
46
-
id(new PhabricatorCrumbView())
47
-
->setName($title)
48
-
->setHref($request->getRequestURI()));
41
+
->addTextCrumb(pht('Setup Issues'), $this->getApplicationURI('issue/'))
42
+
->addTextCrumb($title, $request->getRequestURI());
49
43
50
44
return $this->buildApplicationPage(
51
45
array(
+1
-4
src/applications/config/controller/PhabricatorConfigListController.php
+1
-4
src/applications/config/controller/PhabricatorConfigListController.php
···
26
26
27
27
$crumbs = $this
28
28
->buildApplicationCrumbs()
29
-
->addCrumb(
30
-
id(new PhabricatorCrumbView())
31
-
->setName(pht('Config'))
32
-
->setHref($this->getApplicationURI()));
29
+
->addTextCrumb(pht('Config'), $this->getApplicationURI());
33
30
34
31
$nav->setCrumbs($crumbs);
35
32
+3
-10
src/applications/countdown/controller/PhabricatorCountdownEditController.php
+3
-10
src/applications/countdown/controller/PhabricatorCountdownEditController.php
···
90
90
$cancel_uri = '/countdown/';
91
91
if ($countdown->getID()) {
92
92
$cancel_uri = '/countdown/'.$countdown->getID().'/';
93
-
$crumbs->addCrumb(
94
-
id(new PhabricatorCrumbView())
95
-
->setName('C'.$countdown->getID())
96
-
->setHref($cancel_uri));
97
-
$crumbs->addCrumb(
98
-
id(new PhabricatorCrumbView())
99
-
->setName(pht('Edit')));
93
+
$crumbs->addTextCrumb('C'.$countdown->getID(), $cancel_uri);
94
+
$crumbs->addTextCrumb(pht('Edit'));
100
95
$submit_label = pht('Save Changes');
101
96
} else {
102
-
$crumbs->addCrumb(
103
-
id(new PhabricatorCrumbView())
104
-
->setName(pht('Create Countdown')));
97
+
$crumbs->addTextCrumb(pht('Create Countdown'));
105
98
$submit_label = pht('Create Countdown');
106
99
}
107
100
+1
-3
src/applications/countdown/controller/PhabricatorCountdownViewController.php
+1
-3
src/applications/countdown/controller/PhabricatorCountdownViewController.php
+1
-3
src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
+1
-3
src/applications/daemon/controller/PhabricatorDaemonConsoleController.php
···
211
211
$queued_panel->setNoBackground();
212
212
213
213
$crumbs = $this->buildApplicationCrumbs();
214
-
$crumbs->addCrumb(
215
-
id(new PhabricatorCrumbView())
216
-
->setName(pht('Console')));
214
+
$crumbs->addTextCrumb(pht('Console'));
217
215
218
216
$nav = $this->buildSideNavView();
219
217
$nav->selectFilter('/');
+5
-8
src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php
+5
-8
src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php
···
29
29
30
30
$daemon_id = $event->getLogID();
31
31
32
-
$crumbs = $this->buildApplicationCrumbs();
33
-
$crumbs->addCrumb(
34
-
id(new PhabricatorCrumbView())
35
-
->setName(pht('Daemon %s', $daemon_id))
36
-
->setHref($this->getApplicationURI("log/{$daemon_id}/")));
37
-
$crumbs->addCrumb(
38
-
id(new PhabricatorCrumbView())
39
-
->setName(pht('Event %s', $event->getID())));
32
+
$crumbs = $this->buildApplicationCrumbs()
33
+
->addTextCrumb(
34
+
pht('Daemon %s', $daemon_id),
35
+
$this->getApplicationURI("log/{$daemon_id}/"))
36
+
->addTextCrumb(pht('Event %s', $event->getID()));
40
37
41
38
42
39
return $this->buildApplicationPage(
+1
-3
src/applications/daemon/controller/PhabricatorDaemonLogListController.php
+1
-3
src/applications/daemon/controller/PhabricatorDaemonLogListController.php
···
19
19
$daemon_table->setDaemonLogs($logs);
20
20
21
21
$crumbs = $this->buildApplicationCrumbs();
22
-
$crumbs->addCrumb(
23
-
id(new PhabricatorCrumbView())
24
-
->setName(pht('All Daemons')));
22
+
$crumbs->addTextCrumb(pht('All Daemons'));
25
23
26
24
$nav = $this->buildSideNavView();
27
25
$nav->selectFilter('log');
+1
-3
src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
+1
-3
src/applications/daemon/controller/PhabricatorDaemonLogViewController.php
···
26
26
$log->getID());
27
27
28
28
$crumbs = $this->buildApplicationCrumbs();
29
-
$crumbs->addCrumb(
30
-
id(new PhabricatorCrumbView())
31
-
->setName(pht('Daemon %s', $log->getID())));
29
+
$crumbs->addTextCrumb(pht('Daemon %s', $log->getID()));
32
30
33
31
$header = id(new PHUIHeaderView())
34
32
->setHeader($log->getDaemon());
+1
-3
src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
+1
-3
src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php
+1
-3
src/applications/differential/controller/DifferentialDiffCreateController.php
+1
-3
src/applications/differential/controller/DifferentialDiffCreateController.php
+1
-3
src/applications/differential/controller/DifferentialDiffViewController.php
+1
-3
src/applications/differential/controller/DifferentialDiffViewController.php
···
146
146
->setUser($request->getUser());
147
147
148
148
$crumbs = $this->buildApplicationCrumbs();
149
-
$crumbs->addCrumb(
150
-
id(new PhabricatorCrumbView())
151
-
->setName(pht('Diff %d', $diff->getID())));
149
+
$crumbs->addTextCrumb(pht('Diff %d', $diff->getID()));
152
150
153
151
return $this->buildApplicationPage(
154
152
array(
+7
-11
src/applications/differential/controller/DifferentialRevisionEditController.php
+7
-11
src/applications/differential/controller/DifferentialRevisionEditController.php
···
153
153
if ($revision->getID()) {
154
154
if ($diff) {
155
155
$title = pht('Update Differential Revision');
156
-
$crumbs->addCrumb(
157
-
id(new PhabricatorCrumbView())
158
-
->setName('D'.$revision->getID())
159
-
->setHref('/differential/diff/'.$diff->getID().'/'));
156
+
$crumbs->addTextCrumb(
157
+
'D'.$revision->getID(),
158
+
'/differential/diff/'.$diff->getID().'/');
160
159
} else {
161
160
$title = pht('Edit Differential Revision');
162
-
$crumbs->addCrumb(
163
-
id(new PhabricatorCrumbView())
164
-
->setName('D'.$revision->getID())
165
-
->setHref('/D'.$revision->getID()));
161
+
$crumbs->addTextCrumb(
162
+
'D'.$revision->getID(),
163
+
'/D'.$revision->getID());
166
164
}
167
165
} else {
168
166
$title = pht('Create New Differential Revision');
···
173
171
->setFormError($error_view)
174
172
->setForm($form);
175
173
176
-
$crumbs->addCrumb(
177
-
id(new PhabricatorCrumbView())
178
-
->setName($title));
174
+
$crumbs->addTextCrumb($title);
179
175
180
176
return $this->buildApplicationPage(
181
177
array(
+1
-4
src/applications/differential/controller/DifferentialRevisionViewController.php
+1
-4
src/applications/differential/controller/DifferentialRevisionViewController.php
···
421
421
);
422
422
423
423
$crumbs = $this->buildApplicationCrumbs();
424
-
$crumbs->addCrumb(
425
-
id(new PhabricatorCrumbView())
426
-
->setName($object_id)
427
-
->setHref('/'.$object_id));
424
+
$crumbs->addTextCrumb($object_id, '/'.$object_id);
428
425
429
426
$prefs = $user->loadPreferences();
430
427
+1
-3
src/applications/diffusion/controller/DiffusionLintController.php
+1
-3
src/applications/diffusion/controller/DiffusionLintController.php
···
139
139
if ($this->diffusionRequest) {
140
140
$title[] = $drequest->getCallsign();
141
141
} else {
142
-
$crumbs->addCrumb(
143
-
id(new PhabricatorCrumbView())
144
-
->setName(pht('All Lint')));
142
+
$crumbs->addTextCrumb(pht('All Lint'));
145
143
}
146
144
147
145
if ($this->diffusionRequest) {
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryCreateController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
···
59
59
$content = array();
60
60
61
61
$crumbs = $this->buildApplicationCrumbs();
62
-
$crumbs->addCrumb(
63
-
id(new PhabricatorCrumbView())
64
-
->setName(pht('Edit Actions')));
62
+
$crumbs->addTextCrumb(pht('Edit Actions'));
65
63
66
64
$title = pht('Edit Actions (%s)', $repository->getName());
67
65
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php
···
88
88
$content = array();
89
89
90
90
$crumbs = $this->buildApplicationCrumbs();
91
-
$crumbs->addCrumb(
92
-
id(new PhabricatorCrumbView())
93
-
->setName(pht('Edit Branches')));
91
+
$crumbs->addTextCrumb(pht('Edit Branches'));
94
92
95
93
$title = pht('Edit Branches (%s)', $repository->getName());
96
94
+3
-11
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
+3
-11
src/applications/diffusion/controller/DiffusionRepositoryEditController.php
···
11
11
$repo_uri = $this->getRepositoryControllerURI($repository, '');
12
12
$edit_uri = $this->getRepositoryControllerURI($repository, 'edit/');
13
13
14
-
$crumbs->addCrumb(
15
-
id(new PhabricatorCrumbView())
16
-
->setName('r'.$repository->getCallsign())
17
-
->setHref($repo_uri));
14
+
$crumbs->addTextCrumb('r'.$repository->getCallsign(), $repo_uri);
18
15
19
16
if ($is_main) {
20
-
$crumbs->addCrumb(
21
-
id(new PhabricatorCrumbView())
22
-
->setName(pht('Edit Repository')));
17
+
$crumbs->addTextCrumb(pht('Edit Repository'));
23
18
} else {
24
-
$crumbs->addCrumb(
25
-
id(new PhabricatorCrumbView())
26
-
->setName(pht('Edit'))
27
-
->setHref($edit_uri));
19
+
$crumbs->addTextCrumb(pht('Edit'), $edit_uri);
28
20
}
29
21
}
30
22
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
+2
-6
src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
+2
-6
src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
···
67
67
}
68
68
69
69
$crumbs = $this->buildApplicationCrumbs();
70
-
$crumbs->addCrumb(
71
-
id(new PhabricatorCrumbView())
72
-
->setName(pht('Edit Hosting')));
70
+
$crumbs->addTextCrumb(pht('Edit Hosting'));
73
71
74
72
$title = pht('Edit Hosting (%s)', $repository->getName());
75
73
···
172
170
}
173
171
174
172
$crumbs = $this->buildApplicationCrumbs();
175
-
$crumbs->addCrumb(
176
-
id(new PhabricatorCrumbView())
177
-
->setName(pht('Edit Protocols')));
173
+
$crumbs->addTextCrumb(pht('Edit Protocols'));
178
174
179
175
$title = pht('Edit Protocols (%s)', $repository->getName());
180
176
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditLocalController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditPolicyController.php
···
67
67
$content = array();
68
68
69
69
$crumbs = $this->buildApplicationCrumbs();
70
-
$crumbs->addCrumb(
71
-
id(new PhabricatorCrumbView())
72
-
->setName(pht('Edit Policies')));
70
+
$crumbs->addTextCrumb(pht('Edit Policies'));
73
71
74
72
$title = pht('Edit Policies (%s)', $repository->getName());
75
73
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryEditSubversionController.php
···
70
70
$content = array();
71
71
72
72
$crumbs = $this->buildApplicationCrumbs();
73
-
$crumbs->addCrumb(
74
-
id(new PhabricatorCrumbView())
75
-
->setName(pht('Edit Subversion Info')));
73
+
$crumbs->addTextCrumb(pht('Edit Subversion Info'));
76
74
77
75
$title = pht('Edit Subversion Info (%s)', $repository->getName());
78
76
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryNewController.php
+1
-3
src/applications/diffusion/controller/DiffusionRepositoryNewController.php
···
67
67
->addCancelButton($this->getApplicationURI()));
68
68
69
69
$crumbs = $this->buildApplicationCrumbs();
70
-
$crumbs->addCrumb(
71
-
id(new PhabricatorCrumbView())
72
-
->setName(pht('New Repository')));
70
+
$crumbs->addTextCrumb(pht('New Repository'));
73
71
74
72
$form_box = id(new PHUIObjectBoxView())
75
73
->setHeaderText(pht('Create or Import Repository'))
+4
-7
src/applications/diviner/controller/DivinerAtomController.php
+4
-7
src/applications/diviner/controller/DivinerAtomController.php
···
59
59
$atom = $symbol->getAtom();
60
60
$crumbs = $this->buildApplicationCrumbs();
61
61
62
-
$crumbs->addCrumb(
63
-
id(new PhabricatorCrumbView())
64
-
->setName($book->getShortTitle())
65
-
->setHref('/book/'.$book->getName().'/'));
62
+
$crumbs->addTextCrumb(
63
+
$book->getShortTitle(),
64
+
'/book/'.$book->getName().'/');
66
65
67
66
$atom_short_title = $atom->getDocblockMetaValue(
68
67
'short',
69
68
$symbol->getTitle());
70
69
71
-
$crumbs->addCrumb(
72
-
id(new PhabricatorCrumbView())
73
-
->setName($atom_short_title));
70
+
$crumbs->addTextCrumb($atom_short_title);
74
71
75
72
$header = id(new PHUIHeaderView())
76
73
->setHeader($this->renderFullSignature($symbol))
+3
-4
src/applications/diviner/controller/DivinerBookController.php
+3
-4
src/applications/diviner/controller/DivinerBookController.php
···
27
27
28
28
$crumbs = $this->buildApplicationCrumbs();
29
29
30
-
$crumbs->addCrumb(
31
-
id(new PhabricatorCrumbView())
32
-
->setName($book->getShortTitle())
33
-
->setHref('/book/'.$book->getName().'/'));
30
+
$crumbs->addTextCrumb(
31
+
$book->getShortTitle(),
32
+
'/book/'.$book->getName().'/');
34
33
35
34
$header = id(new PHUIHeaderView())
36
35
->setHeader($book->getTitle())
+1
-3
src/applications/diviner/controller/DivinerLegacyController.php
+1
-3
src/applications/diviner/controller/DivinerLegacyController.php
···
43
43
}
44
44
45
45
$crumbs = $this->buildApplicationCrumbs();
46
-
$crumbs->addCrumb(
47
-
id(new PhabricatorCrumbView())
48
-
->setName(pht('Documentation')));
46
+
$crumbs->addTextCrumb(pht('Documentation'));
49
47
50
48
$header = id(new PHUIHeaderView())
51
49
->setHeader(pht('Documentation'));
+2
-6
src/applications/drydock/controller/DrydockBlueprintEditController.php
+2
-6
src/applications/drydock/controller/DrydockBlueprintEditController.php
···
80
80
81
81
$title = pht('Edit Blueprint');
82
82
$header = pht('Edit Blueprint %d', $blueprint->getID());
83
-
$crumbs->addCrumb(
84
-
id(new PhabricatorCrumbView())
85
-
->setName(pht('Blueprint %d', $blueprint->getID())));
86
-
$crumbs->addCrumb(
87
-
id(new PhabricatorCrumbView())
88
-
->setName(pht('Edit')));
83
+
$crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
84
+
$crumbs->addTextCrumb(pht('Edit'));
89
85
90
86
if ($request->isAjax()) {
91
87
$dialog = id(new AphrontDialogView())
+1
-4
src/applications/drydock/controller/DrydockBlueprintListController.php
+1
-4
src/applications/drydock/controller/DrydockBlueprintListController.php
···
18
18
$blueprint_list = $this->buildBlueprintListView($blueprints);
19
19
20
20
$crumbs = $this->buildApplicationCrumbs();
21
-
$crumbs->addCrumb(
22
-
id(new PhabricatorCrumbView())
23
-
->setName($title)
24
-
->setHref($request->getRequestURI()));
21
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
25
22
26
23
$crumbs->addAction(
27
24
id(new PHUIListItemView())
+1
-3
src/applications/drydock/controller/DrydockBlueprintViewController.php
+1
-3
src/applications/drydock/controller/DrydockBlueprintViewController.php
···
42
42
43
43
$crumbs = $this->buildApplicationCrumbs();
44
44
$crumbs->setActionList($actions);
45
-
$crumbs->addCrumb(
46
-
id(new PhabricatorCrumbView())
47
-
->setName(pht('Blueprint %d', $blueprint->getID())));
45
+
$crumbs->addTextCrumb(pht('Blueprint %d', $blueprint->getID()));
48
46
49
47
$object_box = id(new PHUIObjectBoxView())
50
48
->setHeader($header)
+1
-4
src/applications/drydock/controller/DrydockLeaseListController.php
+1
-4
src/applications/drydock/controller/DrydockLeaseListController.php
···
31
31
));
32
32
33
33
$crumbs = $this->buildApplicationCrumbs();
34
-
$crumbs->addCrumb(
35
-
id(new PhabricatorCrumbView())
36
-
->setName($title)
37
-
->setHref($request->getRequestURI()));
34
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
38
35
$nav->setCrumbs($crumbs);
39
36
40
37
return $this->buildApplicationPage(
+1
-4
src/applications/drydock/controller/DrydockLeaseViewController.php
+1
-4
src/applications/drydock/controller/DrydockLeaseViewController.php
···
40
40
41
41
$crumbs = $this->buildApplicationCrumbs();
42
42
$crumbs->setActionList($actions);
43
-
$crumbs->addCrumb(
44
-
id(new PhabricatorCrumbView())
45
-
->setName($title)
46
-
->setHref($lease_uri));
43
+
$crumbs->addTextCrumb($title, $lease_uri);
47
44
48
45
$object_box = id(new PHUIObjectBoxView())
49
46
->setHeader($header)
+1
-4
src/applications/drydock/controller/DrydockLogController.php
+1
-4
src/applications/drydock/controller/DrydockLogController.php
···
43
43
));
44
44
45
45
$crumbs = $this->buildApplicationCrumbs();
46
-
$crumbs->addCrumb(
47
-
id(new PhabricatorCrumbView())
48
-
->setName($title)
49
-
->setHref($this->getApplicationURI('/logs/')));
46
+
$crumbs->addTextCrumb($title, $this->getApplicationURI('/logs/'));
50
47
$nav->setCrumbs($crumbs);
51
48
52
49
return $this->buildApplicationPage(
+1
-4
src/applications/drydock/controller/DrydockResourceListController.php
+1
-4
src/applications/drydock/controller/DrydockResourceListController.php
···
20
20
$resource_list = $this->buildResourceListView($resources);
21
21
22
22
$crumbs = $this->buildApplicationCrumbs();
23
-
$crumbs->addCrumb(
24
-
id(new PhabricatorCrumbView())
25
-
->setName($title)
26
-
->setHref($request->getRequestURI()));
23
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
27
24
28
25
$nav = $this->buildSideNav('resource');
29
26
$nav->setCrumbs($crumbs);
+1
-3
src/applications/drydock/controller/DrydockResourceViewController.php
+1
-3
src/applications/drydock/controller/DrydockResourceViewController.php
···
49
49
50
50
$crumbs = $this->buildApplicationCrumbs();
51
51
$crumbs->setActionList($actions);
52
-
$crumbs->addCrumb(
53
-
id(new PhabricatorCrumbView())
54
-
->setName(pht('Resource %d', $resource->getID())));
52
+
$crumbs->addTextCrumb(pht('Resource %d', $resource->getID()));
55
53
56
54
$object_box = id(new PHUIObjectBoxView())
57
55
->setHeader($header)
+1
-3
src/applications/feed/controller/PhabricatorFeedDetailController.php
+1
-3
src/applications/feed/controller/PhabricatorFeedDetailController.php
···
30
30
$feed_view = phutil_tag_div('phabricator-feed-frame', $feed_view);
31
31
32
32
$crumbs = $this->buildApplicationCrumbs();
33
-
$crumbs->addCrumb(
34
-
id(new PhabricatorCrumbView())
35
-
->setName($title));
33
+
$crumbs->addTextCrumb($title);
36
34
37
35
38
36
return $this->buildApplicationPage(
+3
-4
src/applications/files/controller/PhabricatorFileInfoController.php
+3
-4
src/applications/files/controller/PhabricatorFileInfoController.php
···
47
47
$timeline = $this->buildTransactionView($file, $xactions);
48
48
$crumbs = $this->buildApplicationCrumbs();
49
49
$crumbs->setActionList($actions);
50
-
$crumbs->addCrumb(
51
-
id(new PhabricatorCrumbView())
52
-
->setName('F'.$file->getID())
53
-
->setHref($this->getApplicationURI("/info/{$phid}/")));
50
+
$crumbs->addTextCrumb(
51
+
'F'.$file->getID(),
52
+
$this->getApplicationURI("/info/{$phid}/"));
54
53
55
54
$object_box = id(new PHUIObjectBoxView())
56
55
->setHeader($header);
+1
-4
src/applications/files/controller/PhabricatorFileUploadController.php
+1
-4
src/applications/files/controller/PhabricatorFileUploadController.php
···
60
60
->appendChild($instructions);
61
61
62
62
$crumbs = $this->buildApplicationCrumbs();
63
-
$crumbs->addCrumb(
64
-
id(new PhabricatorCrumbView())
65
-
->setName(pht('Upload'))
66
-
->setHref($request->getRequestURI()));
63
+
$crumbs->addTextCrumb(pht('Upload'), $request->getRequestURI());
67
64
68
65
$title = pht('Upload File');
69
66
+1
-3
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+1
-3
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
···
37
37
$this->buildPropertyLists($box, $build, $actions);
38
38
39
39
$crumbs = $this->buildApplicationCrumbs();
40
-
$crumbs->addCrumb(
41
-
id(new PhabricatorCrumbView())
42
-
->setName($title));
40
+
$crumbs->addTextCrumb($title);
43
41
44
42
$build_targets = id(new HarbormasterBuildTargetQuery())
45
43
->setViewer($viewer)
+3
-10
src/applications/harbormaster/controller/HarbormasterBuildableEditController.php
+3
-10
src/applications/harbormaster/controller/HarbormasterBuildableEditController.php
···
119
119
120
120
$crumbs = $this->buildApplicationCrumbs();
121
121
if ($is_new) {
122
-
$crumbs->addCrumb(
123
-
id(new PhabricatorCrumbView())
124
-
->setName(pht('New Buildable')));
122
+
$crumbs->addTextCrumb(pht('New Buildable'));
125
123
} else {
126
124
$id = $buildable->getID();
127
-
$crumbs->addCrumb(
128
-
id(new PhabricatorCrumbView())
129
-
->setName("B{$id}")
130
-
->setHref("/B{$id}"));
131
-
$crumbs->addCrumb(
132
-
id(new PhabricatorCrumbView())
133
-
->setName(pht('Edit')));
125
+
$crumbs->addTextCrumb("B{$id}", "/B{$id}");
126
+
$crumbs->addTextCrumb(pht('Edit'));
134
127
}
135
128
136
129
return $this->buildApplicationPage(
+1
-3
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
+1
-3
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
···
94
94
$this->buildPropertyLists($box, $buildable, $actions);
95
95
96
96
$crumbs = $this->buildApplicationCrumbs();
97
-
$crumbs->addCrumb(
98
-
id(new PhabricatorCrumbView())
99
-
->setName("B{$id}"));
97
+
$crumbs->addTextCrumb("B{$id}");
100
98
101
99
return $this->buildApplicationPage(
102
100
array(
+3
-4
src/applications/harbormaster/controller/HarbormasterPlanController.php
+3
-4
src/applications/harbormaster/controller/HarbormasterPlanController.php
···
5
5
public function buildApplicationCrumbs() {
6
6
$crumbs = parent::buildApplicationCrumbs();
7
7
8
-
$crumbs->addCrumb(
9
-
id(new PhabricatorCrumbView())
10
-
->setName(pht('Build Plans'))
11
-
->setHref($this->getApplicationURI('plan/')));
8
+
$crumbs->addTextCrumb(
9
+
pht('Build Plans'),
10
+
$this->getApplicationURI('plan/'));
12
11
13
12
return $crumbs;
14
13
}
+5
-10
src/applications/harbormaster/controller/HarbormasterPlanEditController.php
+5
-10
src/applications/harbormaster/controller/HarbormasterPlanEditController.php
···
93
93
94
94
$crumbs = $this->buildApplicationCrumbs();
95
95
if ($is_new) {
96
-
$crumbs->addCrumb(
97
-
id(new PhabricatorCrumbView())
98
-
->setName(pht('New Build Plan')));
96
+
$crumbs->addTextCrumb(pht('New Build Plan'));
99
97
} else {
100
98
$id = $plan->getID();
101
-
$crumbs->addCrumb(
102
-
id(new PhabricatorCrumbView())
103
-
->setName(pht("Plan %d", $id))
104
-
->setHref($this->getApplicationURI("plan/{$id}/")));
105
-
$crumbs->addCrumb(
106
-
id(new PhabricatorCrumbView())
107
-
->setName(pht('Edit')));
99
+
$crumbs->addTextCrumb(
100
+
pht("Plan %d", $id),
101
+
$this->getApplicationURI("plan/{$id}/"));
102
+
$crumbs->addTextCrumb(pht('Edit'));
108
103
}
109
104
110
105
return $this->buildApplicationPage(
+1
-3
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+1
-3
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
···
51
51
$this->buildPropertyLists($box, $plan, $actions);
52
52
53
53
$crumbs = $this->buildApplicationCrumbs();
54
-
$crumbs->addCrumb(
55
-
id(new PhabricatorCrumbView())
56
-
->setName(pht("Plan %d", $id)));
54
+
$crumbs->addTextCrumb(pht("Plan %d", $id));
57
55
58
56
$step_list = $this->buildStepList($plan);
59
57
+4
-7
src/applications/harbormaster/controller/HarbormasterStepEditController.php
+4
-7
src/applications/harbormaster/controller/HarbormasterStepEditController.php
···
132
132
133
133
$crumbs = $this->buildApplicationCrumbs();
134
134
$id = $plan->getID();
135
-
$crumbs->addCrumb(
136
-
id(new PhabricatorCrumbView())
137
-
->setName(pht("Plan %d", $id))
138
-
->setHref($this->getApplicationURI("plan/{$id}/")));
139
-
$crumbs->addCrumb(
140
-
id(new PhabricatorCrumbView())
141
-
->setName(pht('Edit Step')));
135
+
$crumbs->addTextCrumb(
136
+
pht("Plan %d", $id),
137
+
$this->getApplicationURI("plan/{$id}/"));
138
+
$crumbs->addTextCrumb(pht('Edit Step'));
142
139
143
140
return $this->buildApplicationPage(
144
141
array(
+1
-3
src/applications/herald/controller/HeraldNewController.php
+1
-3
src/applications/herald/controller/HeraldNewController.php
+1
-3
src/applications/herald/controller/HeraldRuleController.php
+1
-3
src/applications/herald/controller/HeraldRuleController.php
+3
-4
src/applications/herald/controller/HeraldRuleEditHistoryController.php
+3
-4
src/applications/herald/controller/HeraldRuleEditHistoryController.php
···
37
37
38
38
$crumbs = $this
39
39
->buildApplicationCrumbs($can_create = false)
40
-
->addCrumb(
41
-
id(new PhabricatorCrumbView())
42
-
->setName(pht('Edit History'))
43
-
->setHref($this->getApplicationURI('herald/history')));
40
+
->addTextCrumb(
41
+
pht('Edit History'),
42
+
$this->getApplicationURI('herald/history'));
44
43
45
44
$nav = $this->buildSideNavView();
46
45
$nav->selectFilter('history');
+1
-3
src/applications/herald/controller/HeraldRuleViewController.php
+1
-3
src/applications/herald/controller/HeraldRuleViewController.php
+4
-7
src/applications/herald/controller/HeraldTestConsoleController.php
+4
-7
src/applications/herald/controller/HeraldTestConsoleController.php
···
112
112
->setForm($form);
113
113
114
114
$crumbs = id($this->buildApplicationCrumbs())
115
-
->addCrumb(
116
-
id(new PhabricatorCrumbView())
117
-
->setName(pht('Transcripts'))
118
-
->setHref($this->getApplicationURI('/transcript/')))
119
-
->addCrumb(
120
-
id(new PhabricatorCrumbView())
121
-
->setName(pht('Test Console')));
115
+
->addTextCrumb(
116
+
pht('Transcripts'),
117
+
$this->getApplicationURI('/transcript/'))
118
+
->addTextCrumb(pht('Test Console'));
122
119
123
120
return $this->buildApplicationPage(
124
121
$box,
+4
-7
src/applications/herald/controller/HeraldTranscriptController.php
+4
-7
src/applications/herald/controller/HeraldTranscriptController.php
···
97
97
}
98
98
99
99
$crumbs = id($this->buildApplicationCrumbs())
100
-
->addCrumb(
101
-
id(new PhabricatorCrumbView())
102
-
->setName(pht('Transcripts'))
103
-
->setHref($this->getApplicationURI('/transcript/')))
104
-
->addCrumb(
105
-
id(new PhabricatorCrumbView())
106
-
->setName($xscript->getID()));
100
+
->addTextCrumb(
101
+
pht('Transcripts'),
102
+
$this->getApplicationURI('/transcript/'))
103
+
->addTextCrumb($xscript->getID());
107
104
$nav->setCrumbs($crumbs);
108
105
109
106
return $this->buildApplicationPage(
+1
-3
src/applications/herald/controller/HeraldTranscriptListController.php
+1
-3
src/applications/herald/controller/HeraldTranscriptListController.php
···
72
72
$nav->appendChild($panel);
73
73
74
74
$crumbs = id($this->buildApplicationCrumbs())
75
-
->addCrumb(
76
-
id(new PhabricatorCrumbView())
77
-
->setName(pht('Transcripts')));
75
+
->addTextCrumb(pht('Transcripts'));
78
76
$nav->setCrumbs($crumbs);
79
77
80
78
return $this->buildApplicationPage(
+1
-2
src/applications/legalpad/controller/LegalpadDocumentEditController.php
+1
-2
src/applications/legalpad/controller/LegalpadDocumentEditController.php
+3
-4
src/applications/legalpad/controller/LegalpadDocumentViewController.php
+3
-4
src/applications/legalpad/controller/LegalpadDocumentViewController.php
···
81
81
82
82
$crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
83
83
$crumbs->setActionList($actions);
84
-
$crumbs->addCrumb(
85
-
id(new PhabricatorCrumbView())
86
-
->setName('L'.$document->getID())
87
-
->setHref($this->getApplicationURI('view/'.$document->getID())));
84
+
$crumbs->addTextCrumb(
85
+
'L'.$document->getID(),
86
+
$this->getApplicationURI('view/'.$document->getID()));
88
87
89
88
$object_box = id(new PHUIObjectBoxView())
90
89
->setHeader($header)
+2
-9
src/applications/macro/controller/PhabricatorMacroAudioController.php
+2
-9
src/applications/macro/controller/PhabricatorMacroAudioController.php
···
132
132
$title = pht('Edit Audio Behavior');
133
133
$crumb = pht('Edit Audio');
134
134
135
-
$crumbs->addCrumb(
136
-
id(new PhabricatorCrumbView())
137
-
->setHref($view_uri)
138
-
->setName(pht('Macro "%s"', $macro->getName())));
139
-
140
-
$crumbs->addCrumb(
141
-
id(new PhabricatorCrumbView())
142
-
->setHref($request->getRequestURI())
143
-
->setName($crumb));
135
+
$crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
136
+
$crumbs->addTextCrumb($crumb, $request->getRequestURI());
144
137
145
138
$upload_form = id(new AphrontFormView())
146
139
->setEncType('multipart/form-data')
+2
-8
src/applications/macro/controller/PhabricatorMacroEditController.php
+2
-8
src/applications/macro/controller/PhabricatorMacroEditController.php
···
219
219
$title = pht('Edit Image Macro');
220
220
$crumb = pht('Edit Macro');
221
221
222
-
$crumbs->addCrumb(
223
-
id(new PhabricatorCrumbView())
224
-
->setHref($view_uri)
225
-
->setName(pht('Macro "%s"', $macro->getName())));
222
+
$crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri);
226
223
} else {
227
224
$title = pht('Create Image Macro');
228
225
$crumb = pht('Create Macro');
229
226
}
230
227
231
-
$crumbs->addCrumb(
232
-
id(new PhabricatorCrumbView())
233
-
->setHref($request->getRequestURI())
234
-
->setName($crumb));
228
+
$crumbs->addCrumb($crumb, $request->getRequestURI());
235
229
236
230
$upload = null;
237
231
if ($macro->getID()) {
+3
-4
src/applications/macro/controller/PhabricatorMacroViewController.php
+3
-4
src/applications/macro/controller/PhabricatorMacroViewController.php
···
30
30
31
31
$crumbs = $this->buildApplicationCrumbs();
32
32
$crumbs->setActionList($actions);
33
-
$crumbs->addCrumb(
34
-
id(new PhabricatorCrumbView())
35
-
->setHref($this->getApplicationURI('/view/'.$macro->getID().'/'))
36
-
->setName($title_short));
33
+
$crumbs->addTextCrumb(
34
+
$title_short,
35
+
$this->getApplicationURI('/view/'.$macro->getID().'/'));
37
36
38
37
$properties = $this->buildPropertyView($macro, $actions);
39
38
if ($file) {
+2
-6
src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php
+2
-6
src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php
···
117
117
->addCancelButton($this->getApplicationURI()));
118
118
119
119
if ($list->getID()) {
120
-
$crumbs->addCrumb(
121
-
id(new PhabricatorCrumbView())
122
-
->setName(pht('Edit Mailing List')));
120
+
$crumbs->addTextCrumb(pht('Edit Mailing List'));
123
121
} else {
124
-
$crumbs->addCrumb(
125
-
id(new PhabricatorCrumbView())
126
-
->setName(pht('Create Mailing List')));
122
+
$crumbs->addTextCrumb(pht('Create Mailing List'));
127
123
}
128
124
129
125
$form_box = id(new PHUIObjectBoxView())
+1
-3
src/applications/maniphest/controller/ManiphestBatchEditController.php
+1
-3
src/applications/maniphest/controller/ManiphestBatchEditController.php
···
144
144
$title = pht('Batch Editor');
145
145
146
146
$crumbs = $this->buildApplicationCrumbs();
147
-
$crumbs->addCrumb(
148
-
id(new PhabricatorCrumbView())
149
-
->setName($title));
147
+
$crumbs->addTextCrumb($title);
150
148
151
149
$form_box = id(new PHUIObjectBoxView())
152
150
->setHeaderText(pht('Batch Edit Tasks'))
+1
-3
src/applications/maniphest/controller/ManiphestReportController.php
+1
-3
src/applications/maniphest/controller/ManiphestReportController.php
+2
-5
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+2
-5
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
367
367
$object_name = 'T'.$task->getID();
368
368
$actions = $this->buildActionView($task);
369
369
370
-
$crumbs = $this->buildApplicationCrumbs();
371
-
$crumbs->addCrumb(
372
-
id(new PhabricatorCrumbView())
373
-
->setName($object_name)
374
-
->setHref('/'.$object_name))
370
+
$crumbs = $this->buildApplicationCrumbs()
371
+
->addTextCrumb($object_name, '/'.$object_name)
375
372
->setActionList($actions);
376
373
377
374
$header = $this->buildHeaderView($task);
+2
-7
src/applications/maniphest/controller/ManiphestTaskEditController.php
+2
-7
src/applications/maniphest/controller/ManiphestTaskEditController.php
···
667
667
$crumbs = $this->buildApplicationCrumbs();
668
668
669
669
if ($task->getID()) {
670
-
$crumbs->addCrumb(
671
-
id(new PhabricatorCrumbView())
672
-
->setName('T'.$task->getID())
673
-
->setHref('/T'.$task->getID()));
670
+
$crumbs->addTextCrumb('T'.$task->getID(), '/T'.$task->getID());
674
671
}
675
672
676
-
$crumbs->addCrumb(
677
-
id(new PhabricatorCrumbView())
678
-
->setName($header_name));
673
+
$crumbs->addTextCrumb($header_name);
679
674
680
675
return $this->buildApplicationPage(
681
676
array(
+1
-3
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+1
-3
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
···
24
24
$title = $selected->getName();
25
25
26
26
$crumbs = $this->buildApplicationCrumbs();
27
-
$crumbs->addCrumb(
28
-
id(new PhabricatorCrumbView())
29
-
->setName($selected->getName()));
27
+
$crumbs->addTextCrumb($selected->getName());
30
28
31
29
$header = id(new PHUIHeaderView())
32
30
->setHeader($title)
+2
-7
src/applications/meta/controller/PhabricatorApplicationEditController.php
+2
-7
src/applications/meta/controller/PhabricatorApplicationEditController.php
···
146
146
->addCancelButton($view_uri));
147
147
148
148
$crumbs = $this->buildApplicationCrumbs();
149
-
$crumbs->addCrumb(
150
-
id(new PhabricatorCrumbView())
151
-
->setName($application->getName())
152
-
->setHref($view_uri));
153
-
$crumbs->addCrumb(
154
-
id(new PhabricatorCrumbView())
155
-
->setName(pht('Edit Policies')));
149
+
$crumbs->addTextCrumb($application->getName(), $view_uri);
150
+
$crumbs->addTextCrumb(pht('Edit Policies'));
156
151
157
152
$header = id(new PHUIHeaderView())
158
153
->setHeader(pht('Edit Policies: %s', $application->getName()));
+1
-3
src/applications/nuance/controller/NuanceSourceViewController.php
+1
-3
src/applications/nuance/controller/NuanceSourceViewController.php
···
47
47
48
48
$title = pht('%s', $source->getName());
49
49
$crumbs = $this->buildApplicationCrumbs();
50
-
$crumbs->addCrumb(
51
-
id(new PhabricatorCrumbView())
52
-
->setName($title));
50
+
$crumbs->addTextCrumb($title);
53
51
54
52
$header = $this->buildHeaderView($source);
55
53
$actions = $this->buildActionView($source);
+1
-3
src/applications/owners/controller/PhabricatorOwnersController.php
+1
-3
src/applications/owners/controller/PhabricatorOwnersController.php
+1
-3
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
+1
-3
src/applications/passphrase/controller/PassphraseCredentialCreateController.php
···
55
55
$title = pht('New Credential');
56
56
57
57
$crumbs = $this->buildApplicationCrumbs();
58
-
$crumbs->addCrumb(
59
-
id(new PhabricatorCrumbView())
60
-
->setName(pht('Create')));
58
+
$crumbs->addTextCrumb(pht('Create'));
61
59
62
60
$box = id(new PHUIObjectBoxView())
63
61
->setHeaderText(pht('Create New Credential'))
+5
-10
src/applications/passphrase/controller/PassphraseCredentialEditController.php
+5
-10
src/applications/passphrase/controller/PassphraseCredentialEditController.php
···
219
219
if ($is_new) {
220
220
$title = pht('Create Credential');
221
221
$header = pht('Create New Credential');
222
-
$crumbs->addCrumb(
223
-
id(new PhabricatorCrumbView())
224
-
->setName(pht('Create')));
222
+
$crumbs->addTextCrumb(pht('Create'));
225
223
} else {
226
224
$title = pht('Edit Credential');
227
225
$header = pht('Edit Credential %s', 'K'.$credential->getID());
228
-
$crumbs->addCrumb(
229
-
id(new PhabricatorCrumbView())
230
-
->setName('K'.$credential->getID())
231
-
->setHref('/K'.$credential->getID()));
232
-
$crumbs->addCrumb(
233
-
id(new PhabricatorCrumbView())
234
-
->setName(pht('Edit')));
226
+
$crumbs->addTextCrumb(
227
+
'K'.$credential->getID(),
228
+
'/K'.$credential->getID());
229
+
$crumbs->addTextCrumb(pht('Edit'));
235
230
}
236
231
237
232
if ($request->isAjax()) {
+1
-3
src/applications/passphrase/controller/PassphraseCredentialViewController.php
+1
-3
src/applications/passphrase/controller/PassphraseCredentialViewController.php
···
41
41
42
42
$title = pht('%s %s', 'K'.$credential->getID(), $credential->getName());
43
43
$crumbs = $this->buildApplicationCrumbs();
44
-
$crumbs->addCrumb(
45
-
id(new PhabricatorCrumbView())
46
-
->setName('K'.$credential->getID()));
44
+
$crumbs->addTextCrumb('K'.$credential->getID());
47
45
48
46
$header = $this->buildHeaderView($credential);
49
47
$actions = $this->buildActionView($credential);
+2
-6
src/applications/paste/controller/PhabricatorPasteEditController.php
+2
-6
src/applications/paste/controller/PhabricatorPasteEditController.php
···
212
212
213
213
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
214
214
if (!$is_create) {
215
-
$crumbs->addCrumb(
216
-
id(new PhabricatorCrumbView())
217
-
->setName('P'.$paste->getID())
218
-
->setHref('/P'.$paste->getID()));
215
+
$crumbs->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
219
216
}
220
-
$crumbs->addCrumb(
221
-
id(new PhabricatorCrumbView())->setName($short));
217
+
$crumbs->addTextCrumb($short);
222
218
223
219
return $this->buildApplicationPage(
224
220
array(
+1
-4
src/applications/paste/controller/PhabricatorPasteViewController.php
+1
-4
src/applications/paste/controller/PhabricatorPasteViewController.php
···
88
88
89
89
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
90
90
->setActionList($actions)
91
-
->addCrumb(
92
-
id(new PhabricatorCrumbView())
93
-
->setName('P'.$paste->getID())
94
-
->setHref('/P'.$paste->getID()));
91
+
->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
95
92
96
93
$xactions = id(new PhabricatorPasteTransactionQuery())
97
94
->setViewer($request->getUser())
+3
-12
src/applications/people/controller/PhabricatorPeopleEditController.php
+3
-12
src/applications/people/controller/PhabricatorPeopleEditController.php
···
23
23
return new Aphront404Response();
24
24
}
25
25
$base_uri = '/people/edit/'.$user->getID().'/';
26
-
$crumbs->addCrumb(
27
-
id(new PhabricatorCrumbView())
28
-
->setName(pht('Edit User'))
29
-
->setHref('/people/edit/'));
30
-
$crumbs->addCrumb(
31
-
id(new PhabricatorCrumbView())
32
-
->setName($user->getFullName())
33
-
->setHref($base_uri));
26
+
$crumbs->addTextCrumb(pht('Edit User'), '/people/edit/');
27
+
$crumbs->addTextCrumb($user->getFullName(), $base_uri);
34
28
} else {
35
29
$user = new PhabricatorUser();
36
30
$base_uri = '/people/edit/';
37
-
$crumbs->addCrumb(
38
-
id(new PhabricatorCrumbView())
39
-
->setName(pht('Create New User'))
40
-
->setHref($base_uri));
31
+
$crumbs->addTextCrumb(pht('Create New User'), $base_uri);
41
32
}
42
33
43
34
$nav = new AphrontSideNavFilterView();
+3
-4
src/applications/people/controller/PhabricatorPeopleLdapController.php
+3
-4
src/applications/people/controller/PhabricatorPeopleLdapController.php
···
38
38
->appendChild($form);
39
39
40
40
$crumbs = $this->buildApplicationCrumbs();
41
-
$crumbs->addCrumb(
42
-
id(new PhabricatorCrumbView())
43
-
->setName(pht('Import Ldap Users'))
44
-
->setHref($this->getApplicationURI('/ldap/')));
41
+
$crumbs->addTextCrumb(
42
+
pht('Import Ldap Users'),
43
+
$this->getApplicationURI('/ldap/'));
45
44
46
45
$nav = $this->buildSideNavView();
47
46
$nav->setCrumbs($crumbs);
+1
-4
src/applications/people/controller/PhabricatorPeopleLogsController.php
+1
-4
src/applications/people/controller/PhabricatorPeopleLogsController.php
···
207
207
$filter = new AphrontListFilterView();
208
208
$filter->appendChild($form);
209
209
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
210
-
$crumbs->addCrumb(
211
-
id(new PhabricatorCrumbView())
212
-
->setName(pht('Activity Logs'))
213
-
->setHref('/people/logs/'));
210
+
$crumbs->addTextCrumb(pht('Activity Logs'), '/people/logs/');
214
211
215
212
$nav = $this->buildSideNavView();
216
213
$nav->selectFilter('logs');
+1
-3
src/applications/people/controller/PhabricatorPeopleProfileController.php
+1
-3
src/applications/people/controller/PhabricatorPeopleProfileController.php
···
71
71
$properties = $this->buildPropertyView($user, $actions);
72
72
73
73
$crumbs = $this->buildApplicationCrumbs();
74
-
$crumbs->addCrumb(
75
-
id(new PhabricatorCrumbView())
76
-
->setName($user->getUsername()));
74
+
$crumbs->addTextCrumb($user->getUsername());
77
75
$feed = $this->renderUserFeed($user);
78
76
79
77
$object_box = id(new PHUIObjectBoxView())
+2
-7
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
+2
-7
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
···
61
61
62
62
$title = pht('Edit Profile');
63
63
$crumbs = $this->buildApplicationCrumbs();
64
-
$crumbs->addCrumb(
65
-
id(new PhabricatorCrumbView())
66
-
->setName($user->getUsername())
67
-
->setHref($profile_uri));
68
-
$crumbs->addCrumb(
69
-
id(new PhabricatorCrumbView())
70
-
->setName($title));
64
+
$crumbs->addTextCrumb($user->getUsername(), $profile_uri);
65
+
$crumbs->addTextCrumb($title);
71
66
72
67
$form = id(new AphrontFormView())
73
68
->setUser($viewer);
+2
-7
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
+2
-7
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
···
91
91
92
92
$title = pht('Edit Profile Picture');
93
93
$crumbs = $this->buildApplicationCrumbs();
94
-
$crumbs->addCrumb(
95
-
id(new PhabricatorCrumbView())
96
-
->setName($user->getUsername())
97
-
->setHref($profile_uri));
98
-
$crumbs->addCrumb(
99
-
id(new PhabricatorCrumbView())
100
-
->setName($title));
94
+
$crumbs->addTextCrumb($user->getUsername(), $profile_uri);
95
+
$crumbs->addTextCrumb($title);
101
96
102
97
$form = id(new PHUIFormLayoutView())
103
98
->setUser($viewer);
+1
-4
src/applications/phame/controller/blog/PhameBlogEditController.php
+1
-4
src/applications/phame/controller/blog/PhameBlogEditController.php
···
176
176
->setForm($form);
177
177
178
178
$crumbs = $this->buildApplicationCrumbs();
179
-
$crumbs->addCrumb(
180
-
id(new PhabricatorCrumbView())
181
-
->setName($page_title)
182
-
->setHref($this->getApplicationURI('blog/new')));
179
+
$crumbs->addTextCrumb($page_title, $this->getApplicationURI('blog/new'));
183
180
184
181
$nav = $this->renderSideNavFilterView();
185
182
$nav->selectFilter($this->id ? null : 'blog/new');
+1
-4
src/applications/phame/controller/blog/PhameBlogListController.php
+1
-4
src/applications/phame/controller/blog/PhameBlogListController.php
···
48
48
$blog_list->setPager($pager);
49
49
50
50
$crumbs = $this->buildApplicationCrumbs();
51
-
$crumbs->addCrumb(
52
-
id(new PhabricatorCrumbView())
53
-
->setName($title)
54
-
->setHref($this->getApplicationURI()));
51
+
$crumbs->addTextCrumb($title, $this->getApplicationURI());
55
52
56
53
$nav->appendChild(
57
54
array(
+1
-4
src/applications/phame/controller/blog/PhameBlogViewController.php
+1
-4
src/applications/phame/controller/blog/PhameBlogViewController.php
···
58
58
59
59
60
60
$crumbs = $this->buildApplicationCrumbs();
61
-
$crumbs->addCrumb(
62
-
id(new PhabricatorCrumbView())
63
-
->setName($blog->getName())
64
-
->setHref($this->getApplicationURI()));
61
+
$crumbs->addTextCrumb($blog->getName(), $this->getApplicationURI());
65
62
66
63
$object_box = id(new PHUIObjectBoxView())
67
64
->setHeader($header)
+3
-4
src/applications/phame/controller/post/PhamePostEditController.php
+3
-4
src/applications/phame/controller/post/PhamePostEditController.php
···
177
177
->setForm($form);
178
178
179
179
$crumbs = $this->buildApplicationCrumbs();
180
-
$crumbs->addCrumb(
181
-
id(new PhabricatorCrumbView())
182
-
->setName($page_title)
183
-
->setHref($this->getApplicationURI('/post/view/'.$this->id.'/')));
180
+
$crumbs->addTextCrumb(
181
+
$page_title,
182
+
$this->getApplicationURI('/post/view/'.$this->id.'/'));
184
183
185
184
$nav = $this->renderSideNavFilterView(null);
186
185
$nav->appendChild(
+1
-4
src/applications/phame/controller/post/PhamePostListController.php
+1
-4
src/applications/phame/controller/post/PhamePostListController.php
···
78
78
->appendChild($post_list);
79
79
80
80
$crumbs = $this->buildApplicationCrumbs();
81
-
$crumbs->addCrumb(
82
-
id(new PhabricatorCrumbView())
83
-
->setName($title)
84
-
->setHref($this->getApplicationURI()));
81
+
$crumbs->addTextCrumb($title, $this->getApplicationURI());
85
82
86
83
$nav->appendChild(
87
84
array(
+1
-4
src/applications/phame/controller/post/PhamePostNewController.php
+1
-4
src/applications/phame/controller/post/PhamePostNewController.php
···
69
69
$nav->selectFilter('post/new');
70
70
71
71
$crumbs = $this->buildApplicationCrumbs();
72
-
$crumbs->addCrumb(
73
-
id(new PhabricatorCrumbView())
74
-
->setName($title)
75
-
->setHref($view_uri));
72
+
$crumbs->addTextCrumb($title, $view_uri);
76
73
$nav->appendChild($crumbs);
77
74
78
75
if (!$blogs) {
+1
-4
src/applications/phame/controller/post/PhamePostPublishController.php
+1
-4
src/applications/phame/controller/post/PhamePostPublishController.php
···
51
51
->setForm($form);
52
52
53
53
$crumbs = $this->buildApplicationCrumbs();
54
-
$crumbs->addCrumb(
55
-
id(new PhabricatorCrumbView())
56
-
->setName(pht('Preview'))
57
-
->setHref($view_uri));
54
+
$crumbs->addTextCrumb(pht('Preview'), $view_uri);
58
55
59
56
$nav = $this->renderSideNavFilterView(null);
60
57
$nav->appendChild(
+3
-4
src/applications/phame/controller/post/PhamePostViewController.php
+3
-4
src/applications/phame/controller/post/PhamePostViewController.php
···
36
36
37
37
$crumbs = $this->buildApplicationCrumbs();
38
38
$crumbs->setActionList($actions);
39
-
$crumbs->addCrumb(
40
-
id(new PhabricatorCrumbView())
41
-
->setName($post->getTitle())
42
-
->setHref($this->getApplicationURI('post/view/'.$post->getID().'/')));
39
+
$crumbs->addTextCrumb(
40
+
$post->getTitle(),
41
+
$this->getApplicationURI('post/view/'.$post->getID().'/'));
43
42
44
43
$nav->appendChild($crumbs);
45
44
+2
-8
src/applications/phlux/controller/PhluxEditController.php
+2
-8
src/applications/phlux/controller/PhluxEditController.php
···
164
164
165
165
if ($is_new) {
166
166
$title = pht('Create Variable');
167
-
$crumbs->addCrumb(
168
-
id(new PhabricatorCrumbView())
169
-
->setName($title)
170
-
->setHref($request->getRequestURI()));
167
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
171
168
} else {
172
169
$title = pht('Edit %s', $this->key);
173
-
$crumbs->addCrumb(
174
-
id(new PhabricatorCrumbView())
175
-
->setName($title)
176
-
->setHref($request->getRequestURI()));
170
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
177
171
}
178
172
179
173
$form_box = id(new PHUIObjectBoxView())
+1
-4
src/applications/phlux/controller/PhluxListController.php
+1
-4
src/applications/phlux/controller/PhluxListController.php
···
31
31
32
32
$title = pht('Variable List');
33
33
34
-
$crumbs->addCrumb(
35
-
id(new PhabricatorCrumbView())
36
-
->setName($title)
37
-
->setHref($this->getApplicationURI()));
34
+
$crumbs->addTextCrumb($title, $this->getApplicationURI());
38
35
39
36
return $this->buildApplicationPage(
40
37
array(
+1
-4
src/applications/phlux/controller/PhluxViewController.php
+1
-4
src/applications/phlux/controller/PhluxViewController.php
···
25
25
26
26
$title = $var->getVariableKey();
27
27
28
-
$crumbs->addCrumb(
29
-
id(new PhabricatorCrumbView())
30
-
->setName($title)
31
-
->setHref($request->getRequestURI()));
28
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
32
29
33
30
$header = id(new PHUIHeaderView())
34
31
->setHeader($title)
+2
-8
src/applications/pholio/controller/PholioImageHistoryController.php
+2
-8
src/applications/pholio/controller/PholioImageHistoryController.php
···
69
69
70
70
$crumbs = $this->buildApplicationCrumbs();
71
71
$crumbs
72
-
->addCrumb(
73
-
id(new PhabricatorCrumbView())
74
-
->setName('M'.$mock->getID())
75
-
->setHref('/M'.$mock->getID()))
76
-
->addCrumb(
77
-
id(new PhabricatorCrumbView())
78
-
->setName('Image History')
79
-
->setHref($request->getRequestURI()));
72
+
->addTextCrumb('M'.$mock->getID(), '/M'.$mock->getID())
73
+
->addTextCrumb('Image History', $request->getRequestURI());
80
74
81
75
$content = array(
82
76
$crumbs,
+1
-4
src/applications/pholio/controller/PholioMockEditController.php
+1
-4
src/applications/pholio/controller/PholioMockEditController.php
···
326
326
->setForm($form);
327
327
328
328
$crumbs = $this->buildApplicationCrumbs();
329
-
$crumbs->addCrumb(
330
-
id(new PhabricatorCrumbView())
331
-
->setName($title)
332
-
->setHref($this->getApplicationURI()));
329
+
$crumbs->addTextCrumb($title, $this->getApplicationURI());
333
330
334
331
$content = array(
335
332
$crumbs,
+1
-4
src/applications/pholio/controller/PholioMockViewController.php
+1
-4
src/applications/pholio/controller/PholioMockViewController.php
···
98
98
99
99
$crumbs = $this->buildApplicationCrumbs();
100
100
$crumbs->setActionList($actions);
101
-
$crumbs->addCrumb(
102
-
id(new PhabricatorCrumbView())
103
-
->setName('M'.$mock->getID())
104
-
->setHref('/M'.$mock->getID()));
101
+
$crumbs->addTextCrumb('M'.$mock->getID(), '/M'.$mock->getID());
105
102
106
103
$object_box = id(new PHUIObjectBoxView())
107
104
->setHeader($header)
+1
-4
src/applications/phortune/controller/PhortuneAccountViewController.php
+1
-4
src/applications/phortune/controller/PhortuneAccountViewController.php
···
24
24
$title = $account->getName();
25
25
26
26
$crumbs = $this->buildApplicationCrumbs();
27
-
$crumbs->addCrumb(
28
-
id(new PhabricatorCrumbView())
29
-
->setName(pht('Account'))
30
-
->setHref($request->getRequestURI()));
27
+
$crumbs->addTextCrumb(pht('Account'), $request->getRequestURI());
31
28
32
29
$header = id(new PHUIHeaderView())
33
30
->setHeader($title);
+2
-8
src/applications/phortune/controller/PhortunePaymentMethodEditController.php
+2
-8
src/applications/phortune/controller/PhortunePaymentMethodEditController.php
···
159
159
->setHeader($title);
160
160
161
161
$crumbs = $this->buildApplicationCrumbs();
162
-
$crumbs->addCrumb(
163
-
id(new PhabricatorCrumbView())
164
-
->setName(pht('Account'))
165
-
->setHref($account_uri));
166
-
$crumbs->addCrumb(
167
-
id(new PhabricatorCrumbView())
168
-
->setName(pht('Payment Methods'))
169
-
->setHref($request->getRequestURI()));
162
+
$crumbs->addTextCrumb(pht('Account'), $account_uri);
163
+
$crumbs->addTextCrumb(pht('Payment Methods'), $request->getRequestURI());
170
164
171
165
return $this->buildApplicationPage(
172
166
array(
+6
-8
src/applications/phortune/controller/PhortuneProductEditController.php
+6
-8
src/applications/phortune/controller/PhortuneProductEditController.php
···
135
135
136
136
$title = pht('Edit Product');
137
137
$crumbs = $this->buildApplicationCrumbs();
138
-
$crumbs->addCrumb(
139
-
id(new PhabricatorCrumbView())
140
-
->setName(pht('Products'))
141
-
->setHref($this->getApplicationURI('product/')));
142
-
$crumbs->addCrumb(
143
-
id(new PhabricatorCrumbView())
144
-
->setName($is_create ? pht('Create') : pht('Edit'))
145
-
->setHref($request->getRequestURI()));
138
+
$crumbs->addTextCrumb(
139
+
pht('Products'),
140
+
$this->getApplicationURI('product/'));
141
+
$crumbs->addTextCrumb(
142
+
$is_create ? pht('Create') : pht('Edit'),
143
+
$request->getRequestURI());
146
144
147
145
$header = id(new PHUIHeaderView())
148
146
->setHeader(pht('Edit Product'));
+1
-4
src/applications/phortune/controller/PhortuneProductListController.php
+1
-4
src/applications/phortune/controller/PhortuneProductListController.php
···
17
17
$title = pht('Product List');
18
18
19
19
$crumbs = $this->buildApplicationCrumbs();
20
-
$crumbs->addCrumb(
21
-
id(new PhabricatorCrumbView())
22
-
->setName('Products')
23
-
->setHref($this->getApplicationURI('product/')));
20
+
$crumbs->addTextCrumb('Products', $this->getApplicationURI('product/'));
24
21
$crumbs->addAction(
25
22
id(new PHUIListItemView())
26
23
->setName(pht('Create Product'))
+6
-8
src/applications/phortune/controller/PhortuneProductViewController.php
+6
-8
src/applications/phortune/controller/PhortuneProductViewController.php
···
50
50
51
51
$crumbs = $this->buildApplicationCrumbs();
52
52
$crumbs->setActionList($actions);
53
-
$crumbs->addCrumb(
54
-
id(new PhabricatorCrumbView())
55
-
->setName(pht('Products'))
56
-
->setHref($this->getApplicationURI('product/')));
57
-
$crumbs->addCrumb(
58
-
id(new PhabricatorCrumbView())
59
-
->setName(pht('#%d', $product->getID()))
60
-
->setHref($request->getRequestURI()));
53
+
$crumbs->addTextCrumb(
54
+
pht('Products'),
55
+
$this->getApplicationURI('product/'));
56
+
$crumbs->addTextCrumb(
57
+
pht('#%d', $product->getID()),
58
+
$request->getRequestURI());
61
59
62
60
$properties = id(new PHUIPropertyListView())
63
61
->setUser($user)
+4
-8
src/applications/phragment/controller/PhragmentController.php
+4
-8
src/applications/phragment/controller/PhragmentController.php
···
41
41
42
42
protected function buildApplicationCrumbsWithPath(array $fragments) {
43
43
$crumbs = $this->buildApplicationCrumbs();
44
-
$crumbs->addCrumb(
45
-
id(new PhabricatorCrumbView())
46
-
->setName('/')
47
-
->setHref('/phragment/'));
44
+
$crumbs->addTextCrumb('/', '/phragment/');
48
45
foreach ($fragments as $parent) {
49
-
$crumbs->addCrumb(
50
-
id(new PhabricatorCrumbView())
51
-
->setName($parent->getName())
52
-
->setHref('/phragment/browse/'.$parent->getPath()));
46
+
$crumbs->addTextCrumb(
47
+
$parent->getName(),
48
+
'/phragment/browse/'.$parent->getPath());
53
49
}
54
50
return $crumbs;
55
51
}
+1
-3
src/applications/phragment/controller/PhragmentCreateController.php
+1
-3
src/applications/phragment/controller/PhragmentCreateController.php
···
111
111
$this->getApplicationURI('browse/'.$parent_path)));
112
112
113
113
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
114
-
$crumbs->addCrumb(
115
-
id(new PhabricatorCrumbView())
116
-
->setName(pht('Create Fragment')));
114
+
$crumbs->addTextCrumb(pht('Create Fragment'));
117
115
118
116
$box = id(new PHUIObjectBoxView())
119
117
->setHeaderText('Create Fragment')
+1
-3
src/applications/phragment/controller/PhragmentPolicyController.php
+1
-3
src/applications/phragment/controller/PhragmentPolicyController.php
···
88
88
$this->getApplicationURI('browse/'.$fragment->getPath())));
89
89
90
90
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
91
-
$crumbs->addCrumb(
92
-
id(new PhabricatorCrumbView())
93
-
->setName(pht('Edit Fragment Policies')));
91
+
$crumbs->addTextCrumb(pht('Edit Fragment Policies'));
94
92
95
93
$box = id(new PHUIObjectBoxView())
96
94
->setHeaderText(pht('Edit Fragment Policies: %s', $fragment->getPath()))
+1
-3
src/applications/phragment/controller/PhragmentSnapshotCreateController.php
+1
-3
src/applications/phragment/controller/PhragmentSnapshotCreateController.php
···
154
154
->appendInstructions($container);
155
155
156
156
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
157
-
$crumbs->addCrumb(
158
-
id(new PhabricatorCrumbView())
159
-
->setName(pht('Create Snapshot')));
157
+
$crumbs->addTextCrumb(pht('Create Snapshot'));
160
158
161
159
$box = id(new PHUIObjectBoxView())
162
160
->setHeaderText(pht('Create Snapshot of %s', $fragment->getName()))
+1
-3
src/applications/phragment/controller/PhragmentSnapshotViewController.php
+1
-3
src/applications/phragment/controller/PhragmentSnapshotViewController.php
···
40
40
}
41
41
42
42
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
43
-
$crumbs->addCrumb(
44
-
id(new PhabricatorCrumbView())
45
-
->setName(pht('"%s" Snapshot', $snapshot->getName())));
43
+
$crumbs->addTextCrumb(pht('"%s" Snapshot', $snapshot->getName()));
46
44
47
45
$children = id(new PhragmentSnapshotChildQuery())
48
46
->setViewer($viewer)
+1
-3
src/applications/phragment/controller/PhragmentUpdateController.php
+1
-3
src/applications/phragment/controller/PhragmentUpdateController.php
···
62
62
$this->getApplicationURI('browse/'.$fragment->getPath())));
63
63
64
64
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
65
-
$crumbs->addCrumb(
66
-
id(new PhabricatorCrumbView())
67
-
->setName(pht('Update Fragment')));
65
+
$crumbs->addTextCrumb(pht('Update Fragment'));
68
66
69
67
$box = id(new PHUIObjectBoxView())
70
68
->setHeaderText(pht('Update Fragment: %s', $fragment->getPath()))
+1
-3
src/applications/phragment/controller/PhragmentVersionController.php
+1
-3
src/applications/phragment/controller/PhragmentVersionController.php
···
31
31
$current = idx($parents, count($parents) - 1, null);
32
32
33
33
$crumbs = $this->buildApplicationCrumbsWithPath($parents);
34
-
$crumbs->addCrumb(
35
-
id(new PhabricatorCrumbView())
36
-
->setName(pht('View Version %d', $version->getSequence())));
34
+
$crumbs->addTextCrumb(pht('View Version %d', $version->getSequence()));
37
35
38
36
$phids = array();
39
37
$phids[] = $version->getFilePHID();
+4
-9
src/applications/phriction/controller/PhrictionDiffController.php
+4
-9
src/applications/phriction/controller/PhrictionDiffController.php
···
107
107
$crumbs->addCrumb($view);
108
108
}
109
109
110
-
$crumbs->addCrumb(
111
-
id(new PhabricatorCrumbView())
112
-
->setName(pht('History'))
113
-
->setHref(PhrictionDocument::getSlugURI($slug, 'history')));
114
-
110
+
$crumbs->addTextCrumb(
111
+
pht('History'),
112
+
PhrictionDocument::getSlugURI($slug, 'history'));
115
113
116
114
$title = pht("Version %s vs %s", $l, $r);
117
115
118
116
$header = id(new PHUIHeaderView())
119
117
->setHeader($title);
120
118
121
-
$crumbs->addCrumb(
122
-
id(new PhabricatorCrumbView())
123
-
->setName($title)
124
-
->setHref($request->getRequestURI()));
119
+
$crumbs->addTextCrumb($title, $request->getRequestURI());
125
120
126
121
127
122
$comparison_table = $this->renderComparisonTable(
+5
-10
src/applications/phriction/controller/PhrictionEditController.php
+5
-10
src/applications/phriction/controller/PhrictionEditController.php
···
241
241
242
242
$crumbs = $this->buildApplicationCrumbs();
243
243
if ($document->getID()) {
244
-
$crumbs->addCrumb(
245
-
id(new PhabricatorCrumbView())
246
-
->setName($content->getTitle())
247
-
->setHref(PhrictionDocument::getSlugURI($document->getSlug())));
248
-
$crumbs->addCrumb(
249
-
id(new PhabricatorCrumbView())
250
-
->setName(pht('Edit')));
244
+
$crumbs->addTextCrumb(
245
+
$content->getTitle(),
246
+
PhrictionDocument::getSlugURI($document->getSlug()));
247
+
$crumbs->addTextCrumb(pht('Edit'));
251
248
} else {
252
-
$crumbs->addCrumb(
253
-
id(new PhabricatorCrumbView())
254
-
->setName(pht('Create')));
249
+
$crumbs->addTextCrumb(pht('Create'));
255
250
}
256
251
257
252
return $this->buildApplicationPage(
+3
-5
src/applications/phriction/controller/PhrictionHistoryController.php
+3
-5
src/applications/phriction/controller/PhrictionHistoryController.php
···
138
138
foreach ($crumb_views as $view) {
139
139
$crumbs->addCrumb($view);
140
140
}
141
-
$crumbs->addCrumb(
142
-
id(new PhabricatorCrumbView())
143
-
->setName(pht('History'))
144
-
->setHref(
145
-
PhrictionDocument::getSlugURI($document->getSlug(), 'history')));
141
+
$crumbs->addTextCrumb(
142
+
pht('History'),
143
+
PhrictionDocument::getSlugURI($document->getSlug(), 'history'));
146
144
147
145
$header = new PHUIHeaderView();
148
146
$header->setHeader(pht('Document History for %s',
+2
-7
src/applications/ponder/controller/PonderAnswerEditController.php
+2
-7
src/applications/ponder/controller/PonderAnswerEditController.php
···
86
86
->addCancelButton($answer_uri));
87
87
88
88
$crumbs = $this->buildApplicationCrumbs();
89
-
$crumbs->addCrumb(
90
-
id(new PhabricatorCrumbView())
91
-
->setName("Q{$qid}")
92
-
->setHref($answer_uri));
93
-
$crumbs->addCrumb(
94
-
id(new PhabricatorCrumbView())
95
-
->setName(pht('Edit Answer')));
89
+
$crumbs->addTextCrumb("Q{$qid}", $answer_uri);
90
+
$crumbs->addTextCrumb(pht('Edit Answer'));
96
91
97
92
$form_box = id(new PHUIObjectBoxView())
98
93
->setHeaderText(pht('Edit Answer'))
+3
-11
src/applications/ponder/controller/PonderAnswerHistoryController.php
+3
-11
src/applications/ponder/controller/PonderAnswerHistoryController.php
···
46
46
$aid = $answer->getID();
47
47
48
48
$crumbs = $this->buildApplicationCrumbs();
49
-
$crumbs->addCrumb(
50
-
id(new PhabricatorCrumbView())
51
-
->setName("Q{$qid}")
52
-
->setHref("/Q{$qid}"));
53
-
$crumbs->addCrumb(
54
-
id(new PhabricatorCrumbView())
55
-
->setName("A{$aid}")
56
-
->setHref("/Q{$qid}#{$aid}"));
57
-
$crumbs->addCrumb(
58
-
id(new PhabricatorCrumbView())
59
-
->setName(pht('History')));
49
+
$crumbs->addTextCrumb("Q{$qid}", "/Q{$qid}");
50
+
$crumbs->addTextCrumb("A{$aid}", "/Q{$qid}#{$aid}");
51
+
$crumbs->addTextCrumb(pht('History'));
60
52
61
53
return $this->buildApplicationPage(
62
54
array(
+3
-10
src/applications/ponder/controller/PonderQuestionEditController.php
+3
-10
src/applications/ponder/controller/PonderQuestionEditController.php
···
117
117
118
118
$id = $question->getID();
119
119
if ($id) {
120
-
$crumbs->addCrumb(
121
-
id(new PhabricatorCrumbView())
122
-
->setName("Q{$id}")
123
-
->setHref("/Q{$id}"));
124
-
$crumbs->addCrumb(
125
-
id(new PhabricatorCrumbView())
126
-
->setName(pht('Edit')));
120
+
$crumbs->addTextCrumb("Q{$id}", "/Q{$id}");
121
+
$crumbs->addTextCrumb(pht('Edit'));
127
122
} else {
128
-
$crumbs->addCrumb(
129
-
id(new PhabricatorCrumbView())
130
-
->setName(pht('Ask Question')));
123
+
$crumbs->addTextCrumb(pht('Ask Question'));
131
124
}
132
125
133
126
return $this->buildApplicationPage(
+2
-7
src/applications/ponder/controller/PonderQuestionHistoryController.php
+2
-7
src/applications/ponder/controller/PonderQuestionHistoryController.php
···
45
45
$qid = $question->getID();
46
46
47
47
$crumbs = $this->buildApplicationCrumbs();
48
-
$crumbs->addCrumb(
49
-
id(new PhabricatorCrumbView())
50
-
->setName("Q{$qid}")
51
-
->setHref("/Q{$qid}"));
52
-
$crumbs->addCrumb(
53
-
id(new PhabricatorCrumbView())
54
-
->setName(pht('History')));
48
+
$crumbs->addTextCrumb("Q{$qid}", "/Q{$qid}");
49
+
$crumbs->addTextCrumb(pht('History'));
55
50
56
51
return $this->buildApplicationPage(
57
52
array(
+1
-4
src/applications/ponder/controller/PonderQuestionViewController.php
+1
-4
src/applications/ponder/controller/PonderQuestionViewController.php
···
56
56
57
57
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
58
58
$crumbs->setActionList($actions);
59
-
$crumbs->addCrumb(
60
-
id(new PhabricatorCrumbView())
61
-
->setName('Q'.$this->questionID)
62
-
->setHref('/Q'.$this->questionID));
59
+
$crumbs->addTextCrumb('Q'.$this->questionID, '/Q'.$this->questionID);
63
60
64
61
return $this->buildApplicationPage(
65
62
array(
+3
-4
src/applications/project/controller/PhabricatorProjectCreateController.php
+3
-4
src/applications/project/controller/PhabricatorProjectCreateController.php
···
112
112
->addCancelButton('/project/'));
113
113
114
114
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
115
-
$crumbs->addCrumb(
116
-
id(new PhabricatorCrumbView())
117
-
->setName(pht('Create Project'))
118
-
->setHref($this->getApplicationURI().'create/'));
115
+
$crumbs->addTextCrumb(
116
+
pht('Create Project'),
117
+
$this->getApplicationURI().'create/');
119
118
120
119
$form_box = id(new PHUIObjectBoxView())
121
120
->setHeaderText(pht('Create New Project'))
+5
-8
src/applications/project/controller/PhabricatorProjectHistoryController.php
+5
-8
src/applications/project/controller/PhabricatorProjectHistoryController.php
···
37
37
->setObjectPHID($project->getPHID())
38
38
->setTransactions($xactions);
39
39
40
-
$crumbs = $this->buildApplicationCrumbs();
41
-
$crumbs->addCrumb(
42
-
id(new PhabricatorCrumbView())
43
-
->setName($project->getName())
44
-
->setHref($this->getApplicationURI("view/{$id}/")));
45
-
$crumbs->addCrumb(
46
-
id(new PhabricatorCrumbView())
47
-
->setName(pht('History')));
40
+
$crumbs = $this->buildApplicationCrumbs()
41
+
->addTextCrumb(
42
+
$project->getName(),
43
+
$this->getApplicationURI("view/{$id}/"))
44
+
->addTextCrumb(pht('History'));
48
45
49
46
return $this->buildApplicationPage(
50
47
array(
+5
-9
src/applications/project/controller/PhabricatorProjectMembersEditController.php
+5
-9
src/applications/project/controller/PhabricatorProjectMembersEditController.php
···
111
111
->setHeaderText($title)
112
112
->setForm($form);
113
113
114
-
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
115
-
$crumbs->addCrumb(
116
-
id(new PhabricatorCrumbView())
117
-
->setName($project->getName())
118
-
->setHref('/project/view/'.$project->getID().'/'));
119
-
$crumbs->addCrumb(
120
-
id(new PhabricatorCrumbView())
121
-
->setName(pht('Edit Members'))
122
-
->setHref($this->getApplicationURI()));
114
+
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
115
+
->addTextCrumb(
116
+
$project->getName(),
117
+
'/project/view/'.$project->getID().'/')
118
+
->addTextCrumb(pht('Edit Members'), $this->getApplicationURI());
123
119
124
120
return $this->buildApplicationPage(
125
121
array(
+1
-3
src/applications/project/controller/PhabricatorProjectProfileController.php
+1
-3
src/applications/project/controller/PhabricatorProjectProfileController.php
···
73
73
$properties = $this->buildPropertyListView($project, $profile, $actions);
74
74
75
75
$crumbs = $this->buildApplicationCrumbs();
76
-
$crumbs->addCrumb(
77
-
id(new PhabricatorCrumbView())
78
-
->setName($project->getName()))
76
+
$crumbs->addTextCrumb($project->getName())
79
77
->setActionList($actions);
80
78
81
79
$object_box = id(new PHUIObjectBoxView())
+5
-9
src/applications/project/controller/PhabricatorProjectProfileEditController.php
+5
-9
src/applications/project/controller/PhabricatorProjectProfileEditController.php
···
165
165
->setFormError($error_view)
166
166
->setForm($form);
167
167
168
-
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
169
-
$crumbs->addCrumb(
170
-
id(new PhabricatorCrumbView())
171
-
->setName($project->getName())
172
-
->setHref('/project/view/'.$project->getID().'/'));
173
-
$crumbs->addCrumb(
174
-
id(new PhabricatorCrumbView())
175
-
->setName(pht('Edit Project'))
176
-
->setHref($this->getApplicationURI()));
168
+
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
169
+
->addTextCrumb(
170
+
$project->getName(),
171
+
'/project/view/'.$project->getID().'/')
172
+
->addTextCrumb(pht('Edit Project'), $this->getApplicationURI());
177
173
178
174
return $this->buildApplicationPage(
179
175
array(
+2
-7
src/applications/project/controller/PhabricatorProjectProfilePictureController.php
+2
-7
src/applications/project/controller/PhabricatorProjectProfilePictureController.php
···
89
89
90
90
$title = pht('Edit Project Picture');
91
91
$crumbs = $this->buildApplicationCrumbs();
92
-
$crumbs->addCrumb(
93
-
id(new PhabricatorCrumbView())
94
-
->setName($project->getName())
95
-
->setHref($project_uri));
96
-
$crumbs->addCrumb(
97
-
id(new PhabricatorCrumbView())
98
-
->setName($title));
92
+
$crumbs->addTextCrumb($project->getName(), $project_uri);
93
+
$crumbs->addTextCrumb($title);
99
94
100
95
$form = id(new PHUIFormLayoutView())
101
96
->setUser($viewer);
+2
-8
src/applications/releeph/controller/ReleephProjectController.php
+2
-8
src/applications/releeph/controller/ReleephProjectController.php
···
135
135
$project_id = $project->getID();
136
136
$project_uri = $this->getApplicationURI("project/{$project_id}/");
137
137
138
-
$crumbs->addCrumb(
139
-
id(new PhabricatorCrumbView())
140
-
->setHref($project_uri)
141
-
->setName($project->getName()));
138
+
$crumbs->addCrumb($project->getName(), $project_uri);
142
139
} catch (Exception $ex) {
143
140
// TODO: This is derps.
144
141
}
···
146
143
try {
147
144
$branch = $this->getReleephBranch();
148
145
$branch_uri = $branch->getURI();
149
-
$crumbs->addCrumb(
150
-
id(new PhabricatorCrumbView())
151
-
->setHref($branch_uri)
152
-
->setName($branch->getDisplayNameWithDetail()));
146
+
$crumbs->addCrumb($branch->getDisplayNameWithDetail(), $branch_uri);
153
147
} catch (Exception $ex) {
154
148
// TODO: This is also derps.
155
149
}
+1
-3
src/applications/releeph/controller/branch/ReleephBranchCreateController.php
+1
-3
src/applications/releeph/controller/branch/ReleephBranchCreateController.php
···
99
99
->addCancelButton($project_uri));
100
100
101
101
$crumbs = $this->buildApplicationCrumbs();
102
-
$crumbs->addCrumb(
103
-
id(new PhabricatorCrumbView())
104
-
->setName(pht('New Branch')));
102
+
$crumbs->addTextCrumb(pht('New Branch'));
105
103
106
104
return $this->buildApplicationPage(
107
105
array(
+1
-3
src/applications/releeph/controller/branch/ReleephBranchEditController.php
+1
-3
src/applications/releeph/controller/branch/ReleephBranchEditController.php
···
86
86
$releeph_branch->getDisplayNameWithDetail());
87
87
88
88
$crumbs = $this->buildApplicationCrumbs();
89
-
$crumbs->addCrumb(
90
-
id(new PhabricatorCrumbView())
91
-
->setName(pht('Edit')));
89
+
$crumbs->addTextCrumb(pht('Edit'));
92
90
93
91
return $this->buildApplicationPage(
94
92
array(
+1
-3
src/applications/releeph/controller/branch/ReleephBranchHistoryController.php
+1
-3
src/applications/releeph/controller/branch/ReleephBranchHistoryController.php
+1
-3
src/applications/releeph/controller/project/ReleephProjectCreateController.php
+1
-3
src/applications/releeph/controller/project/ReleephProjectCreateController.php
···
114
114
->setForm($form);
115
115
116
116
$crumbs = $this->buildApplicationCrumbs();
117
-
$crumbs->addCrumb(
118
-
id(new PhabricatorCrumbView())
119
-
->setName(pht('New Project')));
117
+
$crumbs->addTextCrumb(pht('New Project'));
120
118
121
119
return $this->buildApplicationPage(
122
120
array(
+1
-3
src/applications/releeph/controller/project/ReleephProjectHistoryController.php
+1
-3
src/applications/releeph/controller/project/ReleephProjectHistoryController.php
+3
-10
src/applications/releeph/controller/request/ReleephRequestEditController.php
+3
-10
src/applications/releeph/controller/request/ReleephRequestEditController.php
···
272
272
$title = pht('Edit Releeph Request');
273
273
$submit_name = pht('Save');
274
274
275
-
$crumbs->addCrumb(
276
-
id(new PhabricatorCrumbView())
277
-
->setName('RQ'.$rq->getID())
278
-
->setHref('/RQ'.$rq->getID()));
279
-
$crumbs->addCrumb(
280
-
id(new PhabricatorCrumbView())
281
-
->setName(pht('Edit')));
275
+
$crumbs->addTextCrumb('RQ'.$rq->getID(), '/RQ'.$rq->getID());
276
+
$crumbs->addTextCrumb(pht('Edit'));
282
277
283
278
} else {
284
279
$title = pht('Create Releeph Request');
285
280
$submit_name = pht('Create');
286
-
$crumbs->addCrumb(
287
-
id(new PhabricatorCrumbView())
288
-
->setName(pht('New Request')));
281
+
$crumbs->addTextCrumb(pht('New Request'));
289
282
}
290
283
291
284
$form->appendChild(
+7
-12
src/applications/releeph/controller/request/ReleephRequestViewController.php
+7
-12
src/applications/releeph/controller/request/ReleephRequestViewController.php
···
74
74
->setSubmitButtonName('Comment');
75
75
76
76
$crumbs = $this->buildApplicationCrumbs()
77
-
->addCrumb(
78
-
id(new PhabricatorCrumbView())
79
-
->setName($releeph_project->getName())
80
-
->setHref($releeph_project->getURI()))
81
-
->addCrumb(
82
-
id(new PhabricatorCrumbView())
83
-
->setName($releeph_branch->getDisplayNameWithDetail())
84
-
->setHref($releeph_branch->getURI()))
85
-
->addCrumb(
86
-
id(new PhabricatorCrumbView())
87
-
->setName('RQ'.$releeph_request->getID())
88
-
->setHref('/RQ'.$releeph_request->getID()));
77
+
->addTextCrumb($releeph_project->getName(), $releeph_project->getURI())
78
+
->addTextCrumb(
79
+
$releeph_branch->getDisplayNameWithDetail(),
80
+
$releeph_branch->getURI())
81
+
->addTextCrumb(
82
+
'RQ'.$releeph_request->getID(),
83
+
'/RQ'.$releeph_request->getID());
89
84
90
85
return $this->buildStandardPageResponse(
91
86
array(
+2
-7
src/applications/search/controller/PhabricatorApplicationSearchController.php
+2
-7
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
260
260
261
261
$crumbs = $parent
262
262
->buildApplicationCrumbs()
263
-
->addCrumb(
264
-
id(new PhabricatorCrumbView())
265
-
->setName(pht("Search")));
263
+
->addTextCrumb(pht("Search"));
266
264
267
265
$nav->setCrumbs($crumbs);
268
266
···
344
342
345
343
$crumbs = $parent
346
344
->buildApplicationCrumbs()
347
-
->addCrumb(
348
-
id(new PhabricatorCrumbView())
349
-
->setName(pht("Saved Queries"))
350
-
->setHref($engine->getQueryManagementURI()));
345
+
->addTextCrumb(pht("Saved Queries"), $engine->getQueryManagementURI());
351
346
352
347
$nav->selectFilter('query/edit');
353
348
$nav->setCrumbs($crumbs);
+1
-3
src/applications/search/controller/PhabricatorSearchController.php
+1
-3
src/applications/search/controller/PhabricatorSearchController.php
+1
-3
src/applications/search/controller/PhabricatorSearchEditController.php
+1
-3
src/applications/search/controller/PhabricatorSearchEditController.php
+1
-3
src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
+1
-3
src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
···
244
244
->addCancelButton($cancel_uri));
245
245
246
246
$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView());
247
-
$crumbs->addCrumb(
248
-
id(new PhabricatorCrumbView())
249
-
->setName($title));
247
+
$crumbs->addTextCrumb($title);
250
248
251
249
$form_box = id(new PHUIObjectBoxView())
252
250
->setHeaderText($title)
+1
-3
src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
+1
-3
src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
···
50
50
$properties = $this->buildPropertyView($poll, $actions);
51
51
52
52
$crumbs = $this->buildApplicationCrumbs();
53
-
$crumbs->addCrumb(
54
-
id(new PhabricatorCrumbView())
55
-
->setName('V'.$poll->getID()));
53
+
$crumbs->addTextCrumb('V'.$poll->getID());
56
54
57
55
$xactions = $this->buildTransactions($poll);
58
56
$add_comment = $this->buildCommentForm($poll);
+1
-3
src/applications/tokens/controller/PhabricatorTokenGivenController.php
+1
-3
src/applications/tokens/controller/PhabricatorTokenGivenController.php
+1
-3
src/applications/tokens/controller/PhabricatorTokenLeaderController.php
+1
-3
src/applications/tokens/controller/PhabricatorTokenLeaderController.php
+16
src/view/layout/PhabricatorCrumbsView.php
+16
src/view/layout/PhabricatorCrumbsView.php
···
10
10
return false;
11
11
}
12
12
13
+
14
+
/**
15
+
* Convenience method for adding a simple crumb with just text, or text and
16
+
* a link.
17
+
*
18
+
* @param string Text of the crumb.
19
+
* @param string? Optional href for the crumb.
20
+
* @return this
21
+
*/
22
+
public function addTextCrumb($text, $href = null) {
23
+
return $this->addCrumb(
24
+
id(new PhabricatorCrumbView())
25
+
->setName($text)
26
+
->setHref($href));
27
+
}
28
+
13
29
public function addCrumb(PhabricatorCrumbView $crumb) {
14
30
$this->crumbs[] = $crumb;
15
31
return $this;