recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add tooltip for "not" search token tag in Global Search results

Summary:
These tags already use colors to differentiate. Use a tooltip for "NOT" query token tags like all the other types also do, because consistency.

Closes T16093

Test Plan:
1. Go to https://we.phorge.it/search/query/advanced/
2. In the `Query` field, enter `bleh =zsd +a NOT(x) "phrase like this" a -phasa ~amp title:fb "use meo" érr`.
3. Click `Search` button.
4. Look at the tags shown for the string `Searched For: ...`.
5. See that only red tags also use a (minus) icon.
6. Don't see a minus icon for the red token tag anymore, now get a tooltip for the red token tag.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16093

Differential Revision: https://we.phorge.it/D26057

Andre Klapper a638bafe e410020f

+1
+1
src/applications/search/query/PhabricatorFulltextToken.php
··· 62 62 $operator = $token->getOperator(); 63 63 switch ($operator) { 64 64 case PhutilSearchQueryCompiler::OPERATOR_NOT: 65 + $tip = pht('Excluding Search'); 65 66 $shade = PHUITagView::COLOR_RED; 66 67 $icon = 'fa-minus'; 67 68 break;