@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix spurious timeline entry for badges
Summary: Fixes T11164. At least, this fixes it locally for me. I don't know how to code. Copy Pasta!
Test Plan: Change name, don't see extra timeline entry on quality set anymore.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T11164
Differential Revision: https://secure.phabricator.com/D16169
+4
-4
+1
-1
src/applications/badges/editor/PhabricatorBadgesEditor.php
+1
-1
src/applications/badges/editor/PhabricatorBadgesEditor.php
···
47
47
case PhabricatorBadgesTransaction::TYPE_ICON:
48
48
return $object->getIcon();
49
49
case PhabricatorBadgesTransaction::TYPE_QUALITY:
50
-
return $object->getQuality();
50
+
return (int)$object->getQuality();
51
51
case PhabricatorBadgesTransaction::TYPE_STATUS:
52
52
return $object->getStatus();
53
53
case PhabricatorBadgesTransaction::TYPE_AWARD:
+3
-3
src/applications/badges/storage/PhabricatorBadgesTransaction.php
+3
-3
src/applications/badges/storage/PhabricatorBadgesTransaction.php
···
105
105
}
106
106
break;
107
107
case self::TYPE_QUALITY:
108
+
$qual_new = PhabricatorBadgesQuality::getQualityName($new);
109
+
$qual_old = PhabricatorBadgesQuality::getQualityName($old);
108
110
if ($old === null) {
109
111
return pht(
110
112
'%s set the quality for this badge as "%s".',
111
113
$this->renderHandleLink($author_phid),
112
-
$new);
114
+
$qual_new);
113
115
} else {
114
-
$qual_new = PhabricatorBadgesQuality::getQualityName($new);
115
-
$qual_old = PhabricatorBadgesQuality::getQualityName($old);
116
116
return pht(
117
117
'%s updated the quality for this badge from "%s" to "%s".',
118
118
$this->renderHandleLink($author_phid),