@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove extra side navs in Herald
Summary: Ref T2769. Removes some nonstandard side navs.
Test Plan: Viewed affected pages.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2769
Differential Revision: https://secure.phabricator.com/D6651
+9
-18
+5
-7
src/applications/herald/controller/HeraldNewController.php
+5
-7
src/applications/herald/controller/HeraldNewController.php
···
60
60
->setFlexible(true)
61
61
->appendChild(
62
62
id(new AphrontFormSelectControl())
63
-
->setLabel(pht('New rule for'))
63
+
->setLabel(pht('New Rule for'))
64
64
->setName('content_type')
65
65
->setValue($this->contentType)
66
66
->setOptions($content_type_map))
···
78
78
->setHref($this->getApplicationURI(
79
79
'view/'.$this->contentType.'/'.$this->ruleType)));
80
80
81
-
$nav = $this->renderNav();
82
-
$nav->selectFilter('new');
83
-
$nav->appendChild($form);
84
-
$nav->setCrumbs($crumbs);
85
-
86
81
return $this->buildApplicationPage(
87
-
$nav,
82
+
array(
83
+
$crumbs,
84
+
$form,
85
+
),
88
86
array(
89
87
'title' => pht('Create Herald Rule'),
90
88
'device' => true,
+4
-11
src/applications/herald/controller/HeraldRuleController.php
+4
-11
src/applications/herald/controller/HeraldRuleController.php
···
179
179
->buildApplicationCrumbs()
180
180
->addCrumb(
181
181
id(new PhabricatorCrumbView())
182
-
->setName($title)
183
-
->setHref('#'));
182
+
->setName($title));
184
183
185
-
$nav = $this->renderNav();
186
-
$nav->setCrumbs($crumbs);
187
-
$nav->selectFilter(
188
-
'view/'.$rule->getContentType().'/'.$rule->getRuleType());
189
-
$nav->appendChild(
184
+
return $this->buildApplicationPage(
190
185
array(
186
+
$crumbs,
191
187
$error_view,
192
188
$form,
193
-
));
194
-
195
-
return $this->buildApplicationPage(
196
-
$nav,
189
+
),
197
190
array(
198
191
'title' => pht('Edit Rule'),
199
192
'dust' => true,