recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Explain consequences when adding second Multi-Factor Auth

Summary:
Warn users who already have MFA set up that adding a second Multi-Factor Auth will require entering both instead of being able to choose from one of them.
This is currently not clear. I was surprised by this, now I have another user also surprised.

Closes T16081

Test Plan:
1. As an admin, set up TOTP as an auth provider at http://phorge.localhost/auth/mfa/
2. As a user, add a first TOTP auth factor at http://phorge.localhost/settings/panel/multifactor/
3. As a user, try to add a second TOTP auth factor and see an additional sentence in the dialog

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16081

Differential Revision: https://we.phorge.it/D26028

Andre Klapper a7f94af9 0c34164c

+9 -1
+9 -1
src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
··· 245 245 $menu->addItem($item); 246 246 } 247 247 248 - return $this->newDialog() 248 + $dialog = $this->newDialog() 249 249 ->setTitle(pht('Choose Factor Type')) 250 250 ->appendChild($menu) 251 251 ->addCancelButton($cancel_uri); 252 + 253 + if ($viewer->getIsEnrolledInMultiFactor()) { 254 + $dialog->appendRemarkup(pht( 255 + 'NOTE: You already have an Auth Factor configured. Adding '. 256 + 'another factor will require you to always provide all Auth '. 257 + 'Factors instead of selecting one of your Auth Factors.')); 258 + } 259 + return $dialog; 252 260 } 253 261 254 262 // NOTE: Beyond providing guidance, this step is also providing a CSRF gate