recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix (?) an issue with CCs not being written into commit messages properly

Summary: Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan: Verified that we now write "CC: #projectname".

Reviewers: btrahan, zeeg

Reviewed By: zeeg

CC: zeeg, aran

Differential Revision: https://secure.phabricator.com/D8296

epriestley a84cc1ab 20a3ee24

+1 -3
+1 -1
src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
··· 90 90 foreach ($this->ccs as $phid) { 91 91 $handle = $this->getHandle($phid); 92 92 if ($handle->isComplete()) { 93 - $names[] = $handle->getName(); 93 + $names[] = $handle->getObjectName(); 94 94 } 95 95 } 96 96 return implode(', ', $names);
-2
src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
··· 130 130 return null; 131 131 } 132 132 133 - $project_type = PhabricatorProjectPHIDTypeProject::TYPECONST; 134 - 135 133 $names = array(); 136 134 foreach ($this->reviewers as $phid) { 137 135 $names[] = $this->getHandle($phid)->getObjectName();