recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix broken file PHID extraction that causes Pholio uploads to crash

Summary:
A commit earlier this year modified the structure of the file upload transaction data value, by nesting the array of file upload PHIDs in another array.
The `extractFilePHIDs` method was not updated to deal with that change though, therefore new mock uploads via Pholio would crash.
This patch fixes that method so it can process the updated transaction data.

Resolves T15105

Test Plan: Patched my live Phabricator installation with this fix and successfully uploaded new Pholio mockups.

Reviewers: O1 Blessed Committers, Cigaryno, Matthew

Reviewed By: O1 Blessed Committers, Cigaryno, Matthew

Subscribers: Matthew, speck, tobiaswiese, valerio.bozzolan, Cigaryno

Tags: #pholio

Maniphest Tasks: T15105

Differential Revision: https://we.phorge.it/D25058

authored by

Thomas Iguchi and committed by
Matthew Bowker a8a38835 abb69396

+5 -3
+5 -3
src/applications/pholio/xaction/PholioImageFileTransaction.php
··· 110 110 $new_phids = $value; 111 111 112 112 $file_phids = array(); 113 - foreach ($new_phids as $phid) { 114 - $file_phids[] = $editor->loadPholioImage($object, $phid) 115 - ->getFilePHID(); 113 + foreach ($new_phids as $phids) { 114 + foreach ($phids as $phid) { 115 + $file_phids[] = $editor->loadPholioImage($object, $phid) 116 + ->getFilePHID(); 117 + } 116 118 } 117 119 118 120 return $file_phids;