@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Trigger autocomplete when "@" is typed on German keyboards
Summary:
Ref T10252. On the German keyboard layout, you must type "Alt" + "L" to generate an "@" character.
We currently ignore this event, assuming it's a keyboard command. However, I think we can safely continue so that autocomplete works on German layouts.
Test Plan:
- Switched keyboard layout to German.
- Typed Alt + L to generate an "@".
- Typed some username text.
- Got autocompleter.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10252
Differential Revision: https://secure.phabricator.com/D16259
+13
-9
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
523
523
'rsrc/js/phui/behavior-phui-tab-group.js' => '0a0b10e9',
524
524
'rsrc/js/phuix/PHUIXActionListView.js' => 'b5c256b8',
525
525
'rsrc/js/phuix/PHUIXActionView.js' => '8cf6d262',
526
-
'rsrc/js/phuix/PHUIXAutocomplete.js' => '9196fb06',
526
+
'rsrc/js/phuix/PHUIXAutocomplete.js' => '6d86ce8b',
527
527
'rsrc/js/phuix/PHUIXDropdownMenu.js' => '82e270da',
528
528
'rsrc/js/phuix/PHUIXFormControl.js' => 'e15869a8',
529
529
'rsrc/js/phuix/PHUIXIconView.js' => 'bff6884b',
···
871
871
'phui-workpanel-view-css' => '92197373',
872
872
'phuix-action-list-view' => 'b5c256b8',
873
873
'phuix-action-view' => '8cf6d262',
874
-
'phuix-autocomplete' => '9196fb06',
874
+
'phuix-autocomplete' => '6d86ce8b',
875
875
'phuix-dropdown-menu' => '82e270da',
876
876
'phuix-form-control-view' => 'e15869a8',
877
877
'phuix-icon-view' => 'bff6884b',
···
1441
1441
'javelin-typeahead',
1442
1442
'javelin-uri',
1443
1443
),
1444
+
'6d86ce8b' => array(
1445
+
'javelin-install',
1446
+
'javelin-dom',
1447
+
'phuix-icon-view',
1448
+
'phabricator-prefab',
1449
+
),
1444
1450
'70baed2f' => array(
1445
1451
'javelin-install',
1446
1452
'javelin-dom',
···
1607
1613
'javelin-behavior',
1608
1614
'javelin-dom',
1609
1615
'javelin-request',
1610
-
),
1611
-
'9196fb06' => array(
1612
-
'javelin-install',
1613
-
'javelin-dom',
1614
-
'phuix-icon-view',
1615
-
'phabricator-prefab',
1616
1616
),
1617
1617
92197373 => array(
1618
1618
'phui-workcard-view-css',
+5
-1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
+5
-1
webroot/rsrc/js/phuix/PHUIXAutocomplete.js
···
197
197
_onkeypress: function(e) {
198
198
var r = e.getRawEvent();
199
199
200
-
if (r.metaKey || r.altKey || r.ctrlKey) {
200
+
// NOTE: We allow events to continue with "altKey", because you need
201
+
// to press Alt to type characters like "@" on a German keyboard layout.
202
+
// The cost of misfiring autocompleters is very small since we do not
203
+
// eat the keystroke. See T10252.
204
+
if (r.metaKey || r.ctrlKey) {
201
205
return;
202
206
}
203
207